GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103780: Use patch instead of mock in asyncio unix events test by itamaro · Pull Request #103782 · python/cpython

Conversation

@itamaro

@itamaro itamaro commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Fixes gh-103780

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@itamaro
pythongh-103780: Use patch instead of mock in asyncio unix events test
a76f2e2 
Fixes pythongh-103780
@itamaro
itamaro requested review from 1st1, asvetlov, gvanrossum and kumaraditya303 as code owners April 24, 2023 18:33
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 24, 2023
asyncio unix events test doesn't restore mocked unix_events.can_use_pidfd #103780
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 24, 2023
@itamaro

itamaro commented Apr 24, 2023

Copy link
Copy Markdown
Contributor Author

I don't think a news entry is needed for this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
carljm
carljm requested changes Apr 24, 2023
View reviewed changes

@carljm carljm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the rest of the module, I think the form of patching that would be most consistent with the rest of the module would be the decorator form (which also avoids introducing a new indentation level):

@mock.patch('asyncio.unix_events.can_use_pidfd')
def test_get_default_child_watcher(self, m_can_use_pidfd):
    m_can_use_pidfd.return_value = False
    ...
    m_can_use_pidfd.return_value = True
    ...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
itamaro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot removed the awaiting review label Apr 24, 2023
@bedevere-bot

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Apr 24, 2023
@itamaro
Use patch decorator instead of context manager
7e0479a
@itamaro

itamaro commented Apr 24, 2023

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Apr 24, 2023
@bedevere-bot

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@carljm: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from carljm April 24, 2023 19:46
carljm
carljm approved these changes Apr 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Apr 24, 2023
@carljm carljm added the skip news label Apr 24, 2023
@carljm
carljm enabled auto-merge (squash) April 24, 2023 19:52
@carljm carljm added the needs backport to 3.11 only security fixes label Apr 24, 2023
@carljm
carljm merged commit 518050c into python:main Apr 24, 2023
@miss-islington

miss-islington commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @itamaro for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 24, 2023
@miss-islington

miss-islington commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Sorry, @itamaro and @carljm, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 518050ced18422fd00fadc1a81b0d942b98e2e5b 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned carljm Apr 24, 2023
@itamaro
itamaro deleted the fix-gh-103780 branch April 24, 2023 20:20
@carljm carljm removed their assignment Apr 24, 2023
carljm added a commit to carljm/cpython that referenced this pull request Apr 24, 2023
@carljm
Merge branch 'main' into superopt
0de5bc6 
* main:
  pythongh-101517: fix line number propagation in code generated for except* (python#103550)
  pythongh-103780: Use patch instead of mock in asyncio unix events test (python#103782)
carljm added a commit to carljm/cpython that referenced this pull request Apr 24, 2023
@carljm
Merge branch 'superopt' into superopt_spec
1972ca4 
* superopt: (82 commits)
  pythongh-101517: fix line number propagation in code generated for except* (python#103550)
  pythongh-103780: Use patch instead of mock in asyncio unix events test (python#103782)
  pythongh-102498 Clean up unused variables and imports in the email module  (python#102482)
  pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244)
  pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365)
  pythongh-94300: Update datetime.strptime documentation (python#95318)
  pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778)
  pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456)
  pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775)
  Revert "Add tests for empty range equality (python#103751)" (python#103770)
  pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519)
  pythonGH-65022: Fix description of copyreg.pickle function (python#102656)
  pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324)
  pythongh-91687: modernize dataclass example typing (python#103773)
  pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747)
  pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769)
  pythongh-87452: Improve the Popen.returncode docs
  Removed unnecessary escaping of asterisks (python#103714)
  pythonGH-102973: Slim down Fedora packages in the dev container (python#103283)
  pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095)
  ...
@ZeroIntensity ZeroIntensity removed the needs backport to 3.11 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

asyncio unix events test doesn't restore mocked unix_events.can_use_pidfd

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@itamaro @bedevere-bot @miss-islington @carljm @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.