GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99032: datetime docs: Encoding is no longer relevant by wjandrea · Pull Request #93365 · python/cpython

Conversation

@wjandrea

@wjandrea wjandrea commented May 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The .strftime() methods return a Unicode string as of Python 3.0.

For reference, under the hood, the .strftime() methods use time.strftime(), whose return value is defined here for the current tip of the main branch and here for 3.0.

Please check my work before merging to make sure I've understood what the docs are saying. I'm also not super familiar with C or RST, but I'm quite sure I've understood them correctly.

Backports should be made to all current versions.

BTW, encoding isn't mentioned in the time docs, so no changes required there I don't think.

  • Issue: Outdated info about encoding in "datetime" #99032

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@wjandrea
docs: datetime: Encoding is no longer relevant
36f3946 
The `.strftime()` methods return a Unicode string as of Python 3.0.
@wjandrea
wjandrea requested review from abalkin and pganssle as code owners May 30, 2022 22:13
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 30, 2022
@AlexWaygood AlexWaygood added the skip news label May 30, 2022
DanielNoord
DanielNoord approved these changes Jun 8, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jun 8, 2022
@AA-Turner AA-Turner added skip issue needs backport to 3.10 needs backport to 3.11 only security fixes labels Jun 8, 2022
AA-Turner
AA-Turner approved these changes Jun 8, 2022
View reviewed changes
@merwok

merwok commented Sep 29, 2022

Copy link
Copy Markdown
Member

Could you create a ticket to describe the issue and make it easier to track the fixes? Thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nanjekyejoannah nanjekyejoannah removed the skip issue label Oct 7, 2022
nanjekyejoannah
nanjekyejoannah reviewed Oct 7, 2022
View reviewed changes

@nanjekyejoannah nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, maybe we need an issue to track this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@wjandrea

wjandrea commented Oct 14, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@merwok @nanjekyejoannah I could open an issue, sure, I'm just not sure what to say beyond what I've written here. Maybe,

The docs say that strftime() will return an encoded string (i.e. bytes), but actually it returns a Unicode string as of Python 3.0 (i.e. str).

Actually, now that I think about it again, maybe it'd be better to change the warning from "may contain Unicode characters encoded ..." to "may contain non-ASCII characters." Say the word and I'll open an issue so we can discuss that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@merwok

merwok commented Oct 14, 2022

Copy link
Copy Markdown
Member

That’s just the process we follow to keep things manageable 🙂
A bug report doesn’t have to be very long, if the title is clear and the description tells clearly what the problem is, then we can apply labels to categorize the problem, note all versions that need a fix, people get notified about it, etc.
The issue describes the problem and the PR discussion can focus on the solution. That’s all!

Full details here: https://devguide.python.org/triage/issue-tracker/
wjandrea reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@wjandrea wjandrea mentioned this pull request Nov 2, 2022
Outdated info about encoding in "datetime" #99032
Closed
@Jason-Y-Z

Jason-Y-Z commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Thanks for the PR. I think you will need to include the issue number in your PR title :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood changed the title docs: datetime: Encoding is no longer relevant gh-99033: datetime docs: Encoding is no longer relevant Nov 3, 2022
@AlexWaygood AlexWaygood changed the title gh-99033: datetime docs: Encoding is no longer relevant gh-99032: datetime docs: Encoding is no longer relevant Nov 3, 2022
@hugovk hugovk removed the needs backport to 3.10 label Apr 7, 2023
pganssle
pganssle requested changes Apr 24, 2023
View reviewed changes
Comment thread Doc/library/datetime.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Apr 24, 2023
@bedevere-bot

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pganssle
Update Doc/library/datetime.rst
8754eff
pganssle
pganssle approved these changes Apr 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot removed the awaiting changes label Apr 24, 2023
@bedevere-bot bedevere-bot added the awaiting merge label Apr 24, 2023
@pganssle
Merge branch 'main' into patch-2
2d3d97c
abalkin
abalkin approved these changes Apr 24, 2023
View reviewed changes

@abalkin abalkin left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pganssle
pganssle merged commit 2aa22f7 into python:main Apr 24, 2023
@miss-islington

miss-islington commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @wjandrea for the PR, and @pganssle for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 24, 2023
@wjandrea @pganssle @miss-islington
pythongh-99032: datetime docs: Encoding is no longer relevant (python…
50c797a 
…GH-93365)

This removes a section of the `strftime` and `strptime` documentation that refers to a bygone era when `strftime` would return an encoded byte string.

---------

(cherry picked from commit 2aa22f7)

Co-authored-by: William Andrea <[email protected]>
Co-authored-by: Paul Ganssle <[email protected]>
@bedevere-bot

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

GH-103788 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 24, 2023
@wjandrea
wjandrea deleted the patch-2 branch April 24, 2023 19:00
carljm added a commit to carljm/cpython that referenced this pull request Apr 24, 2023
@carljm
Merge branch 'main' into superopt
19b8025 
* main: (53 commits)
  pythongh-102498 Clean up unused variables and imports in the email module  (python#102482)
  pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244)
  pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365)
  pythongh-94300: Update datetime.strptime documentation (python#95318)
  pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778)
  pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456)
  pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775)
  Revert "Add tests for empty range equality (python#103751)" (python#103770)
  pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519)
  pythonGH-65022: Fix description of copyreg.pickle function (python#102656)
  pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324)
  pythongh-91687: modernize dataclass example typing (python#103773)
  pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747)
  pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769)
  pythongh-87452: Improve the Popen.returncode docs
  Removed unnecessary escaping of asterisks (python#103714)
  pythonGH-102973: Slim down Fedora packages in the dev container (python#103283)
  pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095)
  Add tests for empty range equality (python#103751)
  pythongh-103712: Increase the length of the type name in AttributeError messages (python#103713)
  ...
carljm added a commit to carljm/cpython that referenced this pull request Apr 24, 2023
@carljm
Merge branch 'superopt' into superopt_spec
1972ca4 
* superopt: (82 commits)
  pythongh-101517: fix line number propagation in code generated for except* (python#103550)
  pythongh-103780: Use patch instead of mock in asyncio unix events test (python#103782)
  pythongh-102498 Clean up unused variables and imports in the email module  (python#102482)
  pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244)
  pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365)
  pythongh-94300: Update datetime.strptime documentation (python#95318)
  pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778)
  pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456)
  pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775)
  Revert "Add tests for empty range equality (python#103751)" (python#103770)
  pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519)
  pythonGH-65022: Fix description of copyreg.pickle function (python#102656)
  pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324)
  pythongh-91687: modernize dataclass example typing (python#103773)
  pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747)
  pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769)
  pythongh-87452: Improve the Popen.returncode docs
  Removed unnecessary escaping of asterisks (python#103714)
  pythonGH-102973: Slim down Fedora packages in the dev container (python#103283)
  pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095)
  ...
JelleZijlstra pushed a commit that referenced this pull request Apr 29, 2023
@miss-islington @wjandrea
@pganssle @ambv
[3.11] gh-99032: datetime docs: Encoding is no longer relevant (GH-93365
9fbb614 
) (#103788)

This removes a section of the `strftime` and `strptime` documentation that refers to a bygone era when `strftime` would return an encoded byte string.

---------

(cherry picked from commit 2aa22f7)

Co-authored-by: William Andrea <[email protected]>
Co-authored-by: Paul Ganssle <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@pganssle pganssle pganssle approved these changes
@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments
@abalkin abalkin abalkin approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes
+1 more reviewer
@DanielNoord DanielNoord DanielNoord approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@wjandrea @merwok @Jason-Y-Z @bedevere-bot @miss-islington @abalkin @pganssle @AA-Turner @DanielNoord @nanjekyejoannah @hugovk @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.