GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103636: issue warning for deprecated calendar constants by Agent-Hellboy · Pull Request #103833 · python/cpython

Conversation

@Agent-Hellboy

@Agent-Hellboy Agent-Hellboy commented Apr 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Convert calendar constants to enums and add months #103636

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Agent-Hellboy added 2 commits April 25, 2023 20:23
@Agent-Hellboy
pythongh-103636: raise warning for January and February attribute
175dadf
@Agent-Hellboy
add test
97436c8
@bedevere-bot bedevere-bot mentioned this pull request Apr 26, 2023
Convert calendar constants to enums and add months #103636
Closed
@arhadthedev arhadthedev added the stdlib Standard Library Python modules in the Lib/ directory label Apr 26, 2023
hugovk
hugovk requested changes Apr 26, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you add a NEWS file and document the deprecation at https://docs.python.org/3.12/whatsnew/3.12.html#deprecated?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Apr 26, 2023
@bedevere-bot

bedevere-bot commented Apr 26, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
merwok
merwok reviewed Apr 26, 2023
View reviewed changes
Comment thread Lib/test/test_calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
blurb-it Bot and others added 3 commits April 26, 2023 18:12
@blurb-it
📜🤖 Added by blurb_it.
e6f2a2f
@Agent-Hellboy
update docs for depration warning and new additions
5a4d0a7
@Agent-Hellboy
dedent line in calendar test
ddcdc43
@Agent-Hellboy

Agent-Hellboy commented Apr 26, 2023

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Apr 26, 2023
@bedevere-bot

bedevere-bot commented Apr 26, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from hugovk April 26, 2023 18:42
Agent-Hellboy added 5 commits April 27, 2023 00:24
@Agent-Hellboy
fix doc
794dddc
@Agent-Hellboy
fix doc
717cea8
@Agent-Hellboy
fix doc
b2c13e8
@Agent-Hellboy
fix doc
029844f
@Agent-Hellboy
fix doc
0c52a19
merwok
merwok reviewed Apr 26, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
merwok
merwok reviewed Apr 26, 2023
View reviewed changes
Comment thread Lib/calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2023-04-26-18-12-13.gh-issue-103636.-KvCgO.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
merwok added 2 commits April 26, 2023 17:35
@merwok
fix spacing
ac783cf
@merwok
Merge branch 'main' into raise-warning-in-calendar-mod
a18a064
merwok
merwok reviewed Apr 26, 2023
View reviewed changes
Comment thread Doc/library/calendar.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Agent-Hellboy
fix grametical mistake
e002e10
@Agent-Hellboy

Agent-Hellboy commented Apr 27, 2023

Copy link
Copy Markdown
Contributor Author

sorry for the silly mistakes, I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Apr 27, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk requested changes Apr 27, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip: You can directly apply all the suggestions you want in one go with Files changed -> Add to batch -> Commit

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Agent-Hellboy reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2023-04-26-18-12-13.gh-issue-103636.-KvCgO.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Apr 27, 2023
@bedevere-bot

bedevere-bot commented Apr 27, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from hugovk April 27, 2023 12:40
merwok
merwok reviewed Apr 27, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
merwok
merwok reviewed Apr 27, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Agent-Hellboy and others added 3 commits April 27, 2023 20:14
@Agent-Hellboy @merwok
Update Doc/whatsnew/3.12.rst
49079d1 
Co-authored-by: Éric <[email protected]>
@Agent-Hellboy @merwok
Update Doc/whatsnew/3.12.rst
db53e78 
Co-authored-by: Éric <[email protected]>
@Agent-Hellboy
fix doc
9c289c5
@merwok merwok changed the title gh-103636: raise warning for January and February attribute gh-103636: issue warning for deprecated calendar constants Apr 27, 2023
@merwok
Merge branch 'main' into raise-warning-in-calendar-mod
4b497b2
merwok
merwok approved these changes Apr 27, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Apr 27, 2023
@merwok merwok assigned hugovk Apr 27, 2023
@merwok merwok added 3.12 only security fixes awaiting core review and removed awaiting merge labels Apr 27, 2023
hugovk
hugovk requested changes Apr 28, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, almost there!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/calendar.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/calendar.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Apr 28, 2023
@bedevere-bot

bedevere-bot commented Apr 28, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Agent-Hellboy and others added 2 commits April 28, 2023 09:23
@Agent-Hellboy @hugovk
Update Doc/library/calendar.rst
7ec1945 
Co-authored-by: Hugo van Kemenade <[email protected]>
@Agent-Hellboy @hugovk
Update Doc/library/calendar.rst
7628f11 
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
hugovk approved these changes Apr 28, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Agent-Hellboy reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Apr 28, 2023
@hugovk
hugovk merged commit 84e7d0f into python:main Apr 29, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 29, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
@carljm
Merge branch 'main' into supermon
159b2aa 
* main: (26 commits)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  pythongh-88773: Added teleport method to Turtle library (python#103974)
  pythongh-104015: Fix direct invocation of `test_dataclasses` (python#104017)
  pythongh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes (python#104014)
  pythongh-103977: compile re expressions in platform.py only if required (python#103981)
  pythongh-98003: Inline call frames for CALL_FUNCTION_EX (pythonGH-98004)
  Replace Netlify with Read the Docs build previews (python#103843)
  Update name in acknowledgements and add mailmap (python#103696)
  pythongh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. (python#103927)
  Remove non-existing tools from Sundry skiplist (python#103991)
  pythongh-103793: Defer formatting task name (python#103767)
  pythongh-87092: change assembler to use instruction sequence instead of CFG (python#103933)
  pythongh-103636: issue warning for deprecated calendar constants (python#103833)
  Various small fixes to dis docs (python#103923)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok approved these changes
@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

3.12 only security fixes stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Agent-Hellboy @bedevere-bot @merwok @hugovk @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.