GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Various small fixes to dis docs by JelleZijlstra · Pull Request #103923 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Apr 27, 2023

Copy link
Copy Markdown
Member
  • Fix description of MAKE_CELL, which appeared to be inverted from the
    actual behavior
  • Fix stray ".:" (Detect ".::" before a code block sphinx-contrib/sphinx-lint#63)
  • Fix inconsistent indentation
  • Add some missing code blocks
  • Slight style improvements

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
Improve formatting of dis docs
2abde5d 
- Fix description of MAKE_CELL, which appeared to be inverted from the
  actual behavior
- Fix stray ".:" (sphinx-contrib/sphinx-lint#63)
- Fix inconsistent indentation
- Add some missing code blocks
- Slight style improvements
@JelleZijlstra JelleZijlstra added docs Documentation in the Doc dir skip issue skip news needs backport to 3.11 only security fixes labels Apr 27, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Apr 27, 2023
hauntsaninja
hauntsaninja approved these changes Apr 29, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 29, 2023
@hauntsaninja hauntsaninja changed the title Improve formatting of dis docs Various small fixes to dis docs Apr 29, 2023
@hauntsaninja
hauntsaninja merged commit ed29f52 into python:main Apr 29, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 29, 2023
@miss-islington

miss-islington commented Apr 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Apr 29, 2023

Copy link
Copy Markdown
Contributor

Sorry, @JelleZijlstra and @hauntsaninja, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ed29f524cf7d2fd11d420604f80f1d4cf0079891 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned hauntsaninja Apr 29, 2023
hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Apr 29, 2023
@hauntsaninja
[3.11] Fix description of MAKE_CELL
ebee00b 
Backport of part of python#103923
@hauntsaninja hauntsaninja mentioned this pull request Apr 29, 2023
[3.11] Fix description of MAKE_CELL #103985
Closed
hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Apr 29, 2023
@hauntsaninja
[3.11] Fix description of MAKE_CELL
abf86a1 
Backport of part of python#103923
@hauntsaninja hauntsaninja mentioned this pull request Apr 29, 2023
[3.11] Fix description of MAKE_CELL #103986
Merged
@JelleZijlstra
JelleZijlstra deleted the disdoc branch April 29, 2023 13:11
JelleZijlstra pushed a commit that referenced this pull request Apr 29, 2023
@hauntsaninja
[3.11] Fix description of MAKE_CELL (#103986)
86ef1ce 
Backport of part of #103923
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
@carljm
Merge branch 'main' into supermon
159b2aa 
* main: (26 commits)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  pythongh-88773: Added teleport method to Turtle library (python#103974)
  pythongh-104015: Fix direct invocation of `test_dataclasses` (python#104017)
  pythongh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes (python#104014)
  pythongh-103977: compile re expressions in platform.py only if required (python#103981)
  pythongh-98003: Inline call frames for CALL_FUNCTION_EX (pythonGH-98004)
  Replace Netlify with Read the Docs build previews (python#103843)
  Update name in acknowledgements and add mailmap (python#103696)
  pythongh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. (python#103927)
  Remove non-existing tools from Sundry skiplist (python#103991)
  pythongh-103793: Defer formatting task name (python#103767)
  pythongh-87092: change assembler to use instruction sequence instead of CFG (python#103933)
  pythongh-103636: issue warning for deprecated calendar constants (python#103833)
  Various small fixes to dis docs (python#103923)
  ...
@JelleZijlstra
JelleZijlstra restored the disdoc branch September 10, 2024 23:37
@ZeroIntensity ZeroIntensity removed the needs backport to 3.11 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hauntsaninja hauntsaninja

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JelleZijlstra @miss-islington @hauntsaninja @bedevere-bot @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.