GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — GH-96803: Document and test new unstable internal frame API functions by markshannon · Pull Request #104211 · python/cpython

Conversation

markshannon commented May 5, 2023 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Expose _PyInterpreterFrame_GetLine in the private API #96803

📚 Documentation preview 📚: https://cpython-previews--104211.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

markshannon added 4 commits

May 5, 2023 01:25


          Document new unstable internal frame API functions

9bcf13a


          Weaken contract of PyUnstable_InterpreterFrame_GetCode to return PyOb…

c144a62

…ject*.


          Add tests

dea0300


          Use correct sphinx tag

2a82445

bedevere-bot mentioned this pull request

May 5, 2023

Expose _PyInterpreterFrame_GetLine in the private API #96803

Closed

bedevere-bot added docs

Documentation in the Doc dir

skip news awaiting core review labels

May 5, 2023

markshannon removed the awaiting core review label

May 5, 2023

bedevere-bot added the awaiting core review label

May 5, 2023

carljm reviewed

May 5, 2023

View reviewed changes

Comment thread

Doc/c-api/frame.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/frame.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/frame.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/frame.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/frame.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

markshannon and others added 3 commits

May 5, 2023 22:13


          Merge branch 'main' into doc-internal-frame-api

b9d25c5


          Apply suggestions from code review

1e7a1a0

Co-authored-by: Carl Meyer <[email protected]>


          Merge branch 'main' into doc-internal-frame-api

37a96e2

markshannon changed the title ~~GH-96803: Document new unstable internal frame API functions~~ GH-96803: Document and test new unstable internal frame API functions

May 9, 2023

markshannon closed this

May 9, 2023

carljm commented May 9, 2023

Copy link

Copy Markdown

Member

@markshannon Did you intend to close this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

markshannon reopened this

May 9, 2023

markshannon commented May 9, 2023

Copy link

Copy Markdown

Member Author

I tried to close and reopen it earlier to force it to update, but GitHub was unwell earlier today.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

markshannon commented May 9, 2023

Copy link

Copy Markdown

Member Author

Latest commits still aren't showing up 😕

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

markshannon closed this

May 9, 2023

markshannon reopened this

May 9, 2023

markshannon commented May 9, 2023

Copy link

Copy Markdown

Member Author

Merging main seems to woken GitHub up.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

carljm approved these changes

May 9, 2023

View reviewed changes

Comment thread

Doc/c-api/frame.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/frame.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting merge and removed awaiting core review labels

May 9, 2023


          Apply suggestions from code review

86865b5

Co-authored-by: Carl Meyer <[email protected]>

erlend-aasland reviewed

May 16, 2023

View reviewed changes

Comment thread

Doc/c-api/frame.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Doc/c-api/frame.rst

31e386c

Co-authored-by: Erlend E. Aasland <[email protected]>

erlend-aasland approved these changes

May 16, 2023

View reviewed changes

markshannon merged commit cfa517d into python:main

May 18, 2023

bedevere-bot removed the awaiting merge label

May 18, 2023

carljm added a commit to carljm/cpython that referenced this pull request

May 18, 2023


          Merge branch 'main' into nestedcomps

54095f0

* main:
  pythongh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols (python#104622)
  pythongh-104623: Update Windows installer to use SQLite 3.42.0 (python#104625)
  pythongh-104050: Add more type annotations to Argument Clinic (python#104628)
  pythongh-104629: Don't skip test_clinic if _testclinic is missing (python#104630)
  pythongh-104549: Set __module__ on TypeAliasType (python#104550)
  pythongh-104050: Improve some typing around `default`s and sentinel values (python#104626)
  pythongh-104146: Remove unused vars from Argument Clinic (python#104627)
  pythongh-104615: don't make unsafe swaps in apply_static_swaps (python#104620)
  pythonGH-104484: Add case_sensitive argument to `pathlib.PurePath.match()` (pythonGH-104565)
  pythonGH-96803: Document and test new unstable internal frame API functions (pythonGH-104211)
  pythonGH-104580: Don't cache eval breaker in interpreter (pythonGH-104581)

markshannon deleted the doc-internal-frame-api branch

September 26, 2023 12:56

Reviewers

AA-Turner

AA-Turner left review comments

carljm

carljm approved these changes

erlend-aasland

erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

markshannon commented May 5, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carljm commented May 9, 2023

Uh oh!

markshannon commented May 9, 2023

Uh oh!

markshannon commented May 9, 2023

Uh oh!

markshannon commented May 9, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

markshannon commented May 5, 2023 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.