GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101819: Refactor _io in preparation for module isolation by erlend-aasland · Pull Request #104334 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Isolate the _io extension module #101819

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
erlend-aasland added 9 commits May 9, 2023 18:04
@erlend-aasland
Refactor: replace query with parameter
14f923e 
Pass module state to bufferediobase_unsupported()
@erlend-aasland
Refactor: replace query with parameter
482f134 
Pass module state to iobase_unsupported()
@erlend-aasland
Refactor: hide delegate
8adc0cd 
Add method wrapper for _PyIOBase_check_seekable.
@erlend-aasland
Refactor: hide delegate
703440a 
Add method wraper for _PyIOBase_check_readable
@erlend-aasland
Refactor: hide delegate
ea9c098 
Add method wraper for _PyIOBase_check_writable
@erlend-aasland
Add io state struct forward declaration.
e940ed3
@erlend-aasland
Refactor: replace query with parameter
c68d657 
Pass module state to _PyIOBase_check_seekable()
@erlend-aasland
Refactor: replace query with parameter
0084715 
Pass module state to _PyIOBase_check_readable()
@erlend-aasland
Refactor: replace query with parameter
20777e7 
Pass module state to _PyIOBase_check_writable()
@erlend-aasland erlend-aasland added the skip news label May 9, 2023
@erlend-aasland
erlend-aasland requested a review from kumaraditya303 May 9, 2023 16:43
@bedevere-bot bedevere-bot mentioned this pull request May 9, 2023
Isolate the _io extension module #101819
Closed
@bedevere-bot bedevere-bot added the awaiting core review label May 9, 2023
@erlend-aasland
Fetch state by module def in _io__Buffered_seek_impl()
b22b41d
vstinner
vstinner approved these changes May 9, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have a coding style suggestion for the header file (_iomodule.h).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_io/_iomodule.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 9, 2023
@erlend-aasland
Address review: improve forward decl. of _PyIO_State
0044293
@erlend-aasland
erlend-aasland enabled auto-merge (squash) May 9, 2023 22:32
vstinner
vstinner reviewed May 9, 2023
View reviewed changes
Comment thread Modules/_io/_iomodule.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Address review: remove second typedef
7aa8da7 
It may provoke compiler warnings
vstinner
vstinner approved these changes May 9, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The _iomodule.h typedef LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@erlend-aasland
erlend-aasland merged commit 235b827 into python:main May 9, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 9, 2023
@erlend-aasland
erlend-aasland deleted the isolate-io/refactorings branch May 10, 2023 04:41
carljm added a commit to carljm/cpython that referenced this pull request May 10, 2023
@carljm
Merge branch 'main' into fixloadsuperspec
5976df9 
* main:
  pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)
  pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)
  pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)
  pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)
  pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)
  pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)
  pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)
  pythongh-103960: Dark mode: invert image brightness (python#103983)
  pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)
  pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354)
  pythongh-101819: Harden _io init (python#104352)
  pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226)
  pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849)
  pythongh-74895: adjust tests to work on Solaris (python#104326)
  pythongh-101819: Refactor _io in preparation for module isolation (python#104334)
  pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322)
  pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request()
  pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.