GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message by Eclips4 · Pull Request #104335 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented May 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Bad error message when inheriting from Generic multiple times #104328

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Eclips4
Fix typo
19e8bd7
@Eclips4
Eclips4 requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners May 9, 2023 16:50
@bedevere-bot bedevere-bot mentioned this pull request May 9, 2023
Bad error message when inheriting from Generic multiple times #104328
Closed
@bedevere-bot bedevere-bot added the awaiting review label May 9, 2023
@Eclips4 Eclips4 changed the title gh-104328: Fix typo in error gh-104328: Fix typo in error message May 9, 2023
@gvanrossum
gvanrossum removed their request for review May 9, 2023 17:34
AA-Turner
AA-Turner approved these changes May 9, 2023
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct per issue.

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 9, 2023
@AA-Turner AA-Turner changed the title gh-104328: Fix typo in error message gh-104328: Fix typo in typing.Generic multiple inheritance error message May 9, 2023
@bedevere-bot bedevere-bot added awaiting review and removed awaiting core review labels May 9, 2023
@AA-Turner AA-Turner added awaiting core review and removed awaiting review labels May 9, 2023
@carljm carljm added the skip news label May 9, 2023
@carljm
carljm merged commit 01c321c into python:main May 9, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 9, 2023
@carljm carljm added the needs backport to 3.11 only security fixes label May 9, 2023
@miss-islington

miss-islington commented May 9, 2023

Copy link
Copy Markdown
Contributor

Thanks @Eclips4 for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented May 9, 2023

Copy link
Copy Markdown

GH-104338 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 9, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2023
@Eclips4 @miss-islington
pythongh-104328: Fix typo in typing.Generic multiple inheritance …
528cc01
…error message (pythonGH-104335)

(cherry picked from commit 01c321c)

Co-authored-by: Kirill Podoprigora <[email protected]>
AlexWaygood pushed a commit that referenced this pull request May 9, 2023
@miss-islington @Eclips4
[3.11] gh-104328: Fix typo in typing.Generic multiple inheritance…
663b321
… error message (GH-104335) (#104338)

gh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (GH-104335)
(cherry picked from commit 01c321c)

Co-authored-by: Kirill Podoprigora <[email protected]>
@Eclips4
Eclips4 deleted the issue_104328 branch May 9, 2023 20:00
carljm added a commit to carljm/cpython that referenced this pull request May 10, 2023
@carljm
Merge branch 'main' into fixloadsuperspec
5976df9
* main:
  pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)
  pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)
  pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)
  pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)
  pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)
  pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)
  pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)
  pythongh-103960: Dark mode: invert image brightness (python#103983)
  pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)
  pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354)
  pythongh-101819: Harden _io init (python#104352)
  pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226)
  pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849)
  pythongh-74895: adjust tests to work on Solaris (python#104326)
  pythongh-101819: Refactor _io in preparation for module isolation (python#104334)
  pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322)
  pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request()
  pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Eclips4 @miss-islington @bedevere-bot @AA-Turner @carljm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.