GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-104482: Fix error handling bugs in ast.c by iritkatriel · Pull Request #104483 · python/cpython

Conversation

iritkatriel commented May 14, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Fixes #104482.

Issue: Error handling bugs in ast.c #104482

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-104482: Fix error handling bugs in ast.c

5a4e346

iritkatriel requested a review from brandtbucher

May 14, 2023 18:53

iritkatriel requested review from isidentical and markshannon as code owners

May 14, 2023 18:53

bedevere-bot added the awaiting core review label

May 14, 2023

bedevere-bot mentioned this pull request

May 14, 2023

Error handling bugs in ast.c #104482

Closed

iritkatriel commented May 14, 2023

Copy link

Copy Markdown

Member Author

I don't know if you want to add more tests for this - the assertion I added would fail without this fix.

sunmy2019 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel commented

May 14, 2023

View reviewed changes

Comment thread

Python/ast.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          whitespace

0d9d4b0

iritkatriel added type-bug

An unexpected behavior, bug, or error

needs backport to 3.11 only security fixes labels

May 14, 2023

blurb-it Bot and others added 4 commits

May 14, 2023 18:56


          📜🤖 Added by blurb_it.

35dae76


          Merge branch 'main' into missingBreak

2f185bc


          Merge branch 'main' into missingBreak

e2f0e8e


          Merge branch 'main' into missingBreak

31b611e

carljm approved these changes

May 15, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

May 15, 2023

furkanonder commented May 15, 2023

Copy link

Copy Markdown

Contributor

CC: @isidentical

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

isidentical approved these changes

May 15, 2023

View reviewed changes

Comment thread

Python/compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel commented

May 15, 2023

View reviewed changes

Comment thread

Python/ast.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel added 2 commits

May 15, 2023 18:30


          add one more missing break

72577b1


          add test to cover bad name case. Add assertions in validation functio…

d925fff

…ns to catch this as soon as it occurs

carljm reviewed

May 15, 2023

View reviewed changes

Comment thread

Misc/NEWS.d/next/Core and Builtins/2023-05-14-18-56-54.gh-issue-104482.yaQsv8.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Python/ast.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel commented

May 15, 2023

View reviewed changes

Comment thread

Misc/NEWS.d/next/Core and Builtins/2023-05-14-18-56-54.gh-issue-104482.yaQsv8.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel and others added 2 commits

May 15, 2023 19:39


          Update news

9dd4fee


          missed a few loops

43a9d47

iritkatriel commented

May 15, 2023

View reviewed changes

Comment thread

Misc/NEWS.d/next/Core and Builtins/2023-05-14-18-56-54.gh-issue-104482.yaQsv8.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          fix news wording

8370aef

iritkatriel commented May 15, 2023

Copy link

Copy Markdown

Member Author

The hypothesis bot fails everywhere. We’re good.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel merged commit 8a3702f into python:main

May 15, 2023

miss-islington commented May 15, 2023

Copy link

Copy Markdown

Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

May 15, 2023

miss-islington commented May 15, 2023

Copy link

Copy Markdown

Contributor

Sorry, @iritkatriel, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8a3702f0c79e5a99fcef61e35724f4b9ea3453b8 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned iritkatriel

May 15, 2023

iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label

May 15, 2023

iritkatriel mentioned this pull request

May 15, 2023

[3.11] gh-104482: Fix error handling bugs in ast.c #104514

Merged

carljm added a commit to carljm/cpython that referenced this pull request

May 16, 2023


          Merge branch 'main' into supermon

a6dd626

* main:
  pythonGH-104510: Fix refleaks in `_io` base types (python#104516)
  pythongh-104539: Fix indentation error in logging.config.rst (python#104545)
  pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)
  pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)
  pythongh-64595: Fix write file logic in Argument Clinic (python#104507)
  pythongh-104523: Inline minimal PGO rules (python#104524)
  pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863)
  pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248)
  pythongh-103763: Implement PEP 695 (python#103764)
  pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462)
  pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503)
  pythongh-104482: Fix error handling bugs in ast.c (python#104483)
  pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437)
  pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)

iritkatriel deleted the missingBreak branch

July 25, 2023 18:03

ZeroIntensity removed type-bug

An unexpected behavior, bug, or error

interpreter-core

(Objects, Python, Grammar, and Parser dirs)

needs backport to 3.11 only security fixes labels

Feb 17, 2025

Reviewers

carljm

carljm approved these changes

isidentical

isidentical approved these changes

brandtbucher

Awaiting requested review from brandtbucher

markshannon

Awaiting requested review from markshannon

markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

iritkatriel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error handling bugs in ast.c

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

iritkatriel commented May 14, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iritkatriel commented May 14, 2023

Uh oh!

Uh oh!

furkanonder commented May 15, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iritkatriel commented May 15, 2023

Uh oh!

miss-islington commented May 15, 2023

Uh oh!

miss-islington commented May 15, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

iritkatriel commented May 14, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.