GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-62519: Make pgettext search plurals when translation is not found by tomasr8 · Pull Request #107118 · python/cpython

Conversation

@tomasr8

@tomasr8 tomasr8 commented Jul 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Related issue: #62519

Now that gettext is fixed, let's also fix pgettext.

  • Issue: gettext() cannot find translations with plural forms #62519

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka and m-aciek reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
tomasr8 added 2 commits July 23, 2023 12:21
@tomasr8
Make pgettext search plurals when translation is not found
00a3667
@tomasr8
Add changelog
ee6d3b8
@bedevere-bot bedevere-bot mentioned this pull request Jul 23, 2023
gettext() cannot find translations with plural forms #62519
Closed
@bedevere-bot bedevere-bot added the awaiting review label Jul 23, 2023
ambv
ambv reviewed Jul 23, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2023-07-23-12-26-23.gh-issue-62519.w8-81X.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ambv
Update Misc/NEWS.d/next/Library/2023-07-23-12-26-23.gh-issue-62519.w8…
4c9f6da
…-81X.rst
@ambv
ambv merged commit b3c34e5 into python:main Jul 23, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Jul 23, 2023
@tomasr8
tomasr8 deleted the pgettext-bugfix branch July 23, 2023 14:08
@ambv ambv added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 23, 2023
@miss-islington

miss-islington commented Jul 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @tomasr8 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Jul 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @tomasr8 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Jul 23, 2023

Copy link
Copy Markdown

GH-107133 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2023
@tomasr8 @ambv @miss-islington
pythongh-62519: Make pgettext search plurals when translation is not …
85dff8c
…found (pythonGH-107118)

(cherry picked from commit b3c34e5)

Co-authored-by: Tomas R <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 23, 2023
@bedevere-bot

bedevere-bot commented Jul 23, 2023

Copy link
Copy Markdown

GH-107134 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 23, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2023
@tomasr8 @ambv @miss-islington
pythongh-62519: Make pgettext search plurals when translation is not …
d7fdfb5
…found (pythonGH-107118)

(cherry picked from commit b3c34e5)

Co-authored-by: Tomas R <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 23, 2023
@tomasr8 @ambv @jtcave
pythongh-62519: Make pgettext search plurals when translation is not …
73f1ba3
…found (python#107118)

Co-authored-by: Łukasz Langa <[email protected]>
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
@tomasr8 @ambv @mementum
pythongh-62519: Make pgettext search plurals when translation is not …
307e1e2
…found (python#107118)

Co-authored-by: Łukasz Langa <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Jul 24, 2023
@carljm
Merge branch 'main' into superfix
9a6bdfa
* main: (73 commits)
  Thoroughly refactor the cases generator (python#107151)
  Docs: Add missing markup to Argument Clinic docs (python#106876)
  pythongh-107162: Document errcode.h usage in its comment (python#107177)
  pythongh-106320: Remove private _PyDict C API (python#107145)
  Fix PyVectorcall_Function doc versionadded (python#107140)
  Docs: Remove duplicate word in Argument Clinic howto heading (python#107169)
  pythongh-107017: Change Chapter Strings to Texts in the Introduction chapter. (python#107104)
  pythongh-106320: Remove private _PyObject C API (python#107159)
  Docs: fix typo in os.pwrite docstring (python#107087)
  pythongh-105291: Add link to migration guide for distutils (python#107130)
  pythongh-106948: Docs: Disable links for C standard library functions, OS utility functions and system calls (python#107062)
  pythongh-106320: Remove _PyBytes_Join() C API (python#107144)
  pythongh-106320: Remove private _PyObject C API (python#107147)
  pythongh-106320: Remove _PyTuple_MaybeUntrack() C API (python#107143)
  pythongh-106320: Remove _PyIsSelectable_fd() C API (python#107142)
  Remove superflous whitespaces in `layout.html`. (pythonGH-107067)
  pythongh-107122: Update what's news for dbm.*dbm.clear() method (pythongh-107135)
  pythongh-107122: Add clear method to dbm.ndbm module (pythongh-107126)
  pythongh-62519: Make pgettext search plurals when translation is not found (python#107118)
  pythongh-107122: Add clear method to dbm.gdbm.module (pythongh-107127)
  ...
serhiy-storchaka pushed a commit that referenced this pull request Jul 25, 2023
@miss-islington @tomasr8 @ambv
[3.12] gh-62519: Make pgettext search plurals when translation is not…
11d86c5
… found (GH-107118) (GH-107134)

(cherry picked from commit b3c34e5)

Co-authored-by: Tomas R <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Jul 25, 2023
@miss-islington @tomasr8 @ambv
[3.11] gh-62519: Make pgettext search plurals when translation is not…
41756e3
… found (GH-107118) (GH-107133)

(cherry picked from commit b3c34e5)

Co-authored-by: Tomas R <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@tomasr8 tomasr8 mentioned this pull request May 13, 2024
Make pgettext search plurals when translation is not found python-babel/babel#1085
Merged
akx pushed a commit to python-babel/babel that referenced this pull request Jul 11, 2024
@tomasr8
Make pgettext search plurals when translation is not found (#1085)
8de07f3
pgettext can now find the following translation
when using `pgettext("ctx", "foo")`:
```
msgctxt "ctx"
msgid "foo"
msgid_plural "foos"
msgstr[0] "foo translated"
```

The upstream CPython PR is  python/cpython#107118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tomasr8 @miss-islington @bedevere-bot @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.