GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Clarify documentation about PyVectorcall_Function by da-woods · Pull Request #107140 · python/cpython

Conversation

da-woods commented Jul 23, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

The documentation implies that PyVectorcall_Function was available in Python 3.8.

This is half-true - it was available under a different name. I think it's clearer to set the "version added" to 3.9

📚 Documentation preview 📚: https://cpython-previews--107140.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Clarify documentation about PyVectorcall_*

3b9e279

The documentation implies that PyVectorcall_NARGS, PyVectorcall_Function, and PyVectorcall_Call were available in Python 3.8.

This is half-true - they were available under a different name. I think it's clearer to set the "version added" to 3.9

bedevere-bot added awaiting review docs

Documentation in the Doc dir

skip news labels

Jul 23, 2023

da-woods referenced this pull request in cython/cython

Jul 23, 2023


          Use the public (since Py3.8) C-API function in the vectorcall code in…

e1d06dc

…stead of a private function that is now removed in Py3.13.

da-woods mentioned this pull request

Jul 23, 2023

C API: Cython 3.0 uses private functions removed in Python 3.13 (numpy 1.25.1 fails to build) #107076

Closed

vstinner reviewed

Jul 23, 2023

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only PyVectorcall_Function() versionadded is wrong, no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/c-api/call.rst Outdated

		for future extensions.

		.. versionadded:: 3.8
		.. versionadded:: 3.9

vstinner Jul 23, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyVectorcall_NARGS() is defined as a static inline function in Python 3.8.0: https://github.com/python/cpython/blob/v3.8.0/Include/cpython/abstract.h#L75

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/c-api/call.rst Outdated

		and it does not fall back to ``tp_call``.

		.. versionadded:: 3.8
		.. versionadded:: 3.9

vstinner Jul 23, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Python 3.8.0, PyVectorcall_Call() was already defined as a regular function: https://github.com/python/cpython/blob/v3.8.0/Include/cpython/abstract.h#L141

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner added the skip issue label

Jul 23, 2023


          revert NARGS and Call

68b6c82

da-woods changed the title Clarify documentation about PyVectorcall_* Clarify documentation about PyVectorcall_Function

Jul 24, 2023

da-woods commented Jul 24, 2023

Copy link

Copy Markdown

Contributor Author

Thanks for the clarification @vstinner - I think I confused myself trying to look at diffs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner merged commit 0a9b339 into python:main

Jul 24, 2023

bedevere-bot removed the awaiting review label

Jul 24, 2023

vstinner commented Jul 24, 2023

Copy link

Copy Markdown

Member

Merged, thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Jul 24, 2023

miss-islington commented Jul 24, 2023

Copy link

Copy Markdown

Contributor

Thanks @da-woods for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Jul 24, 2023

Copy link

Copy Markdown

Contributor

Thanks @da-woods for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Jul 24, 2023

Copy link

Copy Markdown

GH-107173 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

Jul 24, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 24, 2023


          Fix PyVectorcall_Function doc versionadded (pythonGH-107140)

1d5e430

The documentation implies that PyVectorcall_Function() was available in Python 3.8.
This is half-true - it was available under a different name. I think it's clearer to set
the "version added" to 3.9.
(cherry picked from commit 0a9b339)

Co-authored-by: da-woods <[email protected]>

bedevere-bot commented Jul 24, 2023

Copy link

Copy Markdown

GH-107174 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Jul 24, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 24, 2023


          Fix PyVectorcall_Function doc versionadded (pythonGH-107140)

68e93e5

The documentation implies that PyVectorcall_Function() was available in Python 3.8.
This is half-true - it was available under a different name. I think it's clearer to set
the "version added" to 3.9.
(cherry picked from commit 0a9b339)

Co-authored-by: da-woods <[email protected]>

vstinner pushed a commit that referenced this pull request

Jul 24, 2023


          [3.12] Fix PyVectorcall_Function doc versionadded (GH-107140) (#107173)

4fd5764

Fix PyVectorcall_Function doc versionadded (GH-107140)

The documentation implies that PyVectorcall_Function() was available in Python 3.8.
This is half-true - it was available under a different name. I think it's clearer to set
the "version added" to 3.9.
(cherry picked from commit 0a9b339)

Co-authored-by: da-woods <[email protected]>

vstinner pushed a commit that referenced this pull request

Jul 24, 2023


          [3.11] Fix PyVectorcall_Function doc versionadded (GH-107140) (#107174)

579868e

Fix PyVectorcall_Function doc versionadded (GH-107140)

The documentation implies that PyVectorcall_Function() was available in Python 3.8.
This is half-true - it was available under a different name. I think it's clearer to set
the "version added" to 3.9.
(cherry picked from commit 0a9b339)

Co-authored-by: da-woods <[email protected]>

da-woods deleted the patch-1 branch

July 24, 2023 14:17

carljm added a commit to carljm/cpython that referenced this pull request

Jul 24, 2023


          Merge branch 'main' into superfix

9a6bdfa

* main: (73 commits)
  Thoroughly refactor the cases generator (python#107151)
  Docs: Add missing markup to Argument Clinic docs (python#106876)
  pythongh-107162: Document errcode.h usage in its comment (python#107177)
  pythongh-106320: Remove private _PyDict C API (python#107145)
  Fix PyVectorcall_Function doc versionadded (python#107140)
  Docs: Remove duplicate word in Argument Clinic howto heading (python#107169)
  pythongh-107017: Change Chapter Strings to Texts in the Introduction chapter. (python#107104)
  pythongh-106320: Remove private _PyObject C API (python#107159)
  Docs: fix typo in os.pwrite docstring (python#107087)
  pythongh-105291: Add link to migration guide for distutils (python#107130)
  pythongh-106948: Docs: Disable links for C standard library functions, OS utility functions and system calls (python#107062)
  pythongh-106320: Remove _PyBytes_Join() C API (python#107144)
  pythongh-106320: Remove private _PyObject C API (python#107147)
  pythongh-106320: Remove _PyTuple_MaybeUntrack() C API (python#107143)
  pythongh-106320: Remove _PyIsSelectable_fd() C API (python#107142)
  Remove superflous whitespaces in `layout.html`. (pythonGH-107067)
  pythongh-107122: Update what's news for dbm.*dbm.clear() method (pythongh-107135)
  pythongh-107122: Add clear method to dbm.ndbm module (pythongh-107126)
  pythongh-62519: Make pgettext search plurals when translation is not found (python#107118)
  pythongh-107122: Add clear method to dbm.gdbm.module (pythongh-107127)
  ...

Reviewers

vstinner

vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

da-woods commented Jul 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner Jul 23, 2023

Choose a reason for hiding this comment

Uh oh!

vstinner Jul 23, 2023

Choose a reason for hiding this comment

Uh oh!

da-woods commented Jul 24, 2023

Uh oh!

vstinner commented Jul 24, 2023

Uh oh!

miss-islington commented Jul 24, 2023

Uh oh!

miss-islington commented Jul 24, 2023

Uh oh!

bedevere-bot commented Jul 24, 2023

Uh oh!

bedevere-bot commented Jul 24, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

da-woods commented Jul 23, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.