GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107122: Add clear method to dbm.ndbm module by corona10 · Pull Request #107126 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Jul 23, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Provide clear method for dbm/gdbm module #107122

📚 Documentation preview 📚: https://cpython-previews--107126.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot mentioned this pull request Jul 23, 2023
Provide clear method for dbm/gdbm module #107122
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Jul 23, 2023
@corona10
corona10 requested review from erlend-aasland and vstinner July 23, 2023 12:25
@corona10

corona10 commented Jul 23, 2023

Copy link
Copy Markdown
Member Author

cc @eendebakpt

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10

corona10 commented Jul 23, 2023

Copy link
Copy Markdown
Member Author

Refleak check

(.oss) ➜  cpython git:(gh-107122) ✗ ./python.exe -m test test_dbm -R 3:3
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 2.26 Run tests sequentially
0:00:00 load avg: 2.26 [1/1] test_dbm
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 258 ms
Tests result: SUCCESS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner
vstinner reviewed Jul 23, 2023
View reviewed changes
Comment thread Modules/_dbmmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_dbm.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@corona10
corona10 force-pushed the gh-107122 branch from 9b7a5af to 9cfd667 Compare July 23, 2023 12:40
vstinner
vstinner approved these changes Jul 23, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please document the new feature in What's New In Python 3.13.

I would suggest "itemds", "key" and "value" names instead of a, k, v 😉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 23, 2023
corona10 added 7 commits July 23, 2023 22:51
@corona10
pythongh-107122: Add clear method to dbm.ndbm module
7a930a7
@corona10
Address code review
d0f930c
@corona10
Be more safer
7a7e826
@corona10
Address code review
3affdb7
@corona10
Update test_dbm_ndbm
2be5402
@corona10
Update docs
1d14440
@corona10
Simply invalidate cache
5eb2b13
@corona10
corona10 force-pushed the gh-107122 branch from f7b8698 to 5eb2b13 Compare July 23, 2023 13:51
@corona10
corona10 enabled auto-merge (squash) July 23, 2023 14:25
@corona10
corona10 merged commit 0ae4870 into python:main Jul 23, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 23, 2023
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 23, 2023
@corona10 @jtcave
pythongh-107122: Add clear method to dbm.ndbm module (pythongh-107126)
941cfa7
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
@corona10 @mementum
pythongh-107122: Add clear method to dbm.ndbm module (pythongh-107126)
98a3597
carljm added a commit to carljm/cpython that referenced this pull request Jul 24, 2023
@carljm
Merge branch 'main' into superfix
9a6bdfa
* main: (73 commits)
  Thoroughly refactor the cases generator (python#107151)
  Docs: Add missing markup to Argument Clinic docs (python#106876)
  pythongh-107162: Document errcode.h usage in its comment (python#107177)
  pythongh-106320: Remove private _PyDict C API (python#107145)
  Fix PyVectorcall_Function doc versionadded (python#107140)
  Docs: Remove duplicate word in Argument Clinic howto heading (python#107169)
  pythongh-107017: Change Chapter Strings to Texts in the Introduction chapter. (python#107104)
  pythongh-106320: Remove private _PyObject C API (python#107159)
  Docs: fix typo in os.pwrite docstring (python#107087)
  pythongh-105291: Add link to migration guide for distutils (python#107130)
  pythongh-106948: Docs: Disable links for C standard library functions, OS utility functions and system calls (python#107062)
  pythongh-106320: Remove _PyBytes_Join() C API (python#107144)
  pythongh-106320: Remove private _PyObject C API (python#107147)
  pythongh-106320: Remove _PyTuple_MaybeUntrack() C API (python#107143)
  pythongh-106320: Remove _PyIsSelectable_fd() C API (python#107142)
  Remove superflous whitespaces in `layout.html`. (pythonGH-107067)
  pythongh-107122: Update what's news for dbm.*dbm.clear() method (pythongh-107135)
  pythongh-107122: Add clear method to dbm.ndbm module (pythongh-107126)
  pythongh-62519: Make pgettext search plurals when translation is not found (python#107118)
  pythongh-107122: Add clear method to dbm.gdbm.module (pythongh-107127)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@corona10 @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.