GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) by miss-islington · Pull Request #107599 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 3, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The linked list of objects was a global variable, which broke isolation between interpreters, causing crashes. To solve this, we've moved the linked list to each interpreter.
(cherry picked from commit 58ef741)

Co-authored-by: Eric Snow [email protected]

  • Issue: test__xxsubinterpreters: test_already_running() crash randomly on Python built with TraceRefs: invalid object chain #107080

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently @miss-islington
pythongh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpre…
b55de7a 
…ters (pythongh-107567)

The linked list of objects was a global variable, which broke isolation between interpreters, causing crashes. To solve this, we've moved the linked list to each interpreter.
(cherry picked from commit 58ef741)

Co-authored-by: Eric Snow <[email protected]>
This was referenced Aug 3, 2023
test__xxsubinterpreters: test_already_running() crash randomly on Python built with TraceRefs: invalid object chain #107080
Closed
gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters #107567
Merged
@bedevere-bot bedevere-bot added the awaiting review label Aug 3, 2023
@ericsnowcurrently ericsnowcurrently assigned Yhg1s Aug 3, 2023
@Yhg1s
Yhg1s merged commit 58af229 into python:3.12 Aug 3, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Aug 3, 2023
@miss-islington
miss-islington deleted the backport-58ef741-3.12 branch August 3, 2023 22:18
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Aug 4, 2023
@ericsnowcurrently
Revert "[3.12] pythongh-107080: Fix Py_TRACE_REFS Crashes Under Isola…
b380392 
…ted Subinterpreters (pythongh-107567) (python#107599)"

This reverts commit 58af229.
@bedevere-bot

bedevere-bot commented Aug 5, 2023

Copy link
Copy Markdown

GH-107648 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s pushed a commit that referenced this pull request Aug 5, 2023
@ericsnowcurrently
[3.12] gh-107630: Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes…
6e4eec7 
… Under Isolated Subinterpreters (gh-107567) (#107599)" (#107648)

Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)"

This reverts commit 58af229.
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Aug 7, 2023
@ericsnowcurrently
Unrevert "[3.12] pythongh-107080: Fix Py_TRACE_REFS Crashes Under Iso…
6f8b84f 
…lated Subinterpreters (pythongh-107567) (python#107599)".

This reverts commit 6e4eec7 (pythongh-107648).
This was referenced Aug 7, 2023
[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters #107737
Closed
[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters #107751
Merged
Yhg1s pushed a commit that referenced this pull request Aug 16, 2023
@ericsnowcurrently
[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpr…
aa9707d 
…eters (#107751)

* Unrevert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)".

This reverts commit 6e4eec7 (gh-107648).

* Initialize each interpreter's refchain properly.

* Skip test_basic_multiple_interpreters_deleted_no_reset on tracerefs builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @bedevere-bot @Yhg1s @ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.