GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-107630: Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)" by ericsnowcurrently · Pull Request #107648 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Aug 4, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 58af229.

  • Issue: TraceRefs build triggers assertion errors #107630

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Revert "[3.12] pythongh-107080: Fix Py_TRACE_REFS Crashes Under Isola…
b380392 
…ted Subinterpreters (pythongh-107567) (python#107599)"

This reverts commit 58af229.
@ericsnowcurrently ericsnowcurrently added the skip news label Aug 4, 2023
@ericsnowcurrently ericsnowcurrently assigned Yhg1s Aug 4, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 4, 2023
test__xxsubinterpreters: test_already_running() crash randomly on Python built with TraceRefs: invalid object chain #107080
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 4, 2023
@ericsnowcurrently ericsnowcurrently changed the title Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)" gh-107630: Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)" Aug 4, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 4, 2023
TraceRefs build triggers assertion errors #107630
Closed
@ericsnowcurrently

ericsnowcurrently commented Aug 4, 2023

Copy link
Copy Markdown
Member Author

@Yhg1s, I didn't see a PR from you already, so I figured I'd make one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s Yhg1s changed the title gh-107630: Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)" [3.12] gh-107630: Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)" Aug 5, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 5, 2023
[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) #107599
Merged
@Yhg1s
Yhg1s merged commit 6e4eec7 into python:3.12 Aug 5, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 5, 2023
@ericsnowcurrently
ericsnowcurrently deleted the revert-tracerefs-fix branch August 7, 2023 14:56
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Aug 7, 2023
@ericsnowcurrently
Unrevert "[3.12] pythongh-107080: Fix Py_TRACE_REFS Crashes Under Iso…
6f8b84f 
…lated Subinterpreters (pythongh-107567) (python#107599)".

This reverts commit 6e4eec7 (pythongh-107648).
This was referenced Aug 7, 2023
[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters #107737
Closed
[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters #107751
Merged
Yhg1s pushed a commit that referenced this pull request Aug 16, 2023
@ericsnowcurrently
[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpr…
aa9707d 
…eters (#107751)

* Unrevert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)".

This reverts commit 6e4eec7 (gh-107648).

* Initialize each interpreter's refchain properly.

* Skip test_basic_multiple_interpreters_deleted_no_reset on tracerefs builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @Yhg1s @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.