GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119146: Update `paths` in `jit.yml` by savannahostrowski · Pull Request #119147 · python/cpython

Conversation

@savannahostrowski

@savannahostrowski savannahostrowski commented May 18, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Update paths in jit.yml #119146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
savannahostrowski added 3 commits May 16, 2024 11:41
@savannahostrowski
add paths-ignore to jit.yml
ab40064
@savannahostrowski
update paths/
8a104a7
@savannahostrowski
undo test
5882b99
@savannahostrowski
savannahostrowski requested a review from brandtbucher as a code owner May 18, 2024 14:49
@bedevere-app bedevere-app Bot added the awaiting review label May 18, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 18, 2024
Update paths in jit.yml #119146
Closed
@erlend-aasland
erlend-aasland requested a review from hugovk May 18, 2024 15:00
@brandtbucher brandtbucher added tests Tests in the Lib/test dir skip news labels May 18, 2024
@brandtbucher brandtbucher self-assigned this May 18, 2024
FFY00
FFY00 approved these changes May 18, 2024
View reviewed changes

@FFY00 FFY00 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually be able to ignore Python/perf_jit_trampoline.c by using a negative matching pattern: !Python/perf_jit_trampoline.c.

Other than that, looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 18, 2024
@savannahostrowski

savannahostrowski commented May 18, 2024

Copy link
Copy Markdown
Member Author

Oh! I totally didn't know about that. I'll take a look at adding that when I also add .h files to the paths (since I missed adding those in too).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski
use negative pattern match
1312112
AlexWaygood
AlexWaygood reviewed May 18, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Maybe we could just ignore all .md and .ini files? Then if we added others in the future, we wouldn't have to remember to update this file?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread .github/workflows/jit.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/jit.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski and others added 2 commits May 18, 2024 15:29
@savannahostrowski @AlexWaygood
Update jit.yml
bf52b3c 
Co-authored-by: Alex Waygood <[email protected]>
@savannahostrowski @AlexWaygood
Update jit.yml
168bfd0 
Co-authored-by: Alex Waygood <[email protected]>
@savannahostrowski

savannahostrowski commented May 18, 2024

Copy link
Copy Markdown
Member Author

Yeah, that's a fair callout!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood approved these changes May 18, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher
brandtbucher reviewed May 19, 2024
View reviewed changes
Comment thread .github/workflows/jit.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood @brandtbucher
Update .github/workflows/jit.yml
ce42693 
Co-authored-by: Brandt Bucher <[email protected]>
@brandtbucher
brandtbucher enabled auto-merge (squash) May 19, 2024 12:36
@brandtbucher
brandtbucher merged commit 5307f44 into python:main May 19, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 19, 2024
@hugovk

hugovk commented May 20, 2024

Copy link
Copy Markdown
Member

Thanks for the PR!

Shall we backport it, or close the issue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 20, 2024

Copy link
Copy Markdown
Contributor

I think it's ok to backport it to 3.13.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher brandtbucher added the needs backport to 3.13 only security fixes label May 20, 2024
@miss-islington-app

miss-islington-app Bot commented May 20, 2024

Copy link
Copy Markdown

Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
@savannahostrowski @AlexWaygood @miss-islington
pythonGH-119146: Don't run JIT CI on unrelated changes (pythonGH-119147)
80ff420 
(cherry picked from commit 5307f44)

Co-authored-by: Savannah Ostrowski <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@bedevere-app

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

GH-119226 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 20, 2024
@brandtbucher brandtbucher added the topic-JIT label May 31, 2024
This was referenced Jun 12, 2024
gh-120433: Mention chocolatey for installing llvm on Windows as an alternative option #120434
Merged
gh-119146: Update regexp in build.yml to not trigger the jobs on *.md and *.ini files. #120435
Merged
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@savannahostrowski @AlexWaygood @estyxx
pythonGH-119146: Don't run JIT CI on unrelated changes (pythonGH-119147)
be0335d 
Co-authored-by: Alex Waygood <[email protected]>
@savannahostrowski
savannahostrowski deleted the jit-ignore-filews branch September 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher left review comments
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@FFY00 FFY00 FFY00 approved these changes
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

skip news tests Tests in the Lib/test dir topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@savannahostrowski @hugovk @erlend-aasland @FFY00 @brandtbucher @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.