GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-120433: Mention ``chocolatey`` for installing llvm on Windows as an alternative option by Eclips4 · Pull Request #120434 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented Jun 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Mention chocolatey in Tools/jit/README.md #120433

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Eclips4
add note about choco
f9d3e1f
@Eclips4 Eclips4 added the needs backport to 3.13 only security fixes label Jun 12, 2024
@Eclips4
Eclips4 requested a review from brandtbucher as a code owner June 12, 2024 19:51
@bedevere-app bedevere-app Bot mentioned this pull request Jun 12, 2024
Mention chocolatey in Tools/jit/README.md #120433
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jun 12, 2024
@Eclips4 Eclips4 added the skip news label Jun 12, 2024
@Eclips4

Eclips4 commented Jun 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

cc @savannahostrowski
I guess there's something gone wrong with our CI. Previously we decided to ignore changes in *.md files to avoid wasting CI time, but actually, it's running!

savannahostrowski reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner
vstinner approved these changes Jun 12, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 12, 2024
@hugovk

hugovk commented Jun 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I guess there's something gone wrong with our CI. Previously we decided to ignore changes in *.md files to avoid wasting CI time, but actually, it's running!

This is the run: https://github.com/python/cpython/actions/runs/9489036340

I don't know why, but it's because the workflow file used for the run doesn't contain the '!**/*.md' exceptions: https://github.com/python/cpython/actions/runs/9489036340/workflow

Which were added in #119147 and are still in main: https://github.com/python/cpython/blob/main/.github/workflows/jit.yml

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Eclips4

Eclips4 commented Jun 12, 2024

Copy link
Copy Markdown
Member Author

I guess there's something gone wrong with our CI. Previously we decided to ignore changes in *.md files to avoid wasting CI time, but actually, it's running!

This is the run: https://github.com/python/cpython/actions/runs/9489036340

I don't know why, but it's because the workflow file used for the run doesn't contain the '!**/*.md' exceptions: https://github.com/python/cpython/actions/runs/9489036340/workflow

Which were added in #119147 and are still in main: https://github.com/python/cpython/blob/main/.github/workflows/jit.yml

I've created #120435 to try to fix that.
Actually, what do you mean when you say "but it's because the workflow file used for the run doesn't contain the '!**/*.md' exceptions:"? I'm seeing that:

name: JIT
on:
  pull_request:
    paths:
      - '!**/*.md'
      - '!**/*.ini'
      - '**jit**'
      - 'Python/bytecodes.c'
      - 'Python/optimizer*.c'
      - '!Python/perf_jit_trampoline.c'
  push:
    paths:
      - '!**/*.md'
      - '!**/*.ini'
      - '**jit**'
      - 'Python/bytecodes.c'
      - 'Python/optimizer*.c'
      - '!Python/perf_jit_trampoline.c'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Jun 12, 2024

Copy link
Copy Markdown
Member

So it does... I missed them because the PR added them to the end of the lists, not the top: 🤔

       - '**jit**'
       - 'Python/bytecodes.c'
       - 'Python/optimizer*.c'
+      - '!Python/perf_jit_trampoline.c'
+      - '!**/*.md'
+      - '!**/*.ini'
   push:
     paths:
       - '**jit**'
       - 'Python/bytecodes.c'
       - 'Python/optimizer*.c'
+      - '!Python/perf_jit_trampoline.c'
+      - '!**/*.md'
+      - '!**/*.ini'

I wonder why they're different.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

savannahostrowski
savannahostrowski approved these changes Jun 13, 2024
View reviewed changes
sobolevn
sobolevn reviewed Jun 13, 2024
View reviewed changes
Comment thread Tools/jit/README.md Outdated
Alternatively, you can use [chocolatey](https://chocolatey.org):

```sh
choco install llvm --version=18.1.0

@sobolevn sobolevn Jun 13, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to specify just --version=18, without minor and patch releases? Other tools do not specify exact version.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@Eclips4 Eclips4 Jun 13, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to specify just --version=18, without minor and patch releases? Other tools do not specify exact version.

Unfortunately, no.
We can also omit --version and the latest stable release will be installed. What do you think about that?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@vstinner vstinner Jun 13, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to stick to a version.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn and savannahostrowski reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

@Eclips4 Eclips4 Jun 15, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, here's the list of available versions:

llvm 18.1.6 [Approved] Downloads cached for licensed users
llvm 18.1.5 [Approved] Downloads cached for licensed users
llvm 18.1.4 [Approved] Downloads cached for licensed users
llvm 18.1.3 [Approved]
llvm 18.1.2 [Approved]
llvm 18.1.0 [Approved] Downloads cached for licensed users

Which one do you prefer? The latest one?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@vstinner vstinner Jun 15, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest, yes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@Eclips4 Eclips4 Jun 17, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Eclips4
Update version to the latest one
44cfd16
vstinner
vstinner approved these changes Jun 17, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
sobolevn
sobolevn approved these changes Jun 17, 2024
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would have to update it from time to time, but there's no other way, I guess ;)

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Eclips4 reacted with heart emoji Eclips4 and savannahostrowski reacted with rocket emoji
All reactions
  • ❤️ 1 reaction
  • 🚀 2 reactions
@sobolevn
sobolevn enabled auto-merge (squash) June 17, 2024 15:51
@sobolevn
sobolevn merged commit 95737bb into python:main Jun 17, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 17, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 17, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 17, 2024
@Eclips4 @miss-islington
pythongh-120433: Mention chocolatey for installing llvm on Window…
754f99b
…s as an alternative option (pythonGH-120434)

(cherry picked from commit 95737bb)

Co-authored-by: Kirill Podoprigora <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 17, 2024

Copy link
Copy Markdown

GH-120651 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 17, 2024
@Eclips4
Eclips4 deleted the issue-120433 branch June 17, 2024 15:59
sobolevn pushed a commit that referenced this pull request Jun 17, 2024
@miss-islington @Eclips4
[3.13] gh-120433: Mention chocolatey for installing llvm on Windo…
f7ba323
…ws as an alternative option (GH-120434) (#120651)

gh-120433: Mention ``chocolatey`` for installing llvm on Windows as an alternative option (GH-120434)
(cherry picked from commit 95737bb)

Co-authored-by: Kirill Podoprigora <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@Eclips4 @mrahtz
pythongh-120433: Mention chocolatey for installing llvm on Window…
c5c4730
…s as an alternative option (python#120434)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Eclips4 @estyxx
pythongh-120433: Mention chocolatey for installing llvm on Window…
3887737
…s as an alternative option (python#120434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@sobolevn sobolevn sobolevn approved these changes
@savannahostrowski savannahostrowski savannahostrowski approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Eclips4 @hugovk @vstinner @sobolevn @savannahostrowski
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.