GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119146: Update ``regexp`` in `build.yml` to not trigger the jobs on `*.md` and `*.ini` files. by Eclips4 · Pull Request #120435 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented Jun 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Update paths in jit.yml #119146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Eclips4
first try to fix that
f45af4b
@Eclips4
Eclips4 requested a review from brandtbucher as a code owner June 12, 2024 20:08
@bedevere-app bedevere-app Bot mentioned this pull request Jun 12, 2024
Update paths in jit.yml #119146
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jun 12, 2024
@Eclips4
Eclips4 marked this pull request as draft June 12, 2024 20:09
@bedevere-app bedevere-app Bot removed the awaiting review label Jun 12, 2024
Eclips4 added 3 commits June 12, 2024 20:14
@Eclips4
second try to fix that
54cba29
@Eclips4
third try to fix that
dd4445e
@Eclips4
is the first option resolves that?
d0ea26e
@Eclips4 Eclips4 mentioned this pull request Jun 12, 2024
gh-120433: Mention chocolatey for installing llvm on Windows as an alternative option #120434
Merged
@Eclips4
Remove all of my changes
7189466
@Eclips4

Eclips4 commented Jun 12, 2024

Copy link
Copy Markdown
Member Author

@hugovk
So, these wildcard patterns actually work and the jit workflow is skipped, but other workflows don't take these exceptions into account.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4 added 7 commits June 12, 2024 20:39
@Eclips4
fourth try to fix that
943de2b
@Eclips4
Is this really working?
a9dec9b
@Eclips4
Revert my changes to make sure
d5936ad
@Eclips4
Change the regex
a4ff900
@Eclips4
oh..
b978473
@Eclips4
another try
ecd9cd7
@Eclips4
let's try this
4229dbe
@Eclips4 Eclips4 added the skip news label Jun 12, 2024
Eclips4 added 10 commits June 12, 2024 21:09
@Eclips4
this should work
c7d9294
@Eclips4
and this
a9f3ecc
@Eclips4
I guess this is the final commit
cfb1f8a
@Eclips4
i hate this regex
52134ee
@Eclips4
please
4c8508a
@Eclips4
...
7317379
@Eclips4
Seems I finally found the solution
46a20f9
@Eclips4
try to trigger workflo
06b8b72
@Eclips4
Yes, it's works!
b578b69
@Eclips4
Last commit.
d477365
@bedevere-app bedevere-app Bot added the awaiting review label Jun 12, 2024
@Eclips4
Eclips4 requested a review from savannahostrowski June 12, 2024 21:46
@Eclips4 Eclips4 changed the title gh-119146: Move wildcard patterns to top gh-119146: Update regexp in build.yml to not trigger the jobs on *.md and *.ini files. Jun 12, 2024
@Eclips4 Eclips4 added the needs backport to 3.13 only security fixes label Jun 12, 2024
savannahostrowski
savannahostrowski approved these changes Jun 13, 2024
View reviewed changes

@savannahostrowski savannahostrowski left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit messages are so relatable 😅 . Testing GHA workflows is always such a pain. This LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with laugh emoji Eclips4 and hugovk reacted with heart emoji
All reactions
  • 😄 1 reaction
  • ❤️ 2 reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Jun 13, 2024
hugovk
hugovk reviewed Jun 13, 2024
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4 @hugovk
Update .github/workflows/build.yml
8a799d7 
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
hugovk approved these changes Jun 13, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Shall we also backport to 3.12?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 13, 2024
@hugovk
hugovk merged commit ca5108a into python:main Jun 13, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 13, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2024
@Eclips4 @hugovk @miss-islington
pythongh-119146: Update regexp in build.yml to not trigger the …
e5c5ce6 
…jobs on `*.md` and `*.ini` files. (pythonGH-120435)

(cherry picked from commit ca5108a)

Co-authored-by: Kirill Podoprigora <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 13, 2024

Copy link
Copy Markdown

GH-120447 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 13, 2024
hugovk added a commit that referenced this pull request Jun 13, 2024
@miss-islington @Eclips4 @hugovk
[3.13] gh-119146: Update regexp in build.yml to not trigger the…
5ce72e2 
… jobs on `*.md` and `*.ini` files. (GH-120435) (#120447)

Co-authored-by: Kirill Podoprigora <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@Eclips4

Eclips4 commented Jun 13, 2024

Copy link
Copy Markdown
Member Author

Thanks! Shall we also backport to 3.12?

I think yes. #119147 wasn't backported to 3.12 because it was related to JIT workflow which appeared only in 3.13.
This PR does a more generally thing, so I think it would be ok to backport it to 3.12.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4 Eclips4 added the needs backport to 3.12 only security fixes label Jun 13, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 13, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2024
@Eclips4 @hugovk @miss-islington
pythongh-119146: Update regexp in build.yml to not trigger the …
a71011a 
…jobs on `*.md` and `*.ini` files. (pythonGH-120435)

(cherry picked from commit ca5108a)

Co-authored-by: Kirill Podoprigora <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 13, 2024

Copy link
Copy Markdown

GH-120448 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jun 13, 2024
hugovk added a commit that referenced this pull request Jun 13, 2024
@miss-islington @Eclips4 @hugovk
[3.12] gh-119146: Update regexp in build.yml to not trigger the…
f8dd4c3 
… jobs on `*.md` and `*.ini` files. (GH-120435) (#120448)

Co-authored-by: Kirill Podoprigora <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@Eclips4
Eclips4 deleted the issue-119146 branch June 13, 2024 12:39
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@Eclips4 @hugovk @mrahtz
pythongh-119146: Update regexp in build.yml to not trigger the …
6ecd9b3 
…jobs on `*.md` and `*.ini` files. (python#120435)

Co-authored-by: Hugo van Kemenade <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Eclips4 @hugovk @estyxx
pythongh-119146: Update regexp in build.yml to not trigger the …
ce3b16a 
…jobs on `*.md` and `*.ini` files. (python#120435)

Co-authored-by: Hugo van Kemenade <[email protected]>
@AA-Turner AA-Turner mentioned this pull request Feb 3, 2025
Convert change detection to a Python script #129627
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@savannahostrowski savannahostrowski savannahostrowski approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Eclips4 @hugovk @savannahostrowski
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.