GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119461: Fix ThreadedVSOCKSocketStreamTest by vstinner · Pull Request #119465 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 23, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add socket.VMADDR_CID_LOCAL constant.

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host address or the "any" address, use the local communication address (loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but get_cid() returns VMADDR_CID_ANY (-1).

  • Issue: test_socket: testStream() fails on Fedora Rawhide #119461

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added the awaiting core review label May 23, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 23, 2024
test_socket: testStream() fails on Fedora Rawhide #119461
Closed
@vstinner
pythongh-119461: Fix ThreadedVSOCKSocketStreamTest
d81cb0b
Add socket.VMADDR_CID_LOCAL constant.

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).
@vstinner
vstinner force-pushed the vsock_local branch from 967e843 to d81cb0b Compare May 23, 2024 13:49
@vstinner vstinner mentioned this pull request May 23, 2024
gh-119461: Skip ThreadedVSOCKSocketStreamTest if cid is VMADDR_CID_ANY #119463
Closed
@vstinner vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 23, 2024
@bedevere-bot

bedevere-bot commented May 23, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit d81cb0b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 23, 2024
@vstinner

vstinner commented May 23, 2024

Copy link
Copy Markdown
Member Author

buildbot/AMD64 Arch Linux TraceRefs PR: test failure looks unrelated:

test_basic_multiple_interpreters_reset_each (test.test_import.SinglephaseInitTests.test_basic_multiple_interpreters_reset_each) ... python: Objects/object.c:195: _PyRefchain_Remove: Assertion `value == REFCHAIN_VALUE' failed.
Fatal Python error: Aborted

Current thread 0x00007f3c8619e740 (most recent call first):
  File "<string>", line 54 in <module>

Extension modules: _testinternalcapi, _testmultiphase, _testcapi (total: 3)

buildbot/AMD64 Arch Linux Usan PR: build failure is unrelated.

Objects/object.c:1019:16: runtime error: call to function long_hash through pointer to incorrect function type 'long (*)(struct _object *)'

buildbot/ARM64 Windows Non-Debug PR: test_cext failure is unrelated.

  extension.c(50): warning C4116: unnamed type definition in parentheses
  extension.c(50): error C2059: syntax error: 'static_assert'
  extension.c(50): error C2059: syntax error: ')'
  extension.c(50): error C2059: syntax error: ','
  extension.c(52): error C2059: syntax error: 'return'
  extension.c(53): error C2059: syntax error: '}'
  extension.c(69): error C2065: '_testcext_slots': undeclared identifier
  extension.c(63): warning C4047: 'initializing': 'PyModuleDef_Slot *' differs in levels of indirection from 'int'
  error: command 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Tools\\MSVC\\14.31.31103\\bin\\HostX86\\ARM64\\cl.exe' failed with exit code 2
  [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for internal-test-c11-cext
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit e94dbe4 into python:main May 23, 2024
@vstinner
vstinner deleted the vsock_local branch May 23, 2024 21:26
@bedevere-app bedevere-app Bot removed the awaiting core review label May 23, 2024
vstinner added a commit to vstinner/cpython that referenced this pull request May 23, 2024
@vstinner
pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (python#119465)
8241456
Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit e94dbe4)
@bedevere-app

bedevere-app Bot commented May 23, 2024

Copy link
Copy Markdown

GH-119479 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added a commit that referenced this pull request May 23, 2024
@vstinner
[3.13] gh-119461: Fix ThreadedVSOCKSocketStreamTest (#119465) (#119479)
c750061
gh-119461: Fix ThreadedVSOCKSocketStreamTest (#119465)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit e94dbe4)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2024
@vstinner @miss-islington
[3.13] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-1…
4bca8a5
…19465) (pythonGH-119479)

pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)
@miss-islington miss-islington mentioned this pull request May 23, 2024
[3.12] [3.13] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-119465) (GH-119479) #119484
Merged
vstinner added a commit that referenced this pull request May 23, 2024
@miss-islington @vstinner
[3.12] [3.13] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-119465) (
122dd4f
GH-119479) (#119484)

[3.13] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-119465) (GH-119479)

gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-119465)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (python#119465)
6f31337
Add socket.VMADDR_CID_LOCAL constant.

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).
hrnciar pushed a commit to fedora-python/cpython that referenced this pull request Sep 11, 2024
@miss-islington @vstinner @hrnciar
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
79fecc6
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <[email protected]>
hrnciar pushed a commit to fedora-python/cpython that referenced this pull request Sep 11, 2024
@miss-islington @vstinner @hrnciar
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
e5fb458
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <[email protected]>
hrnciar pushed a commit to fedora-python/cpython that referenced this pull request Sep 11, 2024
@miss-islington @vstinner @hrnciar
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
cc2b987
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <[email protected]>
hroncok pushed a commit to fedora-python/cpython that referenced this pull request Sep 11, 2024
@miss-islington @vstinner @hroncok
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
a3345bd
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <[email protected]>
frenzymadness pushed a commit to fedora-python/cpython that referenced this pull request Dec 3, 2024
@miss-islington @vstinner @frenzymadness
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
711d800
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <[email protected]>
frenzymadness pushed a commit to fedora-python/cpython that referenced this pull request Dec 3, 2024
@miss-islington @vstinner @frenzymadness
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
c90b131
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <[email protected]>
frenzymadness pushed a commit to fedora-python/cpython that referenced this pull request Dec 3, 2024
@miss-islington @vstinner @frenzymadness
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
fb0aa8b
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <[email protected]>
@vstinner vstinner mentioned this pull request Jan 22, 2025
[3.11] gh-119461: Fix ThreadedVSOCKSocketStreamTest #129171
Merged
vstinner added a commit to vstinner/cpython that referenced this pull request Jan 22, 2025
@vstinner
[3.13] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (python#119465
6a286e6
) (python#119479)

pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (python#119465)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
gpshead added a commit to gpshead/cpython that referenced this pull request Feb 2, 2025
@gpshead
Restore the skipUnless removed by python#119465.
5911e8c
This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on Debian running 6.8.0-52-generic.
gpshead added a commit that referenced this pull request Feb 2, 2025
@gpshead
gh-119461: Restore the testSocket VSOCK skipUnless removed by PR #119465
e1006ce
 (#129561)

Restore the skipUnless removed by #119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 2, 2025
@gpshead @miss-islington
pythongh-119461: Restore the testSocket VSOCK skipUnless removed by PR …
812a401
…pythonGH-119465 (pythonGH-129561)

Restore the skipUnless removed by pythonGH-119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.
(cherry picked from commit e1006ce)

Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington miss-islington mentioned this pull request Feb 2, 2025
[3.13] gh-119461: Restore the testSocket VSOCK skipUnless removed by PR GH-119465 (GH-129561) #129564
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 2, 2025
@gpshead @miss-islington
pythongh-119461: Restore the testSocket VSOCK skipUnless removed by PR …
22b065d
…pythonGH-119465 (pythonGH-129561)

Restore the skipUnless removed by pythonGH-119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.
(cherry picked from commit e1006ce)

Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington miss-islington mentioned this pull request Feb 2, 2025
[3.12] gh-119461: Restore the testSocket VSOCK skipUnless removed by PR GH-119465 (GH-129561) #129565
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 2, 2025
@gpshead @miss-islington
pythongh-119461: Restore the testSocket VSOCK skipUnless removed by PR …
f326edc
…pythonGH-119465 (pythonGH-129561)

Restore the skipUnless removed by pythonGH-119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.
(cherry picked from commit e1006ce)

Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington miss-islington mentioned this pull request Feb 2, 2025
[3.11] gh-119461: Restore the testSocket VSOCK skipUnless removed by PR GH-119465 (GH-129561) #129566
Merged
gpshead added a commit that referenced this pull request Feb 2, 2025
@miss-islington @gpshead
[3.12] gh-119461: Restore the testSocket VSOCK skipUnless removed by PR
368ba55
GH-119465 (GH-129561) (#129565)

gh-119461: Restore the testSocket VSOCK skipUnless removed by PR GH-119465 (GH-129561)

Restore the skipUnless removed by GH-119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.
(cherry picked from commit e1006ce)

Co-authored-by: Gregory P. Smith <[email protected]>
gpshead added a commit that referenced this pull request Feb 2, 2025
@miss-islington @gpshead
[3.13] gh-119461: Restore the testSocket VSOCK skipUnless removed by PR
1459d08
GH-119465 (GH-129561) (#129564)

gh-119461: Restore the testSocket VSOCK skipUnless removed by PR GH-119465 (GH-129561)

Restore the skipUnless removed by GH-119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.
(cherry picked from commit e1006ce)

Co-authored-by: Gregory P. Smith <[email protected]>
encukou pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2025
@gpshead @encukou
pythongh-119461: Restore the testSocket VSOCK skipUnless removed by PR …
8532e37
…python#119465 (python#129561)

Restore the skipUnless removed by python#119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@gpshead @srinivasreddy
pythongh-119461: Restore the testSocket VSOCK skipUnless removed by PR …
e4dcd60
…python#119465 (python#129561)

Restore the skipUnless removed by python#119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.
pablogsal pushed a commit that referenced this pull request Feb 13, 2025
@miss-islington @vstinner @gpshead
[3.10] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171) (#129440
2bd9f9b
)

* [3.11] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit 45db419)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
(cherry picked from commit cbfe302)

* gh-119461: Restore the testSocket VSOCK skipUnless removed by PR #119465 (#129561)

Restore the skipUnless removed by #119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.

---------

Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
pablogsal pushed a commit that referenced this pull request Feb 13, 2025
@miss-islington @gpshead
[3.11] gh-119461: Restore the testSocket VSOCK skipUnless removed by PR
552ec42
GH-119465 (GH-129561) (#129566)

gh-119461: Restore the testSocket VSOCK skipUnless removed by PR GH-119465 (GH-129561)

Restore the skipUnless removed by GH-119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.
(cherry picked from commit e1006ce)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 13, 2025
@miss-islington @vstinner @gpshead
[3.10] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-1…
4ac4704
…29171) (pythonGH-129440)

* [3.11] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-129171)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit 45db419)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
(cherry picked from commit cbfe302)

* pythongh-119461: Restore the testSocket VSOCK skipUnless removed by PR pythonGH-119465 (pythonGH-129561)

Restore the skipUnless removed by pythonGH-119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.

---------

(cherry picked from commit 2bd9f9b)

Co-authored-by: Miss Islington (bot) <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington miss-islington mentioned this pull request Feb 13, 2025
[3.9] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171) (GH-129440) #130075
Merged
ambv pushed a commit that referenced this pull request Feb 19, 2025
@miss-islington @vstinner
@gpshead @encukou
[3.9] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171) (GH-12…
d80cbdd
…9440) (#130075)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit 45db419)
(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
(cherry picked from commit cbfe302)

---

Restore the skipUnless removed by GH-119465.

This test can only pass on virtual machines, not actual machines.
Actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.

(cherry picked from commit 2bd9f9b)

Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.