GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-119461: Fix ThreadedVSOCKSocketStreamTest by vstinner · Pull Request #129171 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 22, 2025

Copy link
Copy Markdown
Member
  • [PPC64LE buildbots] test_socket: VSOCK testStream(): recv fails with EACCES on Fedora 41 #128116: Skip test_socket VSOCK testStream() on PermissionError (gh-128116: Skip test_socket VSOCK testStream() on PermissionError #128120)
  • test_socket: testStream() fails on Fedora Rawhide #119461: Fix ThreadedVSOCKSocketStreamTest (gh-119461: Fix ThreadedVSOCKSocketStreamTest #119465) ([3.13] gh-119461: Fix ThreadedVSOCKSocketStreamTest (#119465) #119479)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host address or the "any" address, use the local communication address (loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but get_cid() returns VMADDR_CID_ANY (-1).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 22, 2025
test_socket: testStream() fails on Fedora Rawhide #119461
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jan 22, 2025
@vstinner vstinner mentioned this pull request Jan 22, 2025
gh-128874: Fix the documentation for blurb 2.0 #128875
Merged
@vstinner

vstinner commented Jan 22, 2025

Copy link
Copy Markdown
Member Author

This change should fix two 3.11 buildbots:

  • aarch64 Fedora Stable Refleaks 3.11
  • AMD64 Fedora Stable Refleaks 3.11

See recent failures: #128875 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the skip news label Jan 22, 2025
@vstinner

vstinner commented Jan 22, 2025

Copy link
Copy Markdown
Member Author

Tests / macOS / build and test (macos-13) (pull_request) Failing after 26s

Oh, the 3.11 branch lacks the brew link fix: I created #129172 for that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jan 22, 2025
[3.11] gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version (GH-128090) #129172
Merged
vstinner added 2 commits January 22, 2025 14:05
@vstinner
[3.13] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (python#119465
6a286e6 
) (python#119479)

pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (python#119465)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
@vstinner
pythongh-128116: Skip test_socket VSOCK testStream() on PermissionErr…
bc8b07d 
…or (python#128120)

(cherry picked from commit cbfe302)
@vstinner
vstinner force-pushed the test_socket_vsock branch from aa848b5 to bc8b07d Compare January 22, 2025 13:05
@vstinner

vstinner commented Jan 22, 2025

Copy link
Copy Markdown
Member Author

Oh, the 3.11 branch lacks the brew link fix: I created #129172 for that.

PR rebased on top of this fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jan 22, 2025

Copy link
Copy Markdown
Member Author

@hugovk @pablogsal @ambv: Would you mind to review this change? Yet another fix to the 3.11 stable branch, this time it's a backport for test_socket. It should fix two 3.11 buildbots:

  • aarch64 Fedora Stable Refleaks 3.11
  • AMD64 Fedora Stable Refleaks 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 45db419 into python:3.11 Jan 23, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 23, 2025
@encukou encukou added the needs backport to 3.10 label Jan 29, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 29, 2025

Copy link
Copy Markdown

Thanks @vstinner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 29, 2025
@vstinner @miss-islington
[3.11] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-1…
2491831 
…29171)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit 45db419)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
(cherry picked from commit cbfe302)
@bedevere-app

bedevere-app Bot commented Jan 29, 2025

Copy link
Copy Markdown

GH-129440 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.10 label Jan 29, 2025
@vstinner
vstinner deleted the test_socket_vsock branch February 2, 2025 09:08
pablogsal pushed a commit that referenced this pull request Feb 13, 2025
@miss-islington @vstinner @gpshead
[3.10] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171) (#129440
2bd9f9b 
)

* [3.11] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit 45db419)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
(cherry picked from commit cbfe302)

* gh-119461: Restore the testSocket VSOCK skipUnless removed by PR #119465 (#129561)

Restore the skipUnless removed by #119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.

---------

Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 13, 2025
@miss-islington @vstinner @gpshead
[3.10] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-1…
4ac4704 
…29171) (pythonGH-129440)

* [3.11] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-129171)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit 45db419)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
(cherry picked from commit cbfe302)

* pythongh-119461: Restore the testSocket VSOCK skipUnless removed by PR pythonGH-119465 (pythonGH-129561)

Restore the skipUnless removed by pythonGH-119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.

---------

(cherry picked from commit 2bd9f9b)

Co-authored-by: Miss Islington (bot) <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington miss-islington mentioned this pull request Feb 13, 2025
[3.9] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171) (GH-129440) #130075
Merged
ambv pushed a commit that referenced this pull request Feb 19, 2025
@miss-islington @vstinner
@gpshead @encukou
[3.9] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171) (GH-12…
d80cbdd 
…9440) (#130075)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit 45db419)
(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
(cherry picked from commit cbfe302)

---

Restore the skipUnless removed by GH-119465.

This test can only pass on virtual machines, not actual machines.
Actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.

(cherry picked from commit 2bd9f9b)

Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @ambv @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.