GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171) by miss-islington · Pull Request #129440 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 29, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit 45db419)

Co-authored-by: Victor Stinner [email protected]
(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
(cherry picked from commit cbfe302)

  • Issue: test_socket: testStream() fails on Fedora Rawhide #119461

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
[3.11] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-1…
2491831 
…29171)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit 45db419)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
(cherry picked from commit cbfe302)
@bedevere-app bedevere-app Bot added the skip news label Jan 29, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 29, 2025
[3.11] gh-119461: Fix ThreadedVSOCKSocketStreamTest #129171
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jan 29, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 29, 2025
test_socket: testStream() fails on Fedora Rawhide #119461
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jan 29, 2025
@encukou

encukou commented Jan 30, 2025

Copy link
Copy Markdown
Member

!buildbot PPC64LE.Fedora.Stable.Refleaks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 30, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 2491831 🤖

The command will test the builders whose names match following regular expression: PPC64LE.Fedora.Stable.Refleaks

The builders matched are:

  • PPC64LE Fedora Stable Refleaks PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou mentioned this pull request Jan 31, 2025
3.9 & 3.10: Read The Docs complains about missing config key #129509
Closed
@encukou

encukou commented Jan 31, 2025

Copy link
Copy Markdown
Member

See #129509 for the RtD preview failure.

This PR does not touch docs so it should be good to merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou requested a review from pablogsal January 31, 2025 12:00
@gpshead

gpshead commented Feb 2, 2025

Copy link
Copy Markdown
Member

If this is merged I recommend also backporting #129561
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Feb 3, 2025

Copy link
Copy Markdown
Member

Let's add it here & test them together.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou marked this pull request as draft February 3, 2025 14:00
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 3, 2025
@gpshead @encukou
pythongh-119461: Restore the testSocket VSOCK skipUnless removed by PR …
8532e37 
…python#119465 (python#129561)

Restore the skipUnless removed by python#119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.
@encukou
encukou marked this pull request as ready for review February 3, 2025 14:06
@bedevere-app bedevere-app Bot added the awaiting review label Feb 3, 2025
@encukou encukou mentioned this pull request Feb 3, 2025
gh-119461: Restore the testSocket VSOCK skipUnless removed by PR #119465 #129561
Merged
@pablogsal
pablogsal merged commit 2bd9f9b into python:3.10 Feb 13, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 13, 2025
@encukou encukou added the needs backport to 3.9 label Feb 13, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 13, 2025

Copy link
Copy Markdown

Thanks @miss-islington for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 13, 2025
@miss-islington @vstinner @gpshead
[3.10] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-1…
4ac4704 
…29171) (pythonGH-129440)

* [3.11] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-129171)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit 45db419)

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
(cherry picked from commit cbfe302)

* pythongh-119461: Restore the testSocket VSOCK skipUnless removed by PR pythonGH-119465 (pythonGH-129561)

Restore the skipUnless removed by pythonGH-119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.

---------

(cherry picked from commit 2bd9f9b)

Co-authored-by: Miss Islington (bot) <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 13, 2025

Copy link
Copy Markdown

GH-130075 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.9 label Feb 13, 2025
ambv pushed a commit that referenced this pull request Feb 19, 2025
@miss-islington @vstinner
@gpshead @encukou
[3.9] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171) (GH-12…
d80cbdd 
…9440) (#130075)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit 45db419)
(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
(cherry picked from commit cbfe302)

---

Restore the skipUnless removed by GH-119465.

This test can only pass on virtual machines, not actual machines.
Actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.

(cherry picked from commit 2bd9f9b)

Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
@miss-islington
miss-islington deleted the backport-45db419-3.10 branch January 2, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @encukou @bedevere-bot @gpshead @pablogsal @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.