GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-36073: Raise ProgrammingError on recursive usage of cursors in sqlite converters by sir-sigurd · Pull Request #11984 · python/cpython

Conversation

@sir-sigurd

@sir-sigurd sir-sigurd commented Feb 22, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue36073

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
k-funk and erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 22, 2019
@bedevere-bot bedevere-bot added the awaiting review label Feb 22, 2019
@sir-sigurd
sir-sigurd force-pushed the sqlite-converter-segfault branch from 6a8c1fb to f1a838a Compare February 22, 2019 07:50
auvipy
auvipy approved these changes Jun 1, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jun 1, 2019
auvipy
auvipy approved these changes Jun 1, 2019
View reviewed changes
BoboTiG
BoboTiG reviewed Jun 21, 2019
View reviewed changes
Comment thread Lib/sqlite3/test/regression.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@BoboTiG

BoboTiG commented Jun 21, 2019

Copy link
Copy Markdown
Contributor

Thanks @sir-sigurd, I think a NEWs entry would be interesting, don't you?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sir-sigurd
sir-sigurd requested a review from berkerpeksag as a code owner June 22, 2019 05:22
@sir-sigurd
sir-sigurd force-pushed the sqlite-converter-segfault branch 2 times, most recently from 16a6d90 to 6f1b983 Compare June 22, 2019 10:27
@erlend-aasland

erlend-aasland commented Apr 1, 2021

Copy link
Copy Markdown
Contributor

@sir-sigurd, can you rebase onto master?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland requested changes Apr 8, 2021
View reviewed changes
Comment thread Modules/_sqlite/cursor.c Outdated
Comment on lines 365 to 366

@erlend-aasland erlend-aasland Apr 8, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format these lines according to PEP 7.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_sqlite/cursor.c Outdated

@erlend-aasland erlend-aasland Apr 8, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is longer than 79 characters, ref. PEP 7.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_sqlite/cursor.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2019-06-22-11-01-45.bpo-36073.ED8mB9.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/sqlite3/test/regression.py Outdated

@erlend-aasland erlend-aasland Apr 8, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be rebased onto master in order to fit in with the changes in the test suite.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sir-sigurd

sir-sigurd commented Apr 9, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland
I'll try to rebase in the near future, though I almost do not remember anything about this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

I'll try to rebase in the near future, though I almost do not remember anything about this.

Thanks, there's no hurry :)
sir-sigurd reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sir-sigurd
bpo-36073: Raise ProgrammingError on recursive usage of cursors in sq…
c79e784 
…lite converters
@sir-sigurd
sir-sigurd force-pushed the sqlite-converter-segfault branch from d3a828d to c79e784 Compare April 12, 2021 08:14
erlend-aasland
erlend-aasland approved these changes Jun 16, 2021
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
erlend-aasland requested a review from serhiy-storchaka June 16, 2021 16:27
@erlend-aasland

erlend-aasland commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

@serhiy-storchaka would you mind reviewing this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Aug 26, 2021

Copy link
Copy Markdown
Contributor

Could you rebase again (bco. GH-27884), @sir-sigurd? :)

Also, please clean up the regression test:

  • line length is limited to 79 chars
  • please use double quotes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Oct 19, 2021
gh-80254: Disallow recursive usage of cursors in sqlite3 converters #29054
Merged
@sir-sigurd

sir-sigurd commented Nov 17, 2021

Copy link
Copy Markdown
Contributor Author

Closed in favor of GH-29054.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sir-sigurd sir-sigurd closed this Nov 17, 2021
@sir-sigurd
sir-sigurd deleted the sqlite-converter-segfault branch November 17, 2021 04:17
@sir-sigurd sir-sigurd mannequin mentioned this pull request Apr 10, 2022
sqlite crashes with converters mutating cursor #80254
Closed
heitbaum added a commit to heitbaum/LibreELEC.tv that referenced this pull request May 17, 2022
@heitbaum
Python3: update to 3.9.13
5c655c7 
release:
- https://www.python.org/downloads/release/python-3913/
changelog:
- https://docs.python.org/release/3.9.13/whatsnew/changelog.html

upstream fix for dropped patch
- python/cpython#80254
- python/cpython#11984
- python/cpython#90228
- python/cpython#92036
- python/cpython#92037
- python/cpython#92297
- bpo-36073
- was
  - python/cpython#30579
  - python/cpython#30580
@heitbaum heitbaum mentioned this pull request May 17, 2022
Python3: update to 3.9.13 LibreELEC/LibreELEC.tv#6494
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka
+2 more reviewers
@BoboTiG BoboTiG BoboTiG left review comments
@auvipy auvipy auvipy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sir-sigurd @BoboTiG @erlend-aasland @auvipy @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.