GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44976: Lazy creation of `sqlite3` result rows by erlend-aasland · Pull Request #27884 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 22, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • remove 'next_row' member from Cursor object
  • remove _pysqlite_fetch_one_row() call from query execute loop
  • as a result of the two above, pysqlite_cursor_iternext() is vastly simplified

https://bugs.python.org/issue44976

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
Only build result rows when needed
ce0d55f 
- remove 'next_row' member in Cursor object
- remove fetch-one-row call from query execute loop
- rewrite cursor iternext method to comply with the new behaviour
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner August 22, 2021 09:08
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 22, 2021
@bedevere-bot bedevere-bot added the awaiting review label Aug 22, 2021
@erlend-aasland
erlend-aasland requested review from pablogsal and serhiy-storchaka August 22, 2021 09:09
@erlend-aasland erlend-aasland added the skip news label Aug 22, 2021
@erlend-aasland

erlend-aasland commented Aug 22, 2021

Copy link
Copy Markdown
Contributor Author

Internal change; no user-visible or backwards incompatible changes; skipping news.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 22, 2021
@bedevere-bot

bedevere-bot commented Aug 22, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ce0d55f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 22, 2021
@erlend-aasland

erlend-aasland commented Aug 22, 2021

Copy link
Copy Markdown
Contributor Author

The AMD64 Arch Linux Asan Debug PR buildbot failure seems to be unrelated. I see that it's been failing a lot recently.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Aug 25, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 25, 2021
@pablogsal
pablogsal merged commit 3df0fc8 into python:main Aug 25, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 25, 2021
@erlend-aasland
erlend-aasland deleted the sqlite-fetch-when-needed branch August 25, 2021 10:31
@erlend-aasland

erlend-aasland commented Aug 25, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, Pablo!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Aug 25, 2021
Erlend E. Aasland
Sync with 'main' bco. pythonGH-27884
0633095
@erlend-aasland erlend-aasland mentioned this pull request Aug 26, 2021
bpo-36073: Raise ProgrammingError on recursive usage of cursors in sqlite converters #11984
Closed
@erlend-aasland erlend-aasland mentioned this pull request Sep 14, 2021
bpo-43853: Expand test suite for SQLite UDF's #27642
Merged
@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
[sqlite3] lazy creation of result rows #89139
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @bedevere-bot @pablogsal @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.