GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Doc: Use ``major.minor`` for documentation distribution archive filenames by AA-Turner · Pull Request #124489 · python/cpython

Conversation

AA-Turner commented Sep 25, 2024 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Per python/docs-community#131, this adjusts the documentation archive filenames to only include "major.minor".

Ned outlines a key motivating point:

"python-3.12.5-docs-pdf-a4.zip neither reflects the state of the documentation at the time of the 3.12.5 release nor necessarily the final state of the 3.12 docs prior to the 3.12.6 release; it's just what existed in the 3.12 git branch the last time the cron started building (and successfully finished) before the 3.12.6 release was merged into the 3.12 branch."

By just using x.y we are honest that the download reflects the state of the website rather than any one release -- for that, use https://docs.python.org/release/.

This patch changes patchlevel.py to return the major.minor version rather than the full release version. This is picked up in the Makefile as $(DISTVERSION) and interpolated into the filenames.

📚 Documentation preview 📚: https://cpython-previews--124489.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Use major.minor for documentation distribution archive filenames

a778b16

AA-Turner added docs

Documentation in the Doc dir

skip issue skip news needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes labels

Sep 25, 2024

AA-Turner requested review from hugovk and ned-deily

September 25, 2024 05:40

bedevere-app Bot added the awaiting core review label

Sep 25, 2024

AA-Turner mentioned this pull request

Sep 25, 2024

One HTML-only cron + one everything-but-HTML cron python/docs-community#131

Closed


          Use the short version on the downloads page

e1daee0

ned-deily commented Sep 25, 2024

Copy link

Copy Markdown

Member

The file names don't seem to have been changed with the current version of the PR (see the RTD preview index page)?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner commented Sep 25, 2024

Copy link

Copy Markdown

Member Author

The file names don't seem to have been changed with the current version of the PR (see the RTD preview index page)?

Do you mean https://cpython-previews--124489.org.readthedocs.build/en/124489/download.html? This is linked to the static release files uploaded by RMs, it's only the daily builds (run with -Adaily=1) that will have the new filenames/links.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ned-deily commented Sep 25, 2024

Copy link

Copy Markdown

Member

Doh!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ned-deily approved these changes

Sep 25, 2024

View reviewed changes

ned-deily left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Sep 25, 2024

AA-Turner merged commit 6318ffc into python:main

Sep 25, 2024

AA-Turner deleted the docs/dist-major-minor branch

September 25, 2024 19:06

miss-islington-app Bot commented Sep 25, 2024

Copy link

Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Sep 25, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 25, 2024


          Doc: Use major.minor for documentation distribution archive filen…

b2e72f5

…ames (pythonGH-124489)

(cherry picked from commit 6318ffc)

Co-authored-by: Adam Turner <[email protected]>

bedevere-app Bot commented Sep 25, 2024

Copy link

Copy Markdown

GH-124534 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 25, 2024


          Doc: Use major.minor for documentation distribution archive filen…

…ames (pythonGH-124489)

(cherry picked from commit 6318ffc)

Co-authored-by: Adam Turner <[email protected]>

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Sep 25, 2024

bedevere-app Bot commented Sep 25, 2024

Copy link

Copy Markdown

GH-124535 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Sep 25, 2024

AA-Turner added a commit that referenced this pull request

Sep 25, 2024


          [3.12] Doc: Use major.minor for documentation distribution archiv…

ea5c650

…e filenames (GH-124489) (#124535)

Doc: Use ``major.minor`` for documentation distribution archive filenames (GH-124489)
(cherry picked from commit 6318ffc)

Co-authored-by: Adam Turner <[email protected]>

emilyemorehouse added a commit to lysnikolaou/cpython that referenced this pull request

Sep 26, 2024


          Merge branch 'main' into fix-help-double-prompt

4cdb3ae

* main: (69 commits)
  Add "annotate" SET_FUNCTION_ATTRIBUTE bit to dis. (python#124566)
  pythongh-124412: Add helpers for converting annotations to source format (python#124551)
  pythongh-119180: Disallow instantiation of ConstEvaluator objects (python#124561)
  For-else deserves its own section in the tutorial (python#123946)
  Add 3.13 as a version option to the crash issue template (python#124560)
  pythongh-123242: Note that type.__annotations__ may not exist (python#124557)
  pythongh-119180: Make FORWARDREF format look at __annotations__ first (python#124479)
  pythonGH-58058: Add quick reference for `ArgumentParser` to argparse docs (pythongh-124227)
  pythongh-41431: Add `datetime.time.strptime()` and `datetime.date.strptime()` (python#120752)
  pythongh-102450: Add ISO-8601 alternative for midnight to `fromisoformat()` calls. (python#105856)
  pythongh-124370: Add "howto" for free-threaded Python (python#124371)
  pythongh-121277: Allow `.. versionadded:: next` in docs (pythonGH-121278)
  pythongh-119400:  make_ssl_certs: update reference test data automatically, pass in expiration dates as parameters python#119400  (pythonGH-119401)
  pythongh-119180: Avoid going through AST and eval() when possible in annotationlib (python#124337)
  pythongh-124448: Update Windows builds to use Tcl/Tk 8.6.15 (pythonGH-124449)
  pythongh-123884 Tee of tee was not producing n independent iterators (pythongh-124490)
  pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15 (pythonGH-124542)
  pythongh-124513: Check args in framelocalsproxy_new() (python#124515)
  pythongh-101100: Add a table of class attributes to the "Custom classes" section of the data model docs (python#124480)
  Doc: Use ``major.minor`` for documentation distribution archive filenames (python#124489)
  ...

Yhg1s pushed a commit that referenced this pull request

Sep 26, 2024


          [3.13] Doc: Use major.minor for documentation distribution archiv…

068e734

…e filenames (GH-124489) (#124534)

Doc: Use ``major.minor`` for documentation distribution archive filenames (GH-124489)
(cherry picked from commit 6318ffc)

Co-authored-by: Adam Turner <[email protected]>

hugovk mentioned this pull request

Dec 5, 2024

Bug: Missing docs archives for Python 3.14 alpha releases python/pythondotorg#2672

Closed

robmoss2k mentioned this pull request

Dec 10, 2024

(python3-streams) Fix copyright reading logic and zip URL generation in python3-streams chocolatey-community/chocolatey-packages#2594

Merged

5 of 11 tasks

StanFromIreland mentioned this pull request

Sep 5, 2026

[3.11] Fix download links for old PDF achives in docs #157002

Open

Reviewers

ned-deily

ned-deily approved these changes

hugovk

Awaiting requested review from hugovk

hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

AA-Turner commented Sep 25, 2024 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ned-deily commented Sep 25, 2024

Uh oh!

AA-Turner commented Sep 25, 2024

Uh oh!

ned-deily commented Sep 25, 2024

Uh oh!

ned-deily left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Sep 25, 2024

Uh oh!

bedevere-app Bot commented Sep 25, 2024

Uh oh!

bedevere-app Bot commented Sep 25, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AA-Turner commented Sep 25, 2024 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.