GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124412: Add helpers for converting annotations to source format by JelleZijlstra · Pull Request #124551 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Sep 25, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is on top of #124479 because that PR changes some related logic.

  • Issue: How to convert annotations to Format.SOURCE in __annotate__? #124412

📚 Documentation preview 📚: https://cpython-previews--124551.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
JelleZijlstra added 5 commits September 24, 2024 17:29
@JelleZijlstra
pythongh-119180: Make FORWARDREF format look at __annotations__ first
f6161df
From discussion with @larryhastings and @carljm, this is the desired
behavior.
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into anno-to-source
7b6fb32
@JelleZijlstra
pythongh-124412: Add helpers for converting annotations to source format
430f184
@JelleZijlstra
more docs
a3cb74c
@JelleZijlstra
format
4ebc406
@JelleZijlstra
JelleZijlstra requested a review from sobolevn September 25, 2024 21:53
@JelleZijlstra
JelleZijlstra requested review from AlexWaygood and rhettinger as code owners September 25, 2024 21:53
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 25, 2024
How to convert annotations to Format.SOURCE in __annotate__? #124412
Closed
@JelleZijlstra JelleZijlstra added the skip news label Sep 25, 2024
@JelleZijlstra JelleZijlstra mentioned this pull request Sep 25, 2024
gh-119180: Make FORWARDREF format look at __annotations__ first #124479
Merged
@rhettinger
rhettinger removed their request for review September 25, 2024 22:20
@carljm

carljm commented Sep 25, 2024

Copy link
Copy Markdown
Member

Can you rebase this so the changes from #124479 are no longer included in it?

JelleZijlstra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra
Merge branch 'main' into anno-to-source
4921cb2
carljm
carljm approved these changes Sep 25, 2024
View reviewed changes
Comment thread Lib/annotationlib.py


def annotations_to_source(annotations):
"""Convert an annotation dict containing values to approximately the SOURCE format."""

@carljm carljm Sep 25, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"approximately the SOURCE format" 😆

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood reacted with rocket emoji
All reactions
  • 🚀 1 reaction
Comment thread Lib/typing.py
Comment on lines 245 to 247
if isinstance(obj, tuple):
# Special case for `repr` of types with `ParamSpec`:
return '[' + ', '.join(_type_repr(t) for t in obj) + ']'

@carljm carljm Sep 25, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a case we don't want in value_to_source?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@JelleZijlstra JelleZijlstra Sep 25, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it's specifically for the internals of Callable and doesn't make sense in general. (Notice that it represents tuples with list syntax.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 25, 2024
@JelleZijlstra
Merge branch 'main' into anno-to-source
304e4fc
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) September 25, 2024 23:36
@JelleZijlstra
JelleZijlstra merged commit 4e829c0 into python:main Sep 26, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 26, 2024
emilyemorehouse added a commit to lysnikolaou/cpython that referenced this pull request Sep 26, 2024
@emilyemorehouse
Merge branch 'main' into fix-help-double-prompt
4cdb3ae
* main: (69 commits)
  Add "annotate" SET_FUNCTION_ATTRIBUTE bit to dis. (python#124566)
  pythongh-124412: Add helpers for converting annotations to source format (python#124551)
  pythongh-119180: Disallow instantiation of ConstEvaluator objects (python#124561)
  For-else deserves its own section in the tutorial (python#123946)
  Add 3.13 as a version option to the crash issue template (python#124560)
  pythongh-123242: Note that type.__annotations__ may not exist (python#124557)
  pythongh-119180: Make FORWARDREF format look at __annotations__ first (python#124479)
  pythonGH-58058: Add quick reference for `ArgumentParser` to argparse docs (pythongh-124227)
  pythongh-41431: Add `datetime.time.strptime()` and `datetime.date.strptime()` (python#120752)
  pythongh-102450: Add ISO-8601 alternative for midnight to `fromisoformat()` calls. (python#105856)
  pythongh-124370: Add "howto" for free-threaded Python (python#124371)
  pythongh-121277: Allow `.. versionadded:: next` in docs (pythonGH-121278)
  pythongh-119400:  make_ssl_certs: update reference test data automatically, pass in expiration dates as parameters python#119400  (pythonGH-119401)
  pythongh-119180: Avoid going through AST and eval() when possible in annotationlib (python#124337)
  pythongh-124448: Update Windows builds to use Tcl/Tk 8.6.15 (pythonGH-124449)
  pythongh-123884 Tee of tee was not producing n independent iterators (pythongh-124490)
  pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15 (pythonGH-124542)
  pythongh-124513: Check args in framelocalsproxy_new() (python#124515)
  pythongh-101100: Add a table of class attributes to the "Custom classes" section of the data model docs (python#124480)
  Doc: Use ``major.minor`` for documentation distribution archive filenames (python#124489)
  ...
@campaigner-prod campaigner-prod Bot mentioned this pull request Apr 23, 2026
fix(deps): vuln minor upgrades — 15 packages (minor: 7 · patch: 8) [src/loadgenerator] DataDog/opentelemetry-demo#73
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@sobolevn sobolevn Awaiting requested review from sobolevn
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @carljm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.