GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124378: Update test_ttk for Tcl/Tk 8.6.15 by zware · Pull Request #124542 · python/cpython

Conversation

@zware

@zware zware commented Sep 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is split out from @culler's GH-124156 as a minimal fix for Tcl/Tk 8.6.15 support to unblock GH-124449.

  • Issue: New test_ttk failure on Mac: "bad screen distance" #124378

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@zware @culler
pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15
456038f
Co-Authored-By: Marc Culler <[email protected]>
@bedevere-app bedevere-app Bot added awaiting core review tests Tests in the Lib/test dir labels Sep 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 25, 2024
New test_ttk failure on Mac: "bad screen distance" #124378
Closed
@zware
zware enabled auto-merge (squash) September 25, 2024 19:49
@zware zware added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Sep 25, 2024
@zware
zware merged commit fb6bd31 into python:main Sep 25, 2024
@zware
zware deleted the fix_test_ttk_for_8.6.15 branch September 25, 2024 20:16
@miss-islington-app

miss-islington-app Bot commented Sep 25, 2024

Copy link
Copy Markdown

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 25, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2024
@zware @culler @miss-islington
pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15 (pythonGH-124542)
3fd3105
(cherry picked from commit fb6bd31)

Co-authored-by: Zachary Ware <[email protected]>
Co-authored-by: Marc Culler <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 25, 2024

Copy link
Copy Markdown

GH-124544 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2024
@zware @culler @miss-islington
pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15 (pythonGH-124542)
25acf67
(cherry picked from commit fb6bd31)

Co-authored-by: Zachary Ware <[email protected]>
Co-authored-by: Marc Culler <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 25, 2024
@bedevere-app

bedevere-app Bot commented Sep 25, 2024

Copy link
Copy Markdown

GH-124545 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 25, 2024
emilyemorehouse added a commit to lysnikolaou/cpython that referenced this pull request Sep 26, 2024
@emilyemorehouse
Merge branch 'main' into fix-help-double-prompt
4cdb3ae
* main: (69 commits)
  Add "annotate" SET_FUNCTION_ATTRIBUTE bit to dis. (python#124566)
  pythongh-124412: Add helpers for converting annotations to source format (python#124551)
  pythongh-119180: Disallow instantiation of ConstEvaluator objects (python#124561)
  For-else deserves its own section in the tutorial (python#123946)
  Add 3.13 as a version option to the crash issue template (python#124560)
  pythongh-123242: Note that type.__annotations__ may not exist (python#124557)
  pythongh-119180: Make FORWARDREF format look at __annotations__ first (python#124479)
  pythonGH-58058: Add quick reference for `ArgumentParser` to argparse docs (pythongh-124227)
  pythongh-41431: Add `datetime.time.strptime()` and `datetime.date.strptime()` (python#120752)
  pythongh-102450: Add ISO-8601 alternative for midnight to `fromisoformat()` calls. (python#105856)
  pythongh-124370: Add "howto" for free-threaded Python (python#124371)
  pythongh-121277: Allow `.. versionadded:: next` in docs (pythonGH-121278)
  pythongh-119400:  make_ssl_certs: update reference test data automatically, pass in expiration dates as parameters python#119400  (pythonGH-119401)
  pythongh-119180: Avoid going through AST and eval() when possible in annotationlib (python#124337)
  pythongh-124448: Update Windows builds to use Tcl/Tk 8.6.15 (pythonGH-124449)
  pythongh-123884 Tee of tee was not producing n independent iterators (pythongh-124490)
  pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15 (pythonGH-124542)
  pythongh-124513: Check args in framelocalsproxy_new() (python#124515)
  pythongh-101100: Add a table of class attributes to the "Custom classes" section of the data model docs (python#124480)
  Doc: Use ``major.minor`` for documentation distribution archive filenames (python#124489)
  ...
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
@miss-islington @zware @culler
[3.13] gh-124378: Update test_ttk for Tcl/Tk 8.6.15 (GH-124542) (#124544
c7f9332
)

gh-124378: Update test_ttk for Tcl/Tk 8.6.15 (GH-124542)
(cherry picked from commit fb6bd31)

Co-authored-by: Zachary Ware <[email protected]>
Co-authored-by: Marc Culler <[email protected]>
thunze added a commit to thunze/nixpkgs that referenced this pull request Sep 15, 2025
@thunze
python313Packages.tkinter: patch failing ttk test for python <3.12
69b8cd9
python/cpython#124378
python/cpython#124542
matejc pushed a commit to matejc/nixpkgs that referenced this pull request Sep 24, 2025
@thunze @matejc
python313Packages.tkinter: patch failing ttk test for python <3.12
7d17946
python/cpython#124378
python/cpython#124542
tm-drtina pushed a commit to awakesecurity/nixpkgs that referenced this pull request Sep 29, 2025
@thunze @tm-drtina-arista
python313Packages.tkinter: patch failing ttk test for python <3.12
3f09a27
python/cpython#124378
python/cpython#124542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@zware
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.