GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier by WolframAlph · Pull Request #131830 · python/cpython

Conversation

@WolframAlph

@WolframAlph WolframAlph commented Mar 28, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Move const folding to the peephole optimizer #126835

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@WolframAlph
WolframAlph requested review from a team, AA-Turner, Eclips4, ericsnowcurrently, erlend-aasland, ezio-melotti, hugovk and isidentical as code owners March 28, 2025 11:34
@bedevere-app bedevere-app Bot added the awaiting review label Mar 28, 2025
@WolframAlph
WolframAlph marked this pull request as draft March 28, 2025 11:34
@bedevere-app bedevere-app Bot removed the awaiting review label Mar 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 28, 2025
Move const folding to the peephole optimizer #126835
Open
@hugovk
hugovk removed their request for review March 28, 2025 13:05
@WolframAlph WolframAlph changed the title gh-126835: Rename ast_opt.c -> ast_process.c gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier Mar 28, 2025
picnixz
picnixz approved these changes Mar 28, 2025
View reviewed changes
Comment thread Python/compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-03-28-15-06-55.gh-issue-126835.IpcMTn.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added the awaiting merge label Mar 28, 2025
@WolframAlph
WolframAlph marked this pull request as ready for review March 28, 2025 14:35
@WolframAlph
WolframAlph requested review from iritkatriel and markshannon as code owners March 28, 2025 14:35
@bedevere-app bedevere-app Bot added awaiting review and removed awaiting merge labels Mar 28, 2025
@WolframAlph
WolframAlph requested a review from picnixz March 28, 2025 14:46
@iritkatriel

iritkatriel commented Mar 28, 2025

Copy link
Copy Markdown
Member

I'm not sure about the name ast_process. Seems to nonspecific. I don't have a better idea at the moment though.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@WolframAlph

WolframAlph commented Mar 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

It does all kind of things. Optimizes format, removes docstrings, implements PEP 765, etc. I don't think there is good name for it to make it more specific.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@WolframAlph

WolframAlph commented Mar 28, 2025

Copy link
Copy Markdown
Contributor Author

@picnixz Maybe you have better suggestion how to name it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@picnixz

picnixz commented Mar 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I think "ast_process" is fine but otherwise, something with AST_Transform as we're doing a transformation/checks on the AST. I feel there is a mix of AST optimization (real opts + docstrings eradication), a bit of AST processing/post-processing (PEP 765) and more. So process is fine IMO.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iritkatriel

iritkatriel commented Mar 29, 2025

Copy link
Copy Markdown
Member

Maybe ast_preprocess. Preprocessing is a term you hear in compilers.

Eclips4 and picnixz reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

picnixz
picnixz reviewed Mar 30, 2025
View reviewed changes

@picnixz picnixz left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think preprocess is better as it's before we compile (and compilers would call it a pre-processing step (e.g., C compilers would pre-process macros here and comments elimination; well optimization is not part of pre-processing and usually happens after but still before compilation I think?).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@iritkatriel iritkatriel mentioned this pull request Mar 31, 2025
Compilation emits multiple warnings in the finally block #131927
Closed
@python-cla-bot

python-cla-bot Bot commented Apr 6, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Eclips4

Eclips4 commented May 1, 2025

Copy link
Copy Markdown
Member

Hi @WolframAlph, are you still planning to work on this? We need to ship it soon since the feature freeze is approaching (May 6th).

Regarding the naming—I believe ast_preprocess is the most appropriate choice here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@WolframAlph

WolframAlph commented May 1, 2025

Copy link
Copy Markdown
Contributor Author

Hi sorry for the delay, Ive been super busy last weeks. I will finish this ASAP.

Eclips4 reacted with thumbs up emoji Eclips4 reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

WolframAlph added 7 commits May 4, 2025 09:00
@WolframAlph
rename ast_opt.c -> ast_process.c
678b085
@WolframAlph
_PyASTOptimizeState -> _PyASTProcessState
e080e27
@WolframAlph
_PyAST_Optimize -> _PyAST_Process
5153ea5
@WolframAlph
_PyCompile_AstOptimize -> _PyCompile_AstProcess
ad5d080
@WolframAlph
add news
3a6abef
@WolframAlph
address review
e2a3cbc
@WolframAlph
mention full file path
2d1bc6f
@WolframAlph
WolframAlph force-pushed the rename-ast-opt branch from 58648da to 2d1bc6f Compare May 4, 2025 07:22
WolframAlph added 2 commits May 4, 2025 09:22
@WolframAlph
rename process to preprocess
3b43460
@WolframAlph
_PyASTProcessState -> _PyASTPreprocessState
72cca4f
AA-Turner
AA-Turner reviewed May 4, 2025
View reviewed changes
Comment thread Python/ast_preprocess.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@WolframAlph
update comment
8a59650
@WolframAlph

WolframAlph commented May 4, 2025

Copy link
Copy Markdown
Contributor Author

@Eclips4 I've updated the PR. Please take a look.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Eclips4
Eclips4 approved these changes May 4, 2025
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 4, 2025
@Eclips4
Eclips4 requested a review from picnixz May 4, 2025 12:35
@Eclips4
Merge branch 'main' into rename-ast-opt
a30846d
picnixz
picnixz approved these changes May 4, 2025
View reviewed changes
@Eclips4
Eclips4 merged commit 0a1fedb into python:main May 4, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 4, 2025
diegorusso added a commit to diegorusso/cpython that referenced this pull request May 4, 2025
@diegorusso
Merge remote-tracking branch 'origin/main' into call-len
c03babc
* origin/main: (111 commits)
  pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385)
  pythongh-131178: Add tests for `ast` command-line interface (python#133329)
  Regenerate pcbuild.sln in Visual Studio 2022 (python#133394)
  pythongh-133042: disable HACL* HMAC on Emscripten (python#133064)
  pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387)
  pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946)
  pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388)
  pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830)
  pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368)
  pythongh-132457: make staticmethod and classmethod generic (python#132460)
  pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812)
  pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490)
  pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517)
  pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628)
  pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358)
  bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226)
  pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287)
  pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364)
  pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027)
  pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284)
  ...
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@WolframAlph @Pranjal095
pythongh-126835: Rename ast_opt.c to ast_preprocess.c and related…
53ed8c0
… stuff after moving const folding to the peephole optimizier (python#131830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner left review comments
@picnixz picnixz picnixz approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes
@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@WolframAlph @iritkatriel @picnixz @Eclips4 @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.