GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133042: disable HACL* HMAC on Emscripten by picnixz · Pull Request #133064 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Apr 27, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I don't want to hold the next beta and I don't know how we can easily make it work. I don't really want to revert #132438 as it solves an issue with freeze.py but we may eventually need to do it.

I plan to leave on Monday evening and I won't have access to my dev session until May 8th or something like that.

@hugovk Feel free to revert #132438 and #133012.
@hoodmane Feel free to take over this branch if you want. Also, please first confirm that disabling HACL* HMAC actually solves the issue (ISTM that it kinda works but I needed to run make manually because I had some issues with my system-wide Python that is too old for emcc & co).

  • Issue: emscripten cross-compile wasm-ld: error: duplicate symbol _Py_LibHacl_Hacl_Hash_* #133042

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hoodmane reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@picnixz
disable HACL* HMAC on Emscripten
f649e9a
@picnixz
picnixz requested review from corona10 and erlend-aasland as code owners April 27, 2025 23:08
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 27, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 27, 2025
emscripten cross-compile wasm-ld: error: duplicate symbol _Py_LibHacl_Hacl_Hash_* #133042
Open
@picnixz picnixz added the skip news label Apr 27, 2025
@picnixz
picnixz requested a review from hoodmane April 27, 2025 23:09
@picnixz

picnixz commented Apr 27, 2025

Copy link
Copy Markdown
Member Author

@Lukasdoe Would this fix your issue?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Lukasdoe

Lukasdoe commented Apr 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

yes! I can confirm that this fixes the issue for me. Thx, well done :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@picnixz

picnixz commented Apr 28, 2025

Copy link
Copy Markdown
Member Author

Ok, I think it's better to just disable HACL* HMAC on Emscripten for now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@picnixz
Merge branch 'main' into fix/build/hacl-emscripten-133042
f8a571b
@picnixz
picnixz requested a review from hugovk May 4, 2025 17:06
hugovk
hugovk approved these changes May 4, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 4, 2025
@picnixz
picnixz merged commit 7b96701 into python:main May 4, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 4, 2025
@picnixz
picnixz deleted the fix/build/hacl-emscripten-133042 branch May 4, 2025 19:55
@hoodmane

hoodmane commented May 4, 2025

Copy link
Copy Markdown
Contributor

Thanks @picnixz ! I'm not sure why I didn't see these notifications until just now. My GitHub notifications are a mess.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hoodmane

hoodmane commented May 4, 2025

Copy link
Copy Markdown
Contributor

I'll look into fixing this tomorrow.

picnixz reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

diegorusso added a commit to diegorusso/cpython that referenced this pull request May 4, 2025
@diegorusso
Merge remote-tracking branch 'origin/main' into call-len
c03babc
* origin/main: (111 commits)
  pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385)
  pythongh-131178: Add tests for `ast` command-line interface (python#133329)
  Regenerate pcbuild.sln in Visual Studio 2022 (python#133394)
  pythongh-133042: disable HACL* HMAC on Emscripten (python#133064)
  pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387)
  pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946)
  pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388)
  pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830)
  pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368)
  pythongh-132457: make staticmethod and classmethod generic (python#132460)
  pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812)
  pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490)
  pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517)
  pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628)
  pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358)
  bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226)
  pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287)
  pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364)
  pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027)
  pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284)
  ...
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@picnixz @Pranjal095
pythongh-133042: disable HACL* HMAC on Emscripten (python#133064)
bcbba36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@hoodmane hoodmane Awaiting requested review from hoodmane

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@picnixz @Lukasdoe @hoodmane @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.