GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91048: Add filename and line number to external inspection routines by pablogsal · Pull Request #133385 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented May 4, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Async Call-Stack Reconstruction #91048

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners May 4, 2025 16:29
@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2025
Async Call-Stack Reconstruction #91048
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 4, 2025
@pablogsal
pablogsal force-pushed the other branch from 4fabd02 to 20194ad Compare May 4, 2025 16:30
1st1
1st1 reviewed May 4, 2025
View reviewed changes
Comment thread Modules/_remotedebuggingmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
1st1
1st1 reviewed May 4, 2025
View reviewed changes
Comment thread Lib/test/test_external_inspection.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
1st1
1st1 reviewed May 4, 2025
View reviewed changes

@1st1 1st1 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merry x-mas! This is very cool. Left a couple of nit comments, looks great otherwise! <3

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal force-pushed the other branch 4 times, most recently from e16d029 to 1312fb5 Compare May 4, 2025 17:30
@pablogsal pablogsal added the skip news label May 4, 2025
pablogsal
pablogsal commented May 4, 2025
View reviewed changes
Comment thread Lib/asyncio/tools.py
for tid, tname, awaited in tasks:
id2name[tid] = tname
for stack, parent_id in awaited:
stack = [elem[0] if isinstance(elem, tuple) else elem for elem in stack]

@pablogsal pablogsal May 4, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ambv This code just returns the fully qualified name. Play a bit with this and decide how we want to format this in the tool

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ambv reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@pablogsal

pablogsal commented May 4, 2025

Copy link
Copy Markdown
Member Author

No ref leaks:

.venv ❯ sudo -E ./python.exe -m test test_external_inspection -R :
Using random seed: 1218919259
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 9.64 Run 1 test sequentially in a single process
0:00:00 load avg: 9.64 [1/1] test_external_inspection
beginning 9 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more)
12345:6789
XX... ....
0:00:47 load avg: 6.37 [1/1] test_external_inspection passed in 47.2 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 47.2 sec
Total tests: run=7
Total test files: run=1/1
Result: SUCCESS
ambv and chris-eibl reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal force-pushed the other branch from 1312fb5 to eabbf17 Compare May 4, 2025 17:37
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 4, 2025
@bedevere-bot

bedevere-bot commented May 4, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit eabbf17 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133385%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 4, 2025
@pablogsal
pythongh-91048: Add filename and line number to external inspection r…
1236923 
…outines

Signed-off-by: Pablo Galindo <[email protected]>
@pablogsal
pablogsal force-pushed the other branch from eabbf17 to 1236923 Compare May 4, 2025 18:01
@ambv
ambv merged commit 3109c47 into python:main May 4, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label May 4, 2025
diegorusso added a commit to diegorusso/cpython that referenced this pull request May 4, 2025
@diegorusso
Merge remote-tracking branch 'origin/main' into call-len
c03babc 
* origin/main: (111 commits)
  pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385)
  pythongh-131178: Add tests for `ast` command-line interface (python#133329)
  Regenerate pcbuild.sln in Visual Studio 2022 (python#133394)
  pythongh-133042: disable HACL* HMAC on Emscripten (python#133064)
  pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387)
  pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946)
  pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388)
  pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830)
  pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368)
  pythongh-132457: make staticmethod and classmethod generic (python#132460)
  pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812)
  pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490)
  pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517)
  pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628)
  pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358)
  bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226)
  pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287)
  pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364)
  pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027)
  pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284)
  ...
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@pablogsal @Pranjal095
pythongh-91048: Add filename and line number to external inspection r…
5c09844 
…outines (pythonGH-133385)

Signed-off-by: Pablo Galindo <[email protected]>
@pablogsal
pablogsal deleted the other branch September 24, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 left review comments
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @bedevere-bot @1st1 @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.