GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-27513: email.utils.getaddresses() now handles Header objects by ZackerySpytz · Pull Request #13797 · python/cpython

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Jun 4, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

getaddresses() should be able to handle a Header object if passed
one.

https://bugs.python.org/issue27513

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BoboTiG reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ZackerySpytz
ZackerySpytz requested a review from a team as a code owner June 4, 2019 05:59
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 4, 2019
@bedevere-bot bedevere-bot added the awaiting review label Jun 4, 2019
@csabella

csabella commented Jun 4, 2019

Copy link
Copy Markdown
Contributor

cc @maxking
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
maxking
maxking suggested changes Jun 4, 2019
View reviewed changes

@maxking maxking left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, overall it looks good to me.
Can we also change the docs to reflect that getaddress can accept header values or header objects and perhaps an example in the docs as well. There are other examples for header values in there.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_email/test_email.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2019-06-03-23-53-25.bpo-27513.qITN7d.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jun 4, 2019
@brettcannon brettcannon added the type-feature A feature request or enhancement label Jun 4, 2019
taleinat
taleinat suggested changes Jun 27, 2019
View reviewed changes

@taleinat taleinat left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of @maxking's comments are spot on, including adding mention in the docs, except that adding an example of this in the docs would be nice to have, but not necessary. Please make the changes suggested in his comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Jun 27, 2019
@bedevere-bot

bedevere-bot commented Jun 27, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csabella

csabella commented Jan 26, 2020

Copy link
Copy Markdown
Contributor

@ZackerySpytz, please address the code review. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TZanke

TZanke commented Apr 29, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

After upgrading our customers to Python3 we now have problems with some mails. Please take care of this fix, right know we are stuck manually handling the failing mails.

@ZackerySpytz Can you please give me a permission to edit your branch, so i can make the requested changes?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BoboTiG

BoboTiG commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

That easy one would be great for 3.10. @ambv do you think this is doable?
ambv reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ZackerySpytz and others added 2 commits July 19, 2021 16:44
@ZackerySpytz @ambv
bpo-27513: email.utils.getaddresses() now handles Header objects
bf600e1 
getaddresses() should be able to handle a Header object if passed
one.
@ambv
Respond to review
1c79276
@ambv
ambv force-pushed the bpo-27513-email-getaddresses-Headers branch from 605e9e7 to 1c79276 Compare July 19, 2021 15:18
@ambv ambv added the needs backport to 3.10 label Jul 19, 2021
@ambv
ambv merged commit 89f4c34 into python:main Jul 19, 2021
@bedevere-bot

bedevere-bot commented Jul 19, 2021

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting changes label Jul 19, 2021
@bedevere-bot

bedevere-bot commented Jul 19, 2021

Copy link
Copy Markdown

GH-27242 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jul 19, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2021
@ZackerySpytz @miss-islington
bpo-27513: email.utils.getaddresses() now handles Header objects (pyt…
ff346cc 
…honGH-13797)

getaddresses() should be able to handle a Header object if passed
one.

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 89f4c34)

Co-authored-by: Zackery Spytz <[email protected]>
ambv pushed a commit that referenced this pull request Jul 19, 2021
@miss-islington @ZackerySpytz
bpo-27513: email.utils.getaddresses() now handles Header objects (GH-…
8c43bf1 
…13797) (GH-27242)

getaddresses() should be able to handle a Header object if passed
one.

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 89f4c34)

Co-authored-by: Zackery Spytz <[email protected]>
@ambv ambv added the needs backport to 3.9 label Jul 19, 2021
@miss-islington

miss-islington commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jul 19, 2021
@bedevere-bot

bedevere-bot commented Jul 19, 2021

Copy link
Copy Markdown

GH-27245 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2021
@ZackerySpytz @miss-islington
bpo-27513: email.utils.getaddresses() now handles Header objects (pyt…
a98b81b 
…honGH-13797)

getaddresses() should be able to handle a Header object if passed
one.

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 89f4c34)

Co-authored-by: Zackery Spytz <[email protected]>
ambv pushed a commit that referenced this pull request Jul 19, 2021
@miss-islington @ZackerySpytz
bpo-27513: email.utils.getaddresses() now handles Header objects (GH-…
9ee12cf 
…13797) (#27245)

getaddresses() should be able to handle a Header object if passed
one.

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 89f4c34)

Co-authored-by: Zackery Spytz <[email protected]>
@BoboTiG

BoboTiG commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

Wow thanks a lot for your reactivity 💪 :)
TZanke reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jul 20, 2021
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_42035
56e8889 
* origin/main: (1146 commits)
  bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
  bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249)
  correct spelling (pythonGH-27076)
  bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237)
  bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797)
  Clean up comma usage in Doc/library/functions.rst (python#27083)
  bpo-42238: Fix small rst issue in NEWS.d/. (python#27238)
  bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091)
  bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231)
  bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206)
  bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216)
  bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810)
  bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992)
  bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402)
  bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032)
  bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278)
  bpo-44654: Do not export the union type related symbols (pythonGH-27223)
  bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218)
  bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196)
  bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy left review comments
+2 more reviewers
@taleinat taleinat taleinat requested changes
@maxking maxking maxking requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@ZackerySpytz @csabella @bedevere-bot @TZanke @BoboTiG @miss-islington @taleinat @maxking @terryjreedy @brettcannon @ambv @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.