GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42064: Finalise establishing sqlite3 global state by erlend-aasland · Pull Request #27155 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 14, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue42064

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Erlend E. Aasland added 4 commits July 15, 2021 00:49
Erlend E. Aasland
Move _pysqlite_converters to global state
33d9dc0
Erlend E. Aasland
Move _pysqlite_enable_callback_tracebacks to global state
8a3a681
Erlend E. Aasland
Move pysqlite_BaseTypeAdapted to global state
650160d
Erlend E. Aasland
Move psyco_adapters to global state
300ba6c
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner July 14, 2021 23:06
@bedevere-bot bedevere-bot added the awaiting review label Jul 14, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 14, 2021
@erlend-aasland erlend-aasland added the skip news label Jul 14, 2021
@erlend-aasland
erlend-aasland requested a review from encukou July 14, 2021 23:06
@erlend-aasland

erlend-aasland commented Jul 14, 2021

Copy link
Copy Markdown
Contributor Author

With this PR, all sqlite3 static globals have been moved to the global state. There are a couple of global static strings left, but there should be no need for adding them to the state.

Next step: optimise state access (consider passing state as argument, adding defining_class to AC methods, etc.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

encukou
encukou approved these changes Jul 20, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 20, 2021
@encukou

encukou commented Jul 20, 2021

Copy link
Copy Markdown
Member

LGTM, thank you!

erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou
encukou merged commit 4c0deb2 into python:main Jul 20, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 20, 2021
sthagen added a commit to sthagen/python-cpython that referenced this pull request Jul 20, 2021
@sthagen
Merge pull request #545 from python/main
6343dfb
bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jul 20, 2021
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_42035
56e8889
* origin/main: (1146 commits)
  bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
  bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249)
  correct spelling (pythonGH-27076)
  bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237)
  bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797)
  Clean up comma usage in Doc/library/functions.rst (python#27083)
  bpo-42238: Fix small rst issue in NEWS.d/. (python#27238)
  bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091)
  bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231)
  bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206)
  bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216)
  bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810)
  bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992)
  bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402)
  bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032)
  bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278)
  bpo-44654: Do not export the union type related symbols (pythonGH-27223)
  bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218)
  bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196)
  bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211)
  ...
@erlend-aasland
erlend-aasland deleted the sqlite-global-state branch July 20, 2021 20:13
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jul 20, 2021
Erlend E. Aasland
Merge branch 'main' into sqlite-serialize
1bdb611
Regen clinic after pythonGH-27155.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @encukou @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.