GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44340: Add support for building with clang full/thin lto by corona10 · Pull Request #27231 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Jul 18, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue44340

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@corona10 corona10 added the DO-NOT-MERGE label Jul 18, 2021
@corona10
corona10 requested review from ned-deily and pablogsal July 18, 2021 16:11
@bedevere-bot bedevere-bot added the awaiting core review label Jul 18, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 18, 2021
@corona10 corona10 changed the title bpo-44340: Add support for building with clang full/thin lto [DRAFT] bpo-44340: Add support for building with clang full/thin lto Jul 18, 2021
@pablogsal

pablogsal commented Jul 18, 2021

Copy link
Copy Markdown
Member

Make sure you use @tiran solution for regenerating autoconf or otherwise is going to cause some incompatibilities (https://bugs.python.org/issue44035)
tiran reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Jul 18, 2021

Copy link
Copy Markdown
Member Author

Make sure you use @tiran solution for regenerating autoconf or otherwise is going to cause some incompatibilities

Thanks, I will check it out
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Jul 18, 2021

Copy link
Copy Markdown
Member Author

@pablogsal cc @tiran
Okay, it perfectly works :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 mentioned this pull request Jul 18, 2021
bpo-44340: Add support for building with clang thin lto via --with-lto=thin #26585
Closed
corona10
corona10 commented Jul 18, 2021
View reviewed changes
Comment thread configure.ac Outdated

@corona10 corona10 Jul 18, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the Py_LTO_POLICY is the default, it will follow the default LTO option of compiler

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10

corona10 commented Jul 18, 2021

Copy link
Copy Markdown
Member Author

cc @holmanb
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 commented Jul 18, 2021
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
gpshead
gpshead approved these changes Jul 18, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 18, 2021
@corona10
corona10 requested review from gvanrossum and markshannon as code owners July 18, 2021 23:51
@gpshead

gpshead commented Jul 18, 2021

Copy link
Copy Markdown
Member

I believe you pushed a bunch of unrelated commits to the branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 added 5 commits July 18, 2021 23:53
@corona10
bpo-44340: Add support for building with clang full/thin lto
e5fd3b8
@corona10
bpo-44340: Use @tiran solution
ce0757f
@corona10
bpo-44340: Update
5668510
@corona10
bpo-44340: Fix
814b241
@corona10
bpo-44340: Update Doc
1d3f6fa
@corona10
corona10 force-pushed the bpo-44340 branch from fd45916 to 1d3f6fa Compare July 18, 2021 23:53
@corona10
corona10 removed request for gvanrossum and markshannon July 18, 2021 23:54
@corona10 corona10 changed the title [DRAFT] bpo-44340: Add support for building with clang full/thin lto bpo-44340: Add support for building with clang full/thin lto Jul 18, 2021
@corona10

corona10 commented Jul 18, 2021

Copy link
Copy Markdown
Member Author

I believe you pushed a bunch of unrelated commits to the branch.

Thanks, I make a lot of people noise ;)
I've rebased the PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 removed the DO-NOT-MERGE label Jul 18, 2021
corona10
corona10 commented Jul 19, 2021
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am now waiting for @pablogsal 's review who is the release manager of Python 3.11 :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pablogsal
pablogsal approved these changes Jul 19, 2021
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @corona10 and @holmanb !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 and holmanb reacted with thumbs up emoji corona10 reacted with rocket emoji
All reactions
  • 👍 2 reactions
  • 🚀 1 reaction
@corona10
corona10 merged commit b2cf251 into python:main Jul 19, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 19, 2021
@corona10
corona10 deleted the bpo-44340 branch July 19, 2021 10:53
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jul 20, 2021
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_42035
56e8889 
* origin/main: (1146 commits)
  bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
  bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249)
  correct spelling (pythonGH-27076)
  bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237)
  bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797)
  Clean up comma usage in Doc/library/functions.rst (python#27083)
  bpo-42238: Fix small rst issue in NEWS.d/. (python#27238)
  bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091)
  bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231)
  bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206)
  bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216)
  bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810)
  bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992)
  bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402)
  bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032)
  bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278)
  bpo-44654: Do not export the union type related symbols (pythonGH-27223)
  bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218)
  bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196)
  bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@pablogsal pablogsal pablogsal approved these changes
@ned-deily ned-deily Awaiting requested review from ned-deily
+1 more reviewer
@holmanb holmanb holmanb left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@corona10 @pablogsal @gpshead @holmanb @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.