GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — gh-138234: clarify returncode behavior for subprocess_exec vs subprocess_shell by andreuu-tsai · Pull Request #138536 · python/cpython Conversation
|
|
All commit authors signed the Contributor License Agreement. |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
b833aaf to
93cdda2
Compare
gpshead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are several places in subprocess.rst itself that could be updated in a similar manner to mention the potential difference between shell=False (default) and shell=True.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
kumaraditya303
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awaiting subprocess docs changes and CLA
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…hell Update asyncio.subprocess returncode documentation: - For create_subprocess_exec, negative values (-N) indicate termination by signal N (POSIX). - For create_subprocess_shell, the return code follows the invoked shell’s exit status (e.g. 128+N for signals in bash/sh).
5fac6df to
979128f
Compare
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @andreuu-tsai for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
… with `shell=True` (pythonGH-138536) (cherry picked from commit 8a531f8) Co-authored-by: andreuu-tsai <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
… with `shell=True` (pythonGH-138536) (cherry picked from commit 8a531f8) Co-authored-by: andreuu-tsai <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
|
GH-146254 is a backport of this pull request to the 3.14 branch. |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
GH-146255 is a backport of this pull request to the 3.13 branch. |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…d with `shell=True` (GH-138536) (#146254) gh-138234: clarify returncode behavior for subprocesses created with `shell=True` (GH-138536) (cherry picked from commit 8a531f8) Co-authored-by: andreuu-tsai <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
…d with `shell=True` (GH-138536) (#146255) gh-138234: clarify returncode behavior for subprocesses created with `shell=True` (GH-138536) (cherry picked from commit 8a531f8) Co-authored-by: andreuu-tsai <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
* upstream/main: (1475 commits) Docs: replace all `datetime` imports with `import datetime as dt` (python#145640) pythongh-146153: Use `frozendict` in pure python fallback for `curses.has_key` (python#146154) pythongh-138234: clarify returncode behavior for subprocesses created with `shell=True` (python#138536) pythongh-140947: fix contextvars handling for server tasks in asyncio (python#141158) pythonGH-100108: Add async generators best practices section (python#141885) pythonGH-145667: Merge `GET_ITER` and `GET_YIELD_FROM_ITER` (pythonGH-146120) pythongh-146228: Better fork support in cached FastPath (python#146231) pythongh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h (pythongh-146229) pythongh-145980: Fix copy/paste mistake in binascii.c (python#146230) pythongh-146092: Raise MemoryError on allocation failure in _zoneinfo (python#146165) pythongh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (python#139396) pythongh-146196: Fix Undefined Behavior in _PyUnicodeWriter_WriteASCIIString() (python#146201) pythongh-143930: Reject leading dashes in webbrowser URLs pythongh-145916: Soft-deprecate ctypes.util.find_library (pythonGH-145919) pythongh-146205: Check the errno with != 0 in close impls in select module (python#146206) pythongh-146171: Fix nested AttributeError suggestions (python#146188) pythongh-146099: Optimize _GUARD_CODE_VERSION+IP via function version symbols (pythonGH-146101) pythongh-145980: Add support for alternative alphabets in the binascii module (pythonGH-145981) pythongh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format (python#145756) pythongh-145177: Add emscripten run --test, uses test args from config.toml (python#146160) ...
gpshead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
… with `shell=True` (python#138536) Co-authored-by: Kumar Aditya <[email protected]>
Reviewers
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assignedLabels
Milestone
No milestoneDevelopment
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
3 participants
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.