GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146153: Use `frozendict` in pure python fallback for `curses.has_key` by jonathandung · Pull Request #146154 · python/cpython

Conversation

@jonathandung

@jonathandung jonathandung commented Mar 19, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Closes #146153.

  • Issue: Use frozendict in Lib/curses/has_key.py #146153

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
jonathandung added 2 commits March 19, 2026 15:35
@jonathandung
Use frozenmap in curses/has_key.py
540afcd
@jonathandung
Remove whitespace surrounding parentheses
c51e72c
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app bedevere-app Bot mentioned this pull request Mar 19, 2026
Use frozendict in Lib/curses/has_key.py #146153
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Mar 19, 2026
@jonathandung
Merge branch 'python:main' into patch-1
8518484
@bedevere-app

This comment was marked as resolved.

Sign in to view
blurb-it Bot and others added 4 commits March 19, 2026 08:48
@blurb-it
📜🤖 Added by blurb_it.
805dcb2
@jonathandung
Edit news
6f25f93
@jonathandung
Update 2026-03-19-08-48-21.gh-issue-146153.UTK9Mb.rst
4891f62
@jonathandung
Fix linter error
256374f
@jonathandung jonathandung changed the title gh-146153: Use frozenmap in pure python fallback for curses.has_key gh-146153: Use frozendict in pure python fallback for curses.has_key Mar 19, 2026
jonathandung added 4 commits March 19, 2026 17:09
@jonathandung
It's called frozendict
c34da91
not frozenmap
@jonathandung
Update 2026-03-19-08-48-21.gh-issue-146153.UTK9Mb.rst
c2aebbb
@jonathandung
Merge branch 'main' into patch-1
16d4d2c
@jonathandung
Merge branch 'main' into patch-1
f4fec4c
vstinner
vstinner reviewed Mar 19, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-03-19-08-48-21.gh-issue-146153.UTK9Mb.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@jonathandung
Delete Misc/NEWS.d/next/Library/2026-03-19-08-48-21.gh-issue-146153.U…
52652d6
…TK9Mb.rst
@bedevere-app

This comment was marked as resolved.

Sign in to view
@jonathandung
Merge branch 'main' into patch-1
7643a04
@bedevere-app

This comment was marked as resolved.

Sign in to view
@jonathandung
jonathandung requested a review from vstinner March 19, 2026 14:26
@vstinner vstinner added the skip news label Mar 19, 2026
vstinner
vstinner approved these changes Mar 19, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jonathandung reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 19, 2026
@jonathandung
Merge branch 'main' into patch-1
d4e4f37
aisk
aisk reviewed Mar 21, 2026
View reviewed changes
Comment thread Lib/curses/has_key.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

aisk
aisk approved these changes Mar 21, 2026
View reviewed changes
@vstinner
vstinner merged commit f6b5eed into python:main Mar 21, 2026
45 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 21, 2026
@vstinner

vstinner commented Mar 21, 2026

Copy link
Copy Markdown
Member

Merged, thanks for your contribution.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jonathandung

jonathandung commented Mar 21, 2026

Copy link
Copy Markdown
Contributor Author

Thanks

vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jonathandung
jonathandung deleted the patch-1 branch March 21, 2026 14:30
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Mar 22, 2026
@CuriousLearner
Merge remote-tracking branch 'upstream/main' into fix-pythongh-138577
2691ad9
* upstream/main: (1475 commits)
  Docs: replace all `datetime` imports with `import datetime as dt` (python#145640)
  pythongh-146153: Use `frozendict` in pure python fallback for `curses.has_key` (python#146154)
  pythongh-138234: clarify returncode behavior for subprocesses created with `shell=True` (python#138536)
  pythongh-140947: fix contextvars handling for server tasks in asyncio  (python#141158)
  pythonGH-100108: Add async generators best practices section (python#141885)
  pythonGH-145667: Merge `GET_ITER` and `GET_YIELD_FROM_ITER` (pythonGH-146120)
  pythongh-146228: Better fork support in cached FastPath (python#146231)
  pythongh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h (pythongh-146229)
  pythongh-145980: Fix copy/paste mistake in binascii.c (python#146230)
  pythongh-146092: Raise MemoryError on allocation failure in _zoneinfo (python#146165)
  pythongh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (python#139396)
  pythongh-146196: Fix Undefined Behavior in _PyUnicodeWriter_WriteASCIIString() (python#146201)
  pythongh-143930: Reject leading dashes in webbrowser URLs
  pythongh-145916: Soft-deprecate ctypes.util.find_library (pythonGH-145919)
  pythongh-146205: Check the errno with != 0 in close impls in select module (python#146206)
  pythongh-146171: Fix nested AttributeError suggestions (python#146188)
  pythongh-146099: Optimize _GUARD_CODE_VERSION+IP via function version symbols (pythonGH-146101)
  pythongh-145980: Add support for alternative alphabets in the binascii module (pythonGH-145981)
  pythongh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format (python#145756)
  pythongh-145177: Add emscripten run --test, uses test args from config.toml (python#146160)
  ...
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@jonathandung @blurb-it @ljfp
pythongh-146153: Use frozendict in pure python fallback for `curses…
af98476
….has_key` (python#146154)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@aisk aisk aisk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use frozendict in Lib/curses/has_key.py

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jonathandung @vstinner @aisk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.