GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — gh-91279: Note ``SOURCE_DATE_EPOCH`` support in ``ZipFile.writestr()`` by Wulian233 · Pull Request #139396 · python/cpython Conversation
|
|
Ok, I'm proposing to remove that note from the 'A new type of interpreter' section, and I've also made the A |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
SOURCE_DATE_EPOCH support in ZipFile.writestr()
Finished, thank you! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
SOURCE_DATE_EPOCH support in ZipFile.writestr()SOURCE_DATE_EPOCH support in ZipFile.writestr()
SOURCE_DATE_EPOCH support in ZipFile.writestr()SOURCE_DATE_EPOCH support in ZipFile.writestr()
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but English is not my first language, so I'm not sure about the sentence :-)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
ping @vstinner @AA-Turner |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
I think the text can be improved here. The sentence lacks an object, but more importantly we don't say what has actually changed in the method's behaviour if SDE is set.
The sentence was completed.
|
thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
"All required checks pass" CI failed with a cryptic error message: So I updated the branch to attempt to fix the CI issue. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks @Wulian233 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…()` doc (pythonGH-139396) (cherry picked from commit 5ad738f) Co-authored-by: Wulian233 <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
|
GH-146222 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Merged, thanks for fixing the doc. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…r()` doc (GH-139396) (#146222) gh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (GH-139396) (cherry picked from commit 5ad738f) Co-authored-by: Wulian233 <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
* upstream/main: (1475 commits) Docs: replace all `datetime` imports with `import datetime as dt` (python#145640) pythongh-146153: Use `frozendict` in pure python fallback for `curses.has_key` (python#146154) pythongh-138234: clarify returncode behavior for subprocesses created with `shell=True` (python#138536) pythongh-140947: fix contextvars handling for server tasks in asyncio (python#141158) pythonGH-100108: Add async generators best practices section (python#141885) pythonGH-145667: Merge `GET_ITER` and `GET_YIELD_FROM_ITER` (pythonGH-146120) pythongh-146228: Better fork support in cached FastPath (python#146231) pythongh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h (pythongh-146229) pythongh-145980: Fix copy/paste mistake in binascii.c (python#146230) pythongh-146092: Raise MemoryError on allocation failure in _zoneinfo (python#146165) pythongh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (python#139396) pythongh-146196: Fix Undefined Behavior in _PyUnicodeWriter_WriteASCIIString() (python#146201) pythongh-143930: Reject leading dashes in webbrowser URLs pythongh-145916: Soft-deprecate ctypes.util.find_library (pythonGH-145919) pythongh-146205: Check the errno with != 0 in close impls in select module (python#146206) pythongh-146171: Fix nested AttributeError suggestions (python#146188) pythongh-146099: Optimize _GUARD_CODE_VERSION+IP via function version symbols (pythonGH-146101) pythongh-145980: Add support for alternative alphabets in the binascii module (pythonGH-145981) pythongh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format (python#145756) pythongh-145177: Add emscripten run --test, uses test args from config.toml (python#146160) ...
…()` doc (python#139396) Co-authored-by: Victor Stinner <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.