GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91279: Note ``SOURCE_DATE_EPOCH`` support in ``ZipFile.writestr()`` by Wulian233 · Pull Request #139396 · python/cpython

Conversation

@Wulian233

@Wulian233 Wulian233 commented Sep 28, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: ZipFile.writestr should respect SOURCE_DATE_EPOCH #91279

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Wulian233
pythongh-123299: Copyedit What's New in 3.14
89dea0b
@Wulian233
Wulian233 requested a review from AA-Turner as a code owner September 28, 2025 12:58
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 28, 2025
@github-project-automation github-project-automation Bot added this to Docs PRs Sep 28, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Sep 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 28, 2025
What's New in Python 3.14 (copyediting) #123299
Closed
AA-Turner

This comment was marked as outdated.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Sep 28, 2025
@bedevere-app

This comment was marked as outdated.

Sign in to view
@bedevere-app bedevere-app Bot added the awaiting changes label Sep 28, 2025
@Wulian233

This comment was marked as outdated.

Sign in to view
Wulian233 added 2 commits October 3, 2025 22:38
@Wulian233
Update 3.14.rst
fa92f66
@Wulian233
Update 3.14.rst
764aadf
@AA-Turner

AA-Turner commented Oct 3, 2025

Copy link
Copy Markdown
Member

Ok, I'm proposing to remove that note from the 'A new type of interpreter' section, and I've also made the envvar change in the 'New & improved modules' PR. Could you retarget this PR to just make the zipfile.rst change?

A

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Wulian233
Update 3.14.rst
28b6b6c
@Wulian233 Wulian233 changed the title gh-123299: Copyedit What's New in 3.14 gh-123299: Copyedit What's New in zipfile.rst Oct 3, 2025
@AA-Turner AA-Turner changed the title gh-123299: Copyedit What's New in zipfile.rst gh-123299: Note SOURCE_DATE_EPOCH support in ZipFile.writestr() Oct 3, 2025
@Wulian233
Update 3.14.rst
feec370
@Wulian233

Wulian233 commented Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

Could you retarget this PR to just make the zipfile.rst change?

Finished, thank you!

AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner
AA-Turner previously requested changes Oct 4, 2025
View reviewed changes
Comment thread Doc/library/zipfile.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner AA-Turner changed the title gh-123299: Note SOURCE_DATE_EPOCH support in ZipFile.writestr() Note SOURCE_DATE_EPOCH support in ZipFile.writestr() Oct 4, 2025
@AA-Turner AA-Turner added the skip issue label Oct 4, 2025
@Wulian233
Update zipfile.rst
c4ce0c6
@Wulian233
Wulian233 requested a review from AA-Turner October 11, 2025 12:07
@vstinner vstinner changed the title Note SOURCE_DATE_EPOCH support in ZipFile.writestr() gh-91279: Note SOURCE_DATE_EPOCH support in ZipFile.writestr() Nov 4, 2025
@vstinner vstinner removed the skip issue label Nov 4, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 4, 2025
ZipFile.writestr should respect SOURCE_DATE_EPOCH #91279
Closed
vstinner
vstinner reviewed Nov 4, 2025
View reviewed changes
Comment thread Doc/library/zipfile.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Wulian233 @vstinner
Update Doc/library/zipfile.rst
217b831
Co-authored-by: Victor Stinner <[email protected]>
vstinner
vstinner approved these changes Nov 4, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but English is not my first language, so I'm not sure about the sentence :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting changes labels Nov 4, 2025
@Wulian233
Merge branch 'main' into doc
98f4a10
@Wulian233

Wulian233 commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

ping @vstinner @AA-Turner

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label Mar 20, 2026
vstinner
vstinner reviewed Mar 20, 2026
View reviewed changes
Comment thread Doc/library/zipfile.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
Update Doc/library/zipfile.rst
afb06e9
@vstinner
vstinner dismissed AA-Turner’s stale review March 20, 2026 12:09

I think the text can be improved here. The sentence lacks an object, but more importantly we don't say what has actually changed in the method's behaviour if SDE is set.

The sentence was completed.

@vstinner
vstinner enabled auto-merge (squash) March 20, 2026 12:09
@Wulian233

Wulian233 commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
Merge branch 'main' into doc
ba69427
@vstinner

vstinner commented Mar 20, 2026

Copy link
Copy Markdown
Member

"All required checks pass" CI failed with a cryptic error message:

Error: The template is not valid. .github/workflows/build.yml (Line: 671, Col: 24): Error reading JToken from JsonReader. Path '', line 0, position 0.

So I updated the branch to attempt to fix the CI issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit 5ad738f into python:main Mar 20, 2026
28 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Mar 20, 2026
@miss-islington-app

miss-islington-app Bot commented Mar 20, 2026

Copy link
Copy Markdown

Thanks @Wulian233 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 20, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 20, 2026
@Wulian233 @vstinner @miss-islington
pythongh-91279: Note SOURCE_DATE_EPOCH support in `ZipFile.writestr…
9cec510
…()` doc (pythonGH-139396)

(cherry picked from commit 5ad738f)

Co-authored-by: Wulian233 <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 20, 2026

Copy link
Copy Markdown

GH-146222 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 20, 2026
@vstinner

vstinner commented Mar 20, 2026

Copy link
Copy Markdown
Member

Merged, thanks for fixing the doc.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added a commit that referenced this pull request Mar 20, 2026
@miss-islington @Wulian233 @vstinner
[3.14] gh-91279: Note SOURCE_DATE_EPOCH support in `ZipFile.writest…
8b447fb
…r()` doc (GH-139396) (#146222)

gh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (GH-139396)
(cherry picked from commit 5ad738f)

Co-authored-by: Wulian233 <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@Wulian233
Wulian233 deleted the doc branch March 20, 2026 22:02
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Mar 22, 2026
@CuriousLearner
Merge remote-tracking branch 'upstream/main' into fix-pythongh-138577
2691ad9
* upstream/main: (1475 commits)
  Docs: replace all `datetime` imports with `import datetime as dt` (python#145640)
  pythongh-146153: Use `frozendict` in pure python fallback for `curses.has_key` (python#146154)
  pythongh-138234: clarify returncode behavior for subprocesses created with `shell=True` (python#138536)
  pythongh-140947: fix contextvars handling for server tasks in asyncio  (python#141158)
  pythonGH-100108: Add async generators best practices section (python#141885)
  pythonGH-145667: Merge `GET_ITER` and `GET_YIELD_FROM_ITER` (pythonGH-146120)
  pythongh-146228: Better fork support in cached FastPath (python#146231)
  pythongh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h (pythongh-146229)
  pythongh-145980: Fix copy/paste mistake in binascii.c (python#146230)
  pythongh-146092: Raise MemoryError on allocation failure in _zoneinfo (python#146165)
  pythongh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (python#139396)
  pythongh-146196: Fix Undefined Behavior in _PyUnicodeWriter_WriteASCIIString() (python#146201)
  pythongh-143930: Reject leading dashes in webbrowser URLs
  pythongh-145916: Soft-deprecate ctypes.util.find_library (pythonGH-145919)
  pythongh-146205: Check the errno with != 0 in close impls in select module (python#146206)
  pythongh-146171: Fix nested AttributeError suggestions (python#146188)
  pythongh-146099: Optimize _GUARD_CODE_VERSION+IP via function version symbols (pythonGH-146101)
  pythongh-145980: Add support for alternative alphabets in the binascii module (pythonGH-145981)
  pythongh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format (python#145756)
  pythongh-145177: Add emscripten run --test, uses test args from config.toml (python#146160)
  ...
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@Wulian233 @vstinner @ljfp
pythongh-91279: Note SOURCE_DATE_EPOCH support in `ZipFile.writestr…
7cb649a
…()` doc (python#139396)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Wulian233 @AA-Turner @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.