GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-37342: Fix the incorrect nb_index's type in typeobj documentation by shihai1991 · Pull Request #14241 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Jun 19, 2019 •
edited by Mariatta
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It was listed as binaryfunc. It should be unaryfunc.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
update the nb_index's type
2a7982d
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jun 19, 2019
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 19, 2019
@bedevere-bot bedevere-bot added the awaiting review label Jun 19, 2019
@shihai1991 shihai1991 changed the title bpo-37342: update the nb_index's type bpo-37342: update the nb_index's type in doc Jun 19, 2019
@blurb-it
📜🤖 Added by blurb_it.
5f302d9
tirkarthi
tirkarthi approved these changes Jun 19, 2019
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's listed as unaryfunc ".. c:member:: unaryfunc PyNumberMethods.nb_index" in https://github.com/python/cpython/blob/master/Doc/c-api/typeobj.rst line 2069.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jun 19, 2019
@tirkarthi

tirkarthi commented Jun 19, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Please fix the CI error. I think the last column with "index" at https://travis-ci.org/python/cpython/jobs/547863960#L399 needs a space so that it's aligned with the rest of columns in the table as shown in the CI error log.

Edit: I think NEWS entry is not needed for this doc change
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991 added 2 commits June 20, 2019 09:42
@shihai1991
add a space in doc
0adc145
@shihai1991
Merge branch 'bpo_37342' of github.com:shihai1991/cpython into bpo_37342
5679055
@shihai1991

shihai1991 commented Jun 20, 2019

Copy link
Copy Markdown
Member Author

Please fix the CI error. I think the last column with "index" at https://travis-ci.org/python/cpython/jobs/547863960#L399 needs a space so that it's aligned with the rest of columns in the table as shown in the CI error log.

Edit: I think NEWS entry is not needed for this doc change

Good catch. Let us try it ;)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mariatta
Mariatta approved these changes Jun 20, 2019
View reviewed changes

@Mariatta Mariatta left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I confirmed it is unaryfunc in

cpython/Include/cpython/object.h

Line 136 in af41c56

unaryfunc nb_index;
. News file is not needed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 20, 2019
@Mariatta Mariatta added the skip news label Jun 20, 2019
@Mariatta
News file not needed.
81be50b
@Mariatta Mariatta changed the title bpo-37342: update the nb_index's type in doc bpo-37342: Fix the incorrect nb_index's type in typeobj documentation Jun 20, 2019
@Mariatta Mariatta added the 🤖 automerge label Jun 20, 2019
@miss-islington

miss-islington commented Jun 20, 2019

Copy link
Copy Markdown
Contributor

@shihai1991: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit bc5caf8 into python:master Jun 20, 2019
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 20, 2019
@Mariatta Mariatta added the needs backport to 3.8 label Jun 20, 2019
@miss-islington

miss-islington commented Jun 20, 2019

Copy link
Copy Markdown
Contributor

Thanks @shihai1991 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2019
@shihai1991 @miss-islington
bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (…
27c4726 
…pythonGH-14241)

It was listed as `binaryfunc`. It should be `unaryfunc`.
(cherry picked from commit bc5caf8)

Co-authored-by: Hai Shi <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 20, 2019

Copy link
Copy Markdown

GH-14254 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Jun 20, 2019
miss-islington added a commit that referenced this pull request Jun 20, 2019
@miss-islington @shihai1991
bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (…
6258c1f 
…GH-14241)

It was listed as `binaryfunc`. It should be `unaryfunc`.
(cherry picked from commit bc5caf8)

Co-authored-by: Hai Shi <[email protected]>
@tirkarthi

tirkarthi commented Jun 20, 2019

Copy link
Copy Markdown
Member

Thank you @shihai1991
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Jun 21, 2019
@CuriousLearner
Merge branch 'master' into fix-issue24255
7bf6445 
* master: (599 commits)
  Docs: Improved phrasing (pythonGH-14069)
  Remove redundant if check from optional argument function in argparse. (pythonGH-8766)
  bpo-37289: Add a test for if with ifexpr in the peephole optimiser to detect regressions (pythonGH-14127)
  Update What's New in Python 3.9 (pythonGH-14253)
  bpo-36511: Improve ARM32 buildbot scripts (pythonGH-14251)
  bpo-37151: remove _PyCFunction_FastCallDict (pythonGH-14269)
  Fix typo, 'widger' -> 'widget', in idlelib/tree.py (pythonGH-14263)
  Fix bpo number in News file. (pythonGH-14260)
  bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (pythonGH-14241)
  Update What's New in Python 3.8 (pythonGH-14239)
  bpo-36710: Use tstate in pylifecycle.c (pythonGH-14249)
  Add missing single quote in io.TextIOWrapper.reconfigure documentation (pythonGH-14246)
  bpo-36511: Add buildbot scripts and fix tests for Windows ARM32 buildbot (pythonGH-13454)
  bpo-37333: Ensure IncludeTkinter has a value (pythonGH-14240)
  bpo-37331: Clarify format of socket handler messages in the documentation. (pythonGH-14234)
  bpo-37258: Not a bug, but added a unit test and updated documentation. (pythonGH-14229)
  bpo-36710: Remove PyImport_Cleanup() function (pythonGH-14221)
  Fix name of '\0'. (pythonGH-14222)
  bpo-36710: Add tstate parameter in import.c (pythonGH-14218)
  Document typing.ForwardRef (pythonGH-14216)
  ...
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@shihai1991 @lisroach
bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (…
386a43d 
…pythonGH-14241)

It was listed as `binaryfunc`. It should be `unaryfunc`.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@shihai1991 @DinoV
bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (…
b1adac3 
…pythonGH-14241)

It was listed as `binaryfunc`. It should be `unaryfunc`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes
@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@shihai1991 @tirkarthi @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.