GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add missing single quote in io.TextIOWrapper.reconfigure documentation by Harmon758 · Pull Request #14246 · python/cpython

Conversation

@Harmon758

@Harmon758 Harmon758 commented Jun 19, 2019 •
edited by Mariatta
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add a missing single quote character in the documentation for io.TextIOWrapper.reconfigure.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Harmon758
Add missing single quote in io.TextIOWrapper.reconfigure documentation
1e8c88c
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 19, 2019
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 19, 2019
Mariatta
Mariatta approved these changes Jun 19, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 19, 2019
@Mariatta Mariatta added skip issue skip news needs backport to 3.7 labels Jun 19, 2019
@miss-islington
miss-islington merged commit 35068bd into python:master Jun 19, 2019
@miss-islington

miss-islington commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

Thanks @Harmon758 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Jun 19, 2019
@miss-islington

miss-islington commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jun 19, 2019
@bedevere-bot

bedevere-bot commented Jun 19, 2019

Copy link
Copy Markdown

GH-14247 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2019
@Harmon758 @miss-islington
Add missing single quote in io.TextIOWrapper.reconfigure documentation (
949288a
pythonGH-14246)

Add a missing single quote character in the documentation for `io.TextIOWrapper.reconfigure`.
(cherry picked from commit 35068bd)

Co-authored-by: Harmon <[email protected]>
@Mariatta

Mariatta commented Jun 19, 2019

Copy link
Copy Markdown
Member

Thanks for noticing and fixing it! 🌮

Harmon758 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Mariatta Mariatta added needs backport to 3.8 and removed needs backport to 3.8 labels Jun 19, 2019
@miss-islington

miss-islington commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

Thanks @Harmon758 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2019
@Harmon758 @miss-islington
Add missing single quote in io.TextIOWrapper.reconfigure documentation (
dc1332a
pythonGH-14246)

Add a missing single quote character in the documentation for `io.TextIOWrapper.reconfigure`.
(cherry picked from commit 35068bd)

Co-authored-by: Harmon <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 19, 2019

Copy link
Copy Markdown

GH-14248 is a backport of this pull request to the 3.8 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Jun 19, 2019
@Harmon758
Harmon758 deleted the textiowrapper.reconfigure-doc-fix branch June 19, 2019 21:02
miss-islington added a commit that referenced this pull request Jun 19, 2019
@miss-islington @Harmon758
Add missing single quote in io.TextIOWrapper.reconfigure documentation (
7b2a913
GH-14246)

Add a missing single quote character in the documentation for `io.TextIOWrapper.reconfigure`.
(cherry picked from commit 35068bd)

Co-authored-by: Harmon <[email protected]>
miss-islington added a commit that referenced this pull request Jun 19, 2019
@miss-islington @Harmon758
Add missing single quote in io.TextIOWrapper.reconfigure documentation (
444c78a
GH-14246)

Add a missing single quote character in the documentation for `io.TextIOWrapper.reconfigure`.
(cherry picked from commit 35068bd)

Co-authored-by: Harmon <[email protected]>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Jun 21, 2019
@CuriousLearner
Merge branch 'master' into fix-issue24255
7bf6445
* master: (599 commits)
  Docs: Improved phrasing (pythonGH-14069)
  Remove redundant if check from optional argument function in argparse. (pythonGH-8766)
  bpo-37289: Add a test for if with ifexpr in the peephole optimiser to detect regressions (pythonGH-14127)
  Update What's New in Python 3.9 (pythonGH-14253)
  bpo-36511: Improve ARM32 buildbot scripts (pythonGH-14251)
  bpo-37151: remove _PyCFunction_FastCallDict (pythonGH-14269)
  Fix typo, 'widger' -> 'widget', in idlelib/tree.py (pythonGH-14263)
  Fix bpo number in News file. (pythonGH-14260)
  bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (pythonGH-14241)
  Update What's New in Python 3.8 (pythonGH-14239)
  bpo-36710: Use tstate in pylifecycle.c (pythonGH-14249)
  Add missing single quote in io.TextIOWrapper.reconfigure documentation (pythonGH-14246)
  bpo-36511: Add buildbot scripts and fix tests for Windows ARM32 buildbot (pythonGH-13454)
  bpo-37333: Ensure IncludeTkinter has a value (pythonGH-14240)
  bpo-37331: Clarify format of socket handler messages in the documentation. (pythonGH-14234)
  bpo-37258: Not a bug, but added a unit test and updated documentation. (pythonGH-14229)
  bpo-36710: Remove PyImport_Cleanup() function (pythonGH-14221)
  Fix name of '\0'. (pythonGH-14222)
  bpo-36710: Add tstate parameter in import.c (pythonGH-14218)
  Document typing.ForwardRef (pythonGH-14216)
  ...
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@Harmon758 @lisroach
Add missing single quote in io.TextIOWrapper.reconfigure documentation (
15ab195
pythonGH-14246)

Add a missing single quote character in the documentation for `io.TextIOWrapper.reconfigure`.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@Harmon758 @DinoV
Add missing single quote in io.TextIOWrapper.reconfigure documentation (
d2e3acf
pythonGH-14246)

Add a missing single quote character in the documentation for `io.TextIOWrapper.reconfigure`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Harmon758 @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.