GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146261: Fix bug in `_Py_uop_sym_set_func_version` by Sacul0457 · Pull Request #146291 · python/cpython

Conversation

@Sacul0457

@Sacul0457 Sacul0457 commented Mar 22, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes a bug in _Py_uop_sym_set_func_version where it should return false instead of true when we hit the bottom.

  • Issue: JIT: Optimization in _CHECK_FUNCTION_VERSION is wrong #146261

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Sacul0457
Restore Optimization and revert tests
b81201f
@Sacul0457
Sacul0457 requested review from Fidget-Spinner, markshannon, savannahostrowski and tomasr8 as code owners March 22, 2026 14:45
@bedevere-app bedevere-app Bot added the awaiting review label Mar 22, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 22, 2026
JIT: Optimization in _CHECK_FUNCTION_VERSION is wrong #146261
Closed
Fidget-Spinner
Fidget-Spinner reviewed Mar 22, 2026
View reviewed changes
Comment thread Python/optimizer_symbols.c
case JIT_SYM_TRUTHINESS_TAG:
sym_set_bottom(ctx, sym);
return true;
return false;

@Fidget-Spinner Fidget-Spinner Mar 22, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, can you just reduce the PR to just this line? I'm really sorry for taking up your time on this Sacul.

After staring at this more, I realised the original function watcher idea works, but needs a lot more work. I think this might be too complicated for a contributor to take, so I'll take over. Thanks for opening the issue again and for spotting this mistake of mine!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sacul0457 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@Sacul0457 Sacul0457 Mar 22, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, glad to be able to help where I can :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Sacul0457
revert and reduce change
8a08593
@Sacul0457 Sacul0457 changed the title gh-146261: Restore Optimization of _CHECK_FUNCTION_VERSION in the JIT gh-146261: Fix bug in _Py_uop_sym_set_func_version Mar 22, 2026
Fidget-Spinner
Fidget-Spinner approved these changes Mar 22, 2026
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sacul0457 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 22, 2026
@Fidget-Spinner Fidget-Spinner added the skip news label Mar 22, 2026
@Fidget-Spinner
Fidget-Spinner merged commit 1ceb1fb into python:main Mar 22, 2026
72 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 22, 2026
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Mar 23, 2026
@CuriousLearner
Merge branch 'main' of github.com:python/cpython into fix-pythongh-13…
3e05fa3 
…8577

* 'main' of github.com:python/cpython:
  pythongh-146197: Run -m test.pythoninfo on the Emscripten CI (python#146332)
  pythongh-146325: Use `test.support.requires_fork` in test_fastpath_cache_cleared_in_forked_child (python#146330)
  pythongh-146197: Add Emscripten to CI (python#146198)
  pythongh-143387: Raise an exception instead of returning None when metadata file is missing. (python#146234)
  pythongh-108907: ctypes: Document _type_ codes (pythonGH-145837)
  pythongh-146175: Soft-deprecate outdated macros; convert internal usage (pythonGH-146178)
  pythongh-146056: Rework ref counting in treebuilder_handle_end() (python#146167)
  Add a warning about untrusted input to `configparser` docs (python#146276)
  pythongh-145264: Do not ignore excess Base64 data after the first padded quad (pythonGH-145267)
  pythongh-146308: Fix error handling issues in _remote_debugging module (python#146309)
  pythongh-146192: Add base32 support to binascii (pythonGH-146193)
  pythongh-135953: Properly obtain main thread identifier in Gecko Collector (python#146045)
  pythongh-143414: Implement unique reference tracking for JIT, optimize unpacking of such tuples (pythonGH-144300)
  pythongh-146261: Fix bug in `_Py_uop_sym_set_func_version` (pythonGH-146291)
  pythongh-145144: Add more tests for UserList, UserDict, etc (pythonGH-145145)
  pythongh-143959: Fix test_datetime if _datetime is unavailable (pythonGH-145248)
  pythongh-146245: Fix reference and buffer leaks via audit hook in socket module (pythonGH-146248)
  pythongh-140049: Colorize exception notes in `traceback.py` (python#140051)
  Update docs for pythongh-146056 (pythonGH-146213)
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@Sacul0457 @ljfp
pythongh-146261: Fix bug in _Py_uop_sym_set_func_version (pythonGH-…
76c5f26 
…146291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Sacul0457 @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.