GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146325: Use `test.support.requires_fork` in test_fastpath_cache_cleared_in_forked_child by hoodmane · Pull Request #146330 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Mar 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Tests that need fork have to call test.support.requires_fork() to rule out platforms that have os.fork() but where it should not be called

  • Issue: WASM Emscripten 3.x fails with: Cannot find module 'ws' #146325

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@hoodmane
hoodmane requested review from FFY00, jaraco and warsaw as code owners March 23, 2026 13:11
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Mar 23, 2026
@hoodmane
hoodmane requested a review from vstinner March 23, 2026 13:11
@bedevere-app bedevere-app Bot mentioned this pull request Mar 23, 2026
WASM Emscripten 3.x fails with: Cannot find module 'ws' #146325
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Mar 23, 2026
@hoodmane
pythongh-146325: Use test.support.requires_fork in test_fastpath_ca…
cd1ccd4
…che_cleared_in_forked_child

Tests that need fork have to call test.support.requires_fork() to rule out
platforms that have `os.fork()` but where it should not be called
@hoodmane
hoodmane force-pushed the test.support.requires_fork branch from 135067a to cd1ccd4 Compare March 23, 2026 13:12
@hoodmane hoodmane added the skip news label Mar 23, 2026
@hoodmane hoodmane mentioned this pull request Mar 23, 2026
gh-146197: Add Emscripten to CI #146198
Merged
@hugovk
hugovk merged commit 0c83e8b into python:main Mar 23, 2026
47 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Mar 23, 2026

Copy link
Copy Markdown
Member

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Mar 23, 2026
@hoodmane
hoodmane deleted the test.support.requires_fork branch March 23, 2026 14:58
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Mar 23, 2026
@CuriousLearner
Merge branch 'main' of github.com:python/cpython into fix-pythongh-13…
3e05fa3
…8577

* 'main' of github.com:python/cpython:
  pythongh-146197: Run -m test.pythoninfo on the Emscripten CI (python#146332)
  pythongh-146325: Use `test.support.requires_fork` in test_fastpath_cache_cleared_in_forked_child (python#146330)
  pythongh-146197: Add Emscripten to CI (python#146198)
  pythongh-143387: Raise an exception instead of returning None when metadata file is missing. (python#146234)
  pythongh-108907: ctypes: Document _type_ codes (pythonGH-145837)
  pythongh-146175: Soft-deprecate outdated macros; convert internal usage (pythonGH-146178)
  pythongh-146056: Rework ref counting in treebuilder_handle_end() (python#146167)
  Add a warning about untrusted input to `configparser` docs (python#146276)
  pythongh-145264: Do not ignore excess Base64 data after the first padded quad (pythonGH-145267)
  pythongh-146308: Fix error handling issues in _remote_debugging module (python#146309)
  pythongh-146192: Add base32 support to binascii (pythonGH-146193)
  pythongh-135953: Properly obtain main thread identifier in Gecko Collector (python#146045)
  pythongh-143414: Implement unique reference tracking for JIT, optimize unpacking of such tuples (pythonGH-144300)
  pythongh-146261: Fix bug in `_Py_uop_sym_set_func_version` (pythonGH-146291)
  pythongh-145144: Add more tests for UserList, UserDict, etc (pythonGH-145145)
  pythongh-143959: Fix test_datetime if _datetime is unavailable (pythonGH-145248)
  pythongh-146245: Fix reference and buffer leaks via audit hook in socket module (pythonGH-146248)
  pythongh-140049: Colorize exception notes in `traceback.py` (python#140051)
  Update docs for pythongh-146056 (pythonGH-146213)
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@hoodmane @ljfp
pythongh-146325: Use test.support.requires_fork in test_fastpath_ca…
8d60b03
…che_cleared_in_forked_child (python#146330)
@jaraco jaraco mentioned this pull request Oct 22, 2026
Backport gh-146325: guard the fork test with requires_fork python/importlib_metadata#551
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hoodmane @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.