GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146197: Run -m test.pythoninfo on the Emscripten CI by vstinner · Pull Request #146332 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add CI job for Emscripten #146197

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-146197: Run -m test.pythoninfo on the Emscripten CI
d45603d
@vstinner vstinner added the skip news label Mar 23, 2026
@vstinner
vstinner requested review from AA-Turner, ezio-melotti, hugovk and webknjaz as code owners March 23, 2026 16:36
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 23, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 23, 2026
Add CI job for Emscripten #146197
Closed
@vstinner
Fix typo in config.toml (add "-args" suffix)
3ca1048
hoodmane
hoodmane approved these changes Mar 23, 2026
View reviewed changes

@hoodmane hoodmane left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vstinner. Do you want to add this to the buildbot as well?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hoodmane hoodmane added OS-emscripten needs backport to 3.14 bugs and security fixes labels Mar 23, 2026
hugovk
hugovk approved these changes Mar 23, 2026
View reviewed changes
Comment thread Platforms/emscripten/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Platforms/emscripten/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Mar 23, 2026

Copy link
Copy Markdown
Member Author

This change adds "Display build info" to the CI. Examples from this CI run on this PR:

  • platform.platform: Emscripten-4.0.12
  • sys._emscripten_info: Node.js/24

I'm surprised that sys._emscripten_info only logs Node.js major version. The code uses info = "Node.js ".concat(process.version); in Python/sysmodule.c, so I expected "Node.js xxx", but we get "Node.js/xxx", where does "/" come from? :-)

Log examples:

os.cpu_count: 1
os.environ[GITHUB_ACTIONS]: true
os.uname: posix.uname_result(sysname='Emscripten', nodename='emscripten', release='4.0.12', version='#1', machine='wasm32')

platform.freedesktop_os_release[NAME]: Ubuntu
platform.freedesktop_os_release[VERSION]: 24.04.3 LTS (Noble Numbat)

platform.libc_ver: emscripten 4.0.12
platform.platform: Emscripten-4.0.12-wasm32-32bit

support.has_fork_support: False
support.has_socket_support: False
support.has_subprocess_support: False
support.is_emscripten: True
support.is_wasi: False
support.is_wasm32: True

sys._emscripten_info: sys._emscripten_info(emscripten_version=(4, 0, 12), runtime='Node.js/24', pthreads=False, shared_memory=False)
sys.executable: /home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/python.sh
sys.filesystem_encoding: utf-8/surrogateescape
sys.maxsize: 2147483647

sys.version: 3.15.0a7+ (remotes/pull/146332/merge-dirty:39b0363, Mar 23 2026, 16:44:40) [Clang 22.0.0git (https:/github.com/llvm/llvm-project 7f93487862d98bf1c168babba8

sysconfig[MULTIARCH]: wasm32-emscripten
sysconfig[SOABI]: cpython-315-wasm32-emscripten
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 23, 2026
@vstinner @hugovk
Apply suggestions from code review
b56a494
Co-authored-by: Hugo van Kemenade <[email protected]>
@vstinner

vstinner commented Mar 23, 2026

Copy link
Copy Markdown
Member Author

Thanks @vstinner. Do you want to add this to the buildbot as well?

Yes, I would like to add this step to the buildbot as well. I will backport this change to 3.14, and then add a --pythoninfo step to the buildbot.

hoodmane reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner enabled auto-merge (squash) March 23, 2026 17:08
@hoodmane

hoodmane commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

The code uses info = "Node.js ".concat(process.version); in Python/sysmodule.c, so I expected "Node.js xxx", but we get "Node.js/xxx", where does "/" come from? :-)

The other branch:

$ node -e 'console.log(navigator.userAgent)'
Node.js/24
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hoodmane

hoodmane commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

I'll make a separate PR improving this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit a57209e into python:main Mar 23, 2026
27 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner deleted the emscripten_pythoninfo branch March 23, 2026 17:23
@miss-islington-app

miss-islington-app Bot commented Mar 23, 2026

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 23, 2026
@miss-islington-app

miss-islington-app Bot commented Mar 23, 2026

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a57209eb98943f4d8edbf56a55e98ec112e00e39 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app miss-islington-app Bot assigned vstinner Mar 23, 2026
@vstinner

vstinner commented Mar 23, 2026

Copy link
Copy Markdown
Member Author

The other branch:

Oh ok, thanks :-)

$ node -e 'console.log(navigator.userAgent)'
Node.js/24

Is there a way to get the full Node.js version? A version string like v22.22.0.

I'll make a separate PR improving this.

Improving sys._emscripten_info? Nice!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added a commit to vstinner/cpython that referenced this pull request Mar 23, 2026
@vstinner @hugovk
pythongh-146197: Run -m test.pythoninfo on the Emscripten CI (python#…
5ce7887
…146332)

Co-authored-by: Hugo van Kemenade <[email protected]>
(cherry picked from commit a57209e)
@bedevere-app

bedevere-app Bot commented Mar 23, 2026

Copy link
Copy Markdown

GH-146336 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 23, 2026
@vstinner

vstinner commented Mar 23, 2026

Copy link
Copy Markdown
Member Author

I merged my PR. Thanks for your fast reviews!

hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added a commit that referenced this pull request Mar 23, 2026
@vstinner @hugovk
[3.14] gh-146197: Run -m test.pythoninfo on the Emscripten CI (#146332)…
c6dd764
… (#146336)

gh-146197: Run -m test.pythoninfo on the Emscripten CI (#146332)


(cherry picked from commit a57209e)

Co-authored-by: Hugo van Kemenade <[email protected]>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Mar 23, 2026
@CuriousLearner
Merge branch 'main' of github.com:python/cpython into fix-pythongh-13…
3e05fa3
…8577

* 'main' of github.com:python/cpython:
  pythongh-146197: Run -m test.pythoninfo on the Emscripten CI (python#146332)
  pythongh-146325: Use `test.support.requires_fork` in test_fastpath_cache_cleared_in_forked_child (python#146330)
  pythongh-146197: Add Emscripten to CI (python#146198)
  pythongh-143387: Raise an exception instead of returning None when metadata file is missing. (python#146234)
  pythongh-108907: ctypes: Document _type_ codes (pythonGH-145837)
  pythongh-146175: Soft-deprecate outdated macros; convert internal usage (pythonGH-146178)
  pythongh-146056: Rework ref counting in treebuilder_handle_end() (python#146167)
  Add a warning about untrusted input to `configparser` docs (python#146276)
  pythongh-145264: Do not ignore excess Base64 data after the first padded quad (pythonGH-145267)
  pythongh-146308: Fix error handling issues in _remote_debugging module (python#146309)
  pythongh-146192: Add base32 support to binascii (pythonGH-146193)
  pythongh-135953: Properly obtain main thread identifier in Gecko Collector (python#146045)
  pythongh-143414: Implement unique reference tracking for JIT, optimize unpacking of such tuples (pythonGH-144300)
  pythongh-146261: Fix bug in `_Py_uop_sym_set_func_version` (pythonGH-146291)
  pythongh-145144: Add more tests for UserList, UserDict, etc (pythonGH-145145)
  pythongh-143959: Fix test_datetime if _datetime is unavailable (pythonGH-145248)
  pythongh-146245: Fix reference and buffer leaks via audit hook in socket module (pythonGH-146248)
  pythongh-140049: Colorize exception notes in `traceback.py` (python#140051)
  Update docs for pythongh-146056 (pythonGH-146213)
@vstinner

vstinner commented Mar 23, 2026

Copy link
Copy Markdown
Member Author

Here is the PR to run pythoninfo on buildbots: python/buildmaster-config#690.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@vstinner @hugovk @ljfp
pythongh-146197: Run -m test.pythoninfo on the Emscripten CI (python#…
ded39cf
…146332)

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@hoodmane hoodmane hoodmane approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti
@AA-Turner AA-Turner Awaiting requested review from AA-Turner
@webknjaz webknjaz Awaiting requested review from webknjaz

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @hoodmane @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.