GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-146615: Fix format specifiers in extension modules by sunmy2019 · Pull Request #146617 · python/cpython

Conversation

sunmy2019 commented Mar 30, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Some Unicode format specifiers are incorrect #146615

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix format specifiers in error messages across multiple modules

96fcf41

bedevere-app Bot mentioned this pull request

Mar 30, 2026

Some Unicode format specifiers are incorrect #146615

Closed

sunmy2019 mentioned this pull request

Mar 30, 2026

gh-146615: Fix format specifiers in error messages for consistency and correctness #146616

Closed

emmatyping reviewed

Mar 30, 2026

View reviewed changes

Comment thread

Modules/_zstd/compressor.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka reviewed

Mar 30, 2026

View reviewed changes

Comment thread

Modules/_ssl.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_ssl.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_ssl.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

picnixz added the skip news label

Mar 30, 2026

picnixz commented Mar 30, 2026

Copy link

Copy Markdown

Member

See #146620 (comment) for the rationale of skip news

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sunmy2019 added 2 commits

March 30, 2026 22:43


          prefer another PR to fix

36774be


          resolve comments

f16838e

serhiy-storchaka approved these changes

Mar 30, 2026

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added the awaiting merge label

Mar 30, 2026

serhiy-storchaka added needs backport to 3.13

only security fixes

needs backport to 3.14 bugs and security fixes labels

Mar 30, 2026

serhiy-storchaka marked this pull request as ready for review

March 30, 2026 17:10

serhiy-storchaka requested review from 1st1, StanFromIreland, asvetlov, gpshead, kumaraditya303, pablogsal, pganssle, picnixz and willingc as code owners

March 30, 2026 17:10

bedevere-app Bot added awaiting review and removed awaiting merge labels

Mar 30, 2026

StanFromIreland approved these changes

Mar 30, 2026

View reviewed changes

StanFromIreland left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for _zoneinfo.c

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Mar 30, 2026

kumaraditya303 approved these changes

Mar 30, 2026

View reviewed changes

kumaraditya303 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asyncio changes LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka merged commit 1c396e1 into python:main

Mar 31, 2026

65 checks passed

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Mar 31, 2026

Copy link

Copy Markdown

Thanks @sunmy2019 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Mar 31, 2026

miss-islington-app Bot commented Mar 31, 2026

Copy link

Copy Markdown

Sorry, @sunmy2019 and @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1c396e18218daa723b425af0781c5e762d7717c2 3.14

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot assigned serhiy-storchaka

Mar 31, 2026

miss-islington-app Bot commented Mar 31, 2026

Copy link

Copy Markdown

Sorry, @sunmy2019 and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1c396e18218daa723b425af0781c5e762d7717c2 3.13

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request

Mar 31, 2026


          [3.14] pythongh-146615: Fix format specifiers in extension modules (p…

bdb9d8a

…ythonGH-146617)

(cherry picked from commit 1c396e1)

Co-authored-by: sunmy2019 <[email protected]>

bedevere-app Bot commented Mar 31, 2026

Copy link

Copy Markdown

GH-146652 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Mar 31, 2026

serhiy-storchaka removed the needs backport to 3.13 only security fixes label

Mar 31, 2026

serhiy-storchaka removed their assignment

Mar 31, 2026

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request

Mar 31, 2026


          [3.14] pythongh-146615: Fix format specifiers in extension modules (p…

e3e88c7

…ythonGH-146617)

(cherry picked from commit 1c396e1)

Co-authored-by: sunmy2019 <[email protected]>

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request

Mar 31, 2026


          [3.14] pythongh-146615: Fix format specifiers in extension modules (p…

de63d17

…ythonGH-146617)

(cherry picked from commit 1c396e1)

Co-authored-by: sunmy2019 <[email protected]>

serhiy-storchaka added a commit that referenced this pull request

Mar 31, 2026


          [3.14] gh-146615: Fix format specifiers in extension modules (GH-146617…

58c7259

…) (GH-146652)

(cherry picked from commit 1c396e1)

Co-authored-by: sunmy2019 <[email protected]>

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Mar 31, 2026


          [3.13] pythongh-146615: Fix format specifiers in extension modules (p…

6e5c933

…ythonGH-146617) (pythonGH-146652)

(cherry picked from commit 1c396e1)
(cherry picked from commit 58c7259)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: sunmy2019 <[email protected]>

maurycy added a commit to maurycy/cpython that referenced this pull request

Mar 31, 2026


          Merge branch 'main' into tachyon-ndjson-kolektor

9836ffa

* main:
  pythongh-145458: use `self.skip_idle` consistently in the tachyon profiler (python#145459)
  pythongh-146615: Fix format specifiers in Objects/ directory (pythonGH-146620)
  pythongh-146615: Fix format specifiers in Python/ directory (pythonGH-146619)
  pythongh-146615: Fix format specifiers in test cextensions (pythonGH-146618)
  pythongh-146615: Fix format specifiers in extension modules (pythonGH-146617)
  pythongh-146615: Fix crash in __get__() for METH_METHOD descriptors with invalid type argument (pythonGH-146634)
  pythongh-146376: Reduce timeout in Emscripten GHA workflow (python#146378)
  pythongh-146442: Fix various bugs in compiler pipeline (python#146443)
  pythongh-146238: Support half-floats in the array module (python#146242)
  pythongh-145056: Add support for merging collections.UserDict and frozendict (pythonGH-146465)
  pythongh-145056: Fix merging of collections.OrderedDict and frozendict (pythonGH-146466)
  pythongh-139633: Run netrc file permission check only once per parse (pythonGH-139634)

serhiy-storchaka added a commit that referenced this pull request

Mar 31, 2026


          [3.13] gh-146615: Fix format specifiers in extension modules (GH-146617…

fc1c644

…) (GH-146652) (GH-146658)

(cherry picked from commit 1c396e1)
(cherry picked from commit 58c7259)

Co-authored-by: sunmy2019 <[email protected]>

bedevere-app Bot commented Mar 31, 2026

Copy link

Copy Markdown

GH-147704 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner pushed a commit that referenced this pull request

Apr 1, 2026


          [3.14] gh-146615: Fix format specifiers in extension modules (GH-146617…

b406d85

…) (#147704)

Fix format specifier in parse_task_name() for long result.

pablogsal mentioned this pull request

Apr 4, 2026

gh-130273: Fix traceback color output with unicode characters #142529

Merged

clin1234 pushed a commit to clin1234/cpython that referenced this pull request

Apr 16, 2026


          pythongh-146615: Fix format specifiers in extension modules (pythonGH…

de13cd4

…-146617)

ljfp pushed a commit to ljfp/cpython that referenced this pull request

Apr 25, 2026


          pythongh-146615: Fix format specifiers in extension modules (pythonGH…

b2573b8

…-146617)

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

emmatyping

emmatyping left review comments

kumaraditya303

kumaraditya303 approved these changes

StanFromIreland

StanFromIreland approved these changes

pganssle

Awaiting requested review from pganssle

pganssle is a code owner

gpshead

Awaiting requested review from gpshead

gpshead is a code owner

picnixz

Awaiting requested review from picnixz

picnixz is a code owner

1st1

Awaiting requested review from 1st1

1st1 is a code owner

asvetlov

Awaiting requested review from asvetlov

asvetlov is a code owner

willingc

Awaiting requested review from willingc

willingc is a code owner

pablogsal

Awaiting requested review from pablogsal

pablogsal is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sunmy2019 commented Mar 30, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz commented Mar 30, 2026

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

kumaraditya303 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Mar 31, 2026

Uh oh!

miss-islington-app Bot commented Mar 31, 2026

Uh oh!

miss-islington-app Bot commented Mar 31, 2026

Uh oh!

bedevere-app Bot commented Mar 31, 2026

Uh oh!

bedevere-app Bot commented Mar 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sunmy2019 commented Mar 30, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.