GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-39342: Expose X509_V_FLAG_ALLOW_PROXY_CERTS in ssl module by chrisburr · Pull Request #18011 · python/cpython

Conversation

@chrisburr

@chrisburr chrisburr commented Jan 15, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Exposes the X509_V_FLAG_ALLOW_PROXY_CERTS constant as ssl.VERIFY_ALLOW_PROXY_CERTS to allow for proxy certificate validation as described in: https://www.openssl.org/docs/man1.1.1/man7/proxy-certificates.html

https://bugs.python.org/issue39342

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chrisburr
chrisburr requested a review from tiran as a code owner January 15, 2020 10:18
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 15, 2020
@bedevere-bot bedevere-bot added the awaiting review label Jan 15, 2020
@tiran

tiran commented Jan 15, 2020

Copy link
Copy Markdown
Member

Thanks, your patch looks good to me.

I cannot approve the PR at the moment. GH request fails with Personal token required for this feature. I'll look into the matter later.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chrisburr

chrisburr commented Apr 1, 2020

Copy link
Copy Markdown
Contributor Author

@tiran Sorry to pester you, but could you take a look when you get a chance?

I'm fairly sure Travis CI failed due to a network glitch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chaen

chaen commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

I too would like to see this PR be merged. Is there anything I can do to help ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chrisburr
chrisburr force-pushed the fix-issue-39342 branch from f7b75c1 to 404c317 Compare October 5, 2020 12:50
@chrisburr
chrisburr force-pushed the fix-issue-39342 branch from 404c317 to 53747c1 Compare December 9, 2020 13:59
@chrisburr
chrisburr requested review from 1st1, abalkin, asvetlov, berkerpeksag, brettcannon, encukou, ericsnowcurrently, ericvsmith, ethanfurman, ezio-melotti, gpshead, gvanrossum, ilevkivskyi, lysnikolaou, markshannon, methane, ncoghlan, pablogsal, pganssle, rhettinger, terryjreedy and vsajip as code owners December 9, 2020 13:59
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 9, 2020
@chrisburr
chrisburr force-pushed the fix-issue-39342 branch from c9a602d to f806eaf Compare December 9, 2020 14:02
@chrisburr
bpo-39342: Expose X509_V_FLAG_ALLOW_PROXY_CERTS as ssl.VERIFY_ALLOW_P…
89c354c 
…ROXY_CERTS
@chrisburr
chrisburr force-pushed the fix-issue-39342 branch from f806eaf to 89c354c Compare December 9, 2020 14:04
@chrisburr
bpo-39342: Update added in version to 3.10
065c1cc
@markshannon
markshannon removed request for a team, ethanfurman, ezio-melotti, gvanrossum, ilevkivskyi, lysnikolaou, markshannon, pablogsal, rhettinger and terryjreedy December 9, 2020 15:08
@terryjreedy

terryjreedy commented Dec 9, 2020

Copy link
Copy Markdown
Member

The bogus review requests and CLA report are likely a result of force-pushing. This should not be be used when git merge origin/master is all that is needed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon
brettcannon removed their request for review December 9, 2020 17:37
@chrisburr

chrisburr commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

I accidentally rebased on my fork's master instead of python/cpython which seems to have triggered GitHub to automatically request a review from many people. Sorry for the trouble.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsajip
vsajip removed their request for review December 14, 2020 10:19
@methane
methane removed their request for review March 18, 2021 07:17
tiran
tiran approved these changes Mar 18, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 18, 2021
@tiran tiran added the 🤖 automerge label Mar 18, 2021
@miss-islington
miss-islington merged commit e0b4aa0 into python:master Mar 18, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 18, 2021
@chrisburr
chrisburr deleted the fix-issue-39342 branch March 18, 2021 09:15
jab added a commit to jab/cpython that referenced this pull request Mar 20, 2021
@jab
Merge branch 'master' into justin39/aiter-c
97d06e5 
* master: (129 commits)
  bpo-43452: Micro-optimizations to PyType_Lookup (pythonGH-24804)
  bpo-43517: Fix false positive in detection of circular imports (python#24895)
  bpo-43494: Make some minor changes to lnotab notes (pythonGH-24861)
  Mention that code.co_lnotab is deprecated in what's new for 3.10. (python#24902)
  bpo-43244: Remove symtable.h header file (pythonGH-24910)
  bpo-43466: Add --with-openssl-rpath configure option (pythonGH-24820)
  Fix a typo in c-analyzer (pythonGH-24468)
  bpo-41561: Add workaround for Ubuntu's custom security level (pythonGH-24915)
  bpo-43521: Allow ast.unparse with empty sets and NaN (pythonGH-24897)
  bpo-43244: Remove the PyAST_Validate() function (pythonGH-24911)
  bpo-43541: Fix PyEval_EvalCodeEx() regression (pythonGH-24918)
  bpo-43244: Fix test_peg_generators on Windows (pythonGH-24913)
  bpo-39342: Expose X509_V_FLAG_ALLOW_PROXY_CERTS in ssl module (pythonGH-18011)
  bpo-43244: Fix test_peg_generator for PyAST_Validate() (pythonGH-24912)
  bpo-42128: Add 'missing :' syntax error message to match statements (pythonGH-24733)
  bpo-43244: Add pycore_ast.h header file (pythonGH-24908)
  bpo-43244: Rename pycore_ast.h to pycore_ast_state.h (pythonGH-24907)
  Remove unnecessary imports in the grammar parser (pythonGH-24904)
  bpo-35883: Py_DecodeLocale() escapes invalid Unicode characters (pythonGH-24843)
  Add PEP 626 to what's new in 3.10. (python#24892)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1
@abalkin abalkin Awaiting requested review from abalkin
@asvetlov asvetlov Awaiting requested review from asvetlov
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@ericvsmith ericvsmith Awaiting requested review from ericvsmith
@gpshead gpshead Awaiting requested review from gpshead
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@pganssle pganssle Awaiting requested review from pganssle
@warsaw warsaw Awaiting requested review from warsaw
1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@chrisburr @tiran @chaen @the-knights-who-say-ni @terryjreedy @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.