GeezerVison

See also PR #24910 "Remove symtable.h header file".

@pablogsal @lysnikolaou @gvanrossum @isidentical: Would you be ok to remove the PyAST_Validate() function from the public C API?

I failed to find any user of it. A GitHub code search for PyAST_Validate (in C code) only lists copies of the CPython code base (ast.h file): I checked the first 100 results (10 pages).

I don't think that the low-level AST C API must be used outside CPython. My plan is to move the whole Python-ast.h header file to the internal C API as well.

In Python, you can validate an AST using compile() which calls PyAST_obj2mod(), PyAST_Validate() and PyAST_CompileObject() internally.

If you have doubt and prefer to stil expose the function, we can export it but I would prefer to still rename it.

Note: PyAST_Validate() is excluded from the limited C API (PEP 384).

@pablogsal @lysnikolaou @gvanrossum @isidentical: Would you be ok to remove the PyAST_Validate() function from the public C API?

Yes, the ast symbols are not exposed anymore so this function cannot be used without magical cast to void*:

In 3.8:

❯ nm ./python | grep _Py_While
00000000002384c0 t _Py_While

in 3.9+:

❯ nm ./python | grep _Py_While
(no output)

test_peg_generator fails. I'm working on a fix: PR #24912 defines also Py_BUILD_CORE macro in test_peg_generator.

I searched PyAST_Validate() in the top 4000 PyPI packages: it is not used.

A single package contains PyAST_Validate(): graphene-federation 0.1.0. But its tarball contains a full virtual environment which contains a Python binary (!) which contains the "PyAST_Validate" string. It can be ignored ;-)

Pablo approved my PR. I failed to find usage of this function in GitHub code search and in the PyPI top 4000 packages. So I was confident enough to merge this PR.

Thanks for the review Pablo.