GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43494: Make some minor changes to lnotab notes by smontanaro · Pull Request #24861 · python/cpython

Conversation

@smontanaro

@smontanaro smontanaro commented Mar 14, 2021 •
edited by terryjreedy
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This cleanup makes no substantive changes.

https://bugs.python.org/issue43494

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@smontanaro
Minor edits to new line number format description
be4066d 
I need to understand this for my VM changes, so started reading. I initially wanted to just correct a typo (first change), but got a little carried away and edited a bit more.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 14, 2021
@bedevere-bot bedevere-bot added the awaiting review label Mar 14, 2021
@rhettinger rhettinger added the skip news label Mar 15, 2021
@terryjreedy terryjreedy changed the title bpo-43494: Minor edits to new line number format description bpo-43494: Edit lnotab notes Mar 19, 2021
@terryjreedy terryjreedy changed the title bpo-43494: Edit lnotab notes bpo-43494: Make a few grammar changes to lnotab notes Mar 19, 2021
@terryjreedy terryjreedy changed the title bpo-43494: Make a few grammar changes to lnotab notes bpo-43494: Make some minor changes to lnotab notes Mar 19, 2021
@terryjreedy terryjreedy added needs backport to 3.8 docs Documentation in the Doc dir labels Mar 19, 2021
@terryjreedy
terryjreedy merged commit 7cb033c into python:master Mar 19, 2021
@miss-islington

miss-islington commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

Thanks @smontanaro for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Mar 19, 2021
@miss-islington

miss-islington commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

Sorry, @smontanaro and @terryjreedy, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7cb033c423b65def1632d6c3c747111543b342a2 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned terryjreedy Mar 19, 2021
@miss-islington

miss-islington commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

Sorry @smontanaro and @terryjreedy, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7cb033c423b65def1632d6c3c747111543b342a2 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented Mar 19, 2021

Copy link
Copy Markdown
Member

Since the changes are purely a matter of form and not substance, I reviewed and merged.

It was not clear to me from the .txt itself whether it was describing the format of the current .co_lnotab attribute or that of the return of the new function that replaces it, or both, so I changes the title to match the unambiguous issue title using the doc title.

I then tried the backports, which failed. The 3.9 conflict suggests that the doc exists in 3.9. Skip, if so, and if you think the changes are relevant for you to do a backport, you can ask me to merge. The 3.8 'trouble checking out' is likely transitory, so a 3.9 backport might backport to 3.8.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jab added a commit to jab/cpython that referenced this pull request Mar 20, 2021
@jab
Merge branch 'master' into justin39/aiter-c
97d06e5 
* master: (129 commits)
  bpo-43452: Micro-optimizations to PyType_Lookup (pythonGH-24804)
  bpo-43517: Fix false positive in detection of circular imports (python#24895)
  bpo-43494: Make some minor changes to lnotab notes (pythonGH-24861)
  Mention that code.co_lnotab is deprecated in what's new for 3.10. (python#24902)
  bpo-43244: Remove symtable.h header file (pythonGH-24910)
  bpo-43466: Add --with-openssl-rpath configure option (pythonGH-24820)
  Fix a typo in c-analyzer (pythonGH-24468)
  bpo-41561: Add workaround for Ubuntu's custom security level (pythonGH-24915)
  bpo-43521: Allow ast.unparse with empty sets and NaN (pythonGH-24897)
  bpo-43244: Remove the PyAST_Validate() function (pythonGH-24911)
  bpo-43541: Fix PyEval_EvalCodeEx() regression (pythonGH-24918)
  bpo-43244: Fix test_peg_generators on Windows (pythonGH-24913)
  bpo-39342: Expose X509_V_FLAG_ALLOW_PROXY_CERTS in ssl module (pythonGH-18011)
  bpo-43244: Fix test_peg_generator for PyAST_Validate() (pythonGH-24912)
  bpo-42128: Add 'missing :' syntax error message to match statements (pythonGH-24733)
  bpo-43244: Add pycore_ast.h header file (pythonGH-24908)
  bpo-43244: Rename pycore_ast.h to pycore_ast_state.h (pythonGH-24907)
  Remove unnecessary imports in the grammar parser (pythonGH-24904)
  bpo-35883: Py_DecodeLocale() escapes invalid Unicode characters (pythonGH-24843)
  Add PEP 626 to what's new in 3.10. (python#24892)
  ...
@smontanaro
smontanaro deleted the patch-2 branch February 3, 2024 20:08
@ZeroIntensity ZeroIntensity removed the needs backport to 3.9 label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@smontanaro @miss-islington @terryjreedy @rhettinger @the-knights-who-say-ni @bedevere-bot @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.