GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40755: Add missing multiset operations to Counter() by rhettinger · Pull Request #20339 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented May 24, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue40755

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
rhettinger added 2 commits May 23, 2020 17:46
@rhettinger
Add basic definitions and invariants
538878c
@rhettinger
Neaten-up
ce91225
@rhettinger rhettinger added type-feature A feature request or enhancement DO-NOT-MERGE labels May 24, 2020
@rhettinger rhettinger self-assigned this May 24, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 24, 2020
@bedevere-bot bedevere-bot added the awaiting core review label May 24, 2020
@rhettinger rhettinger changed the title WIP: Add missing multiset operations to Counter() bpo-22533: [WIP] Add missing multiset operations to Counter() May 24, 2020
rhettinger added 10 commits May 23, 2020 18:24
@rhettinger
Add blurb
c160f82
@rhettinger
Remove the NotImplemented return values
987532f
@rhettinger
Handle iterable inputs. Add some tests
6a471a1
@rhettinger
Clean-up section on omitted operations
db9e0e6
@rhettinger
Improve clarity by separating element values
160b365
@rhettinger
Add tests. Handle negative values.
9c3e9a6
@rhettinger
Isolate the predicate tests with negative counts
8fc2b87
@rhettinger
Optimized early-out versions. Beef-up docstrings.
fdbe0c1
@rhettinger
Clean-ups and optimization for the common case
5e20521
@rhettinger
Add documentation
19a8b27
@rhettinger rhettinger removed the DO-NOT-MERGE label May 24, 2020
@rhettinger rhettinger changed the title bpo-22533: [WIP] Add missing multiset operations to Counter() bpo-22533: Add missing multiset operations to Counter() May 24, 2020
@rhettinger rhettinger changed the title bpo-22533: Add missing multiset operations to Counter() bpo-40755: Add missing multiset operations to Counter() May 24, 2020
@rhettinger
Use subset and superset symbols
74c471d
remilapeyre
remilapeyre reviewed May 24, 2020
View reviewed changes
Comment thread Lib/collections/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

csabella
csabella reviewed May 26, 2020
View reviewed changes
Comment thread Lib/collections/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@rhettinger
Fix typo in docstring
f26a84a
@rhettinger
rhettinger merged commit 6039851 into python:master May 28, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label May 28, 2020
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 30, 2020
@CuriousLearner
Merge branch 'master' of github.com:python/cpython into bpo-26543
d3d7100
* 'master' of github.com:python/cpython: (497 commits)
  bpo-40061: Fix a possible refleak in _asynciomodule.c (pythonGH-19748)
  bpo-40798: Generate a different message for already removed elements (pythonGH-20483)
  closes bpo-29017: Update the bindings for Qt information with PySide2 (pythonGH-20149)
  bpo-39885: Make IDLE context menu cut and copy work again (pythonGH-18951)
  bpo-29882: Add an efficient popcount method for integers (python#771)
  Further de-linting of zoneinfo module (python#20499)
  bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros (pythonGH-20435)
  Indicate that abs() method accept argument that implement __abs__(), just like call() method in the docs (pythonGH-20509)
  bpo-39040: Fix parsing of email mime headers with whitespace between encoded-words. (pythongh-17620)
  bpo-40784: Fix sqlite3 deterministic test (pythonGH-20448)
  bpo-30064: Properly skip unstable loop.sock_connect() racing test (pythonGH-20494)
  Note the output ordering of combinatoric functions (pythonGH-19732)
  bpo-40474: Updated coverage.yml to better report coverage stats (python#19851)
  bpo-40806: Clarify that itertools.product immediately consumes its inpt (pythonGH-20492)
  bpo-1294959: Try to clarify the meaning of platlibdir (pythonGH-20332)
  bpo-37878: PyThreadState_DeleteCurrent() was not removed (pythonGH-20489)
  bpo-40777: Initialize PyDateTime_IsoCalendarDateType.tp_base at run-time (pythonGH-20493)
  bpo-40755: Add missing multiset operations to Counter() (pythonGH-20339)
  bpo-25920: Remove socket.getaddrinfo() lock on macOS (pythonGH-20177)
  bpo-40275: Fix test.support.threading_helper (pythonGH-20488)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csabella csabella csabella left review comments
+1 more reviewer
@remilapeyre remilapeyre remilapeyre left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rhettinger rhettinger

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@rhettinger @csabella @remilapeyre @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.