GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40798: Generate a different message for already removed elements by DahlitzFlorian · Pull Request #20483 · python/cpython

Conversation

@DahlitzFlorian

@DahlitzFlorian DahlitzFlorian commented May 28, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@remilapeyre I did not include a news entry as it only affects the documentation.

https://bugs.python.org/issue40798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@DahlitzFlorian
bpo-40798: Generate a different message for already removed elements
3ebfe64
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 28, 2020
@bedevere-bot bedevere-bot added the awaiting review label May 28, 2020
remilapeyre
remilapeyre suggested changes May 28, 2020
View reviewed changes

@remilapeyre remilapeyre left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DahlitzFlorian !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/tools/extensions/pyspecific.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 28, 2020
@DahlitzFlorian
Simplify check as suggested by @remilapeyre
040023f
remilapeyre
remilapeyre suggested changes May 28, 2020
View reviewed changes
Comment thread Doc/tools/extensions/pyspecific.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@DahlitzFlorian
Remove unused import
aa378f3
remilapeyre
remilapeyre approved these changes May 28, 2020
View reviewed changes

@remilapeyre remilapeyre left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DahlitzFlorian, this looks great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

DahlitzFlorian reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@DahlitzFlorian

DahlitzFlorian commented May 28, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the guidance @remilapeyre!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@csabella
csabella requested a review from JulienPalard May 28, 2020 17:14
@JulienPalard JulienPalard added the skip news label May 29, 2020
@JulienPalard

JulienPalard commented May 29, 2020

Copy link
Copy Markdown
Member

Thanks @DahlitzFlorian I like it a lot!

Could you just add the new string to Doc/tools/templates/dummy.html so it get picked up by gettext and get translated?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@DahlitzFlorian
Add _removed_label text for translation
6b7b016
@DahlitzFlorian

DahlitzFlorian commented May 29, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback and pointing me at the translation part, @JulienPalard!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JulienPalard
JulienPalard approved these changes May 30, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 30, 2020
@JulienPalard

JulienPalard commented May 30, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thanks @DahlitzFlorian! I'll be happy to see it in prod (and translated!)!

DahlitzFlorian reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard JulienPalard added needs backport to 3.8 labels May 30, 2020
@JulienPalard
JulienPalard merged commit 735d902 into python:master May 30, 2020
@miss-islington

miss-islington commented May 30, 2020

Copy link
Copy Markdown
Contributor

Thanks @DahlitzFlorian for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed awaiting merge needs backport to 3.9 labels May 30, 2020
@bedevere-bot

bedevere-bot commented May 30, 2020

Copy link
Copy Markdown

GH-20531 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented May 30, 2020

Copy link
Copy Markdown

GH-20532 is a backport of this pull request to the 3.8 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 label May 30, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2020
@DahlitzFlorian @miss-islington
bpo-40798: Generate a different message for already removed elements (p…
a89ed10
…ythonGH-20483)

(cherry picked from commit 735d902)

Co-authored-by: Florian Dahlitz <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2020
@DahlitzFlorian @miss-islington
bpo-40798: Generate a different message for already removed elements (p…
7e89dde
…ythonGH-20483)

(cherry picked from commit 735d902)

Co-authored-by: Florian Dahlitz <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label May 30, 2020
@bedevere-bot

bedevere-bot commented May 30, 2020

Copy link
Copy Markdown

GH-20533 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington added a commit that referenced this pull request May 30, 2020
@miss-islington @DahlitzFlorian
bpo-40798: Generate a different message for already removed elements (G…
a9dbae4
…H-20483)

(cherry picked from commit 735d902)

Co-authored-by: Florian Dahlitz <[email protected]>
miss-islington added a commit that referenced this pull request May 30, 2020
@miss-islington @DahlitzFlorian
bpo-40798: Generate a different message for already removed elements (G…
588efc2
…H-20483)

(cherry picked from commit 735d902)

Co-authored-by: Florian Dahlitz <[email protected]>
miss-islington added a commit that referenced this pull request May 30, 2020
@miss-islington @DahlitzFlorian
bpo-40798: Generate a different message for already removed elements (G…
ba1c2c8
…H-20483)

(cherry picked from commit 735d902)

Co-authored-by: Florian Dahlitz <[email protected]>
@DahlitzFlorian
DahlitzFlorian deleted the fix-issue-40798 branch May 30, 2020 08:01
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 30, 2020
@CuriousLearner
Merge branch 'master' of github.com:python/cpython into bpo-26543
d3d7100
* 'master' of github.com:python/cpython: (497 commits)
  bpo-40061: Fix a possible refleak in _asynciomodule.c (pythonGH-19748)
  bpo-40798: Generate a different message for already removed elements (pythonGH-20483)
  closes bpo-29017: Update the bindings for Qt information with PySide2 (pythonGH-20149)
  bpo-39885: Make IDLE context menu cut and copy work again (pythonGH-18951)
  bpo-29882: Add an efficient popcount method for integers (python#771)
  Further de-linting of zoneinfo module (python#20499)
  bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros (pythonGH-20435)
  Indicate that abs() method accept argument that implement __abs__(), just like call() method in the docs (pythonGH-20509)
  bpo-39040: Fix parsing of email mime headers with whitespace between encoded-words. (pythongh-17620)
  bpo-40784: Fix sqlite3 deterministic test (pythonGH-20448)
  bpo-30064: Properly skip unstable loop.sock_connect() racing test (pythonGH-20494)
  Note the output ordering of combinatoric functions (pythonGH-19732)
  bpo-40474: Updated coverage.yml to better report coverage stats (python#19851)
  bpo-40806: Clarify that itertools.product immediately consumes its inpt (pythonGH-20492)
  bpo-1294959: Try to clarify the meaning of platlibdir (pythonGH-20332)
  bpo-37878: PyThreadState_DeleteCurrent() was not removed (pythonGH-20489)
  bpo-40777: Initialize PyDateTime_IsoCalendarDateType.tp_base at run-time (pythonGH-20493)
  bpo-40755: Add missing multiset operations to Counter() (pythonGH-20339)
  bpo-25920: Remove socket.getaddrinfo() lock on macOS (pythonGH-20177)
  bpo-40275: Fix test.support.threading_helper (pythonGH-20488)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard approved these changes
+1 more reviewer
@remilapeyre remilapeyre remilapeyre approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@DahlitzFlorian @JulienPalard @miss-islington @bedevere-bot @remilapeyre @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.