GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-37878: PyThreadState_DeleteCurrent() was not removed by vstinner · Pull Request #20489 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 28, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Update What's New in Python 3.9.

https://bugs.python.org/issue37878

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-37878: PyThreadState_DeleteCurrent() was not removed
6e321df 
Update What's New in Python 3.9.
@vstinner vstinner added the skip news label May 28, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 28, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels May 28, 2020
@vstinner vstinner mentioned this pull request May 28, 2020
bpo-37878: Make PyThreadState_DeleteCurrent() Internal #15315
Merged
@vstinner

vstinner commented May 28, 2020

Copy link
Copy Markdown
Member Author

Issue reported at #15315 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 approved these changes May 28, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 28, 2020
@corona10 corona10 added the needs backport to 3.9 label May 28, 2020
@henryiii

henryiii commented May 28, 2020

Copy link
Copy Markdown
Contributor

Should you mention that it has been moved? There is a section below about changes to the limited ABI that it might fit in. If PyBind11 is the only user, though, we already know that. :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
PyThreadState_DeleteCurrent was excluded from the limited C API
e96c352
henryiii
henryiii approved these changes May 28, 2020
View reviewed changes

@henryiii henryiii left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@henryiii henryiii mentioned this pull request May 28, 2020
Pybind11 doesn't compile with CPython 3.9b1 pybind/pybind11#2224
Closed
@vstinner

vstinner commented May 28, 2020

Copy link
Copy Markdown
Member Author

Should you mention that it has been moved? There is a section below about changes to the limited ABI that it might fit in.

Done.

If PyBind11 is the only user, though, we already know that. :)

I don't understand why you mention PyBind11 here. In #15315 (comment) you wrote that PyBind11 does not use the limited C API. So PyBind11 is not impactd by https://bugs.python.org/issue37878 changes, right?

You also wrote "Now that 3.9b1 is out, PyBind11-based libraries cannot build" but you didn't explain what is your error.

I don't understand what are you expecting? Do you want to move back the function to the limited C API? Does Pybind11 use the limited C API or not? It's unclear.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@henryiii

henryiii commented May 28, 2020

Copy link
Copy Markdown
Contributor

It needs to make sure it includes the correct header since this has moved, but otherwise, it does not need to change. PyBind11 does not use the limited API.

There is currently a different issue as well, but I think I was only tripping up on a deprecated warning and falling to compile because I had warnings as errors. I'm setting up a PyBind11 CI build on Python 3.9 and so far it looks promising. I don't think there's an issue from the Python side.

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 28, 2020

Copy link
Copy Markdown
Member Author

It needs to make sure it includes the correct header

Include/cpython/pystate.h is included automatically by Include/pystate.h and cannot be included directly (it fails with a compilation error).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit fda7f6d into python:master May 28, 2020
@miss-islington

miss-islington commented May 28, 2020

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 28, 2020
@vstinner
vstinner deleted the whatnews39_delete_current branch May 28, 2020 16:26
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2020
@vstinner @miss-islington
bpo-37878: PyThreadState_DeleteCurrent() was not removed (pythonGH-20489
1545fad 
)

Update What's New in Python 3.9.

PyThreadState_DeleteCurrent was not removed, but excluded from the limited C API.
(cherry picked from commit fda7f6d)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label May 28, 2020
@bedevere-bot

bedevere-bot commented May 28, 2020

Copy link
Copy Markdown

GH-20496 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request May 28, 2020
@miss-islington @vstinner
bpo-37878: PyThreadState_DeleteCurrent() was not removed (GH-20489)
6a47864 
Update What's New in Python 3.9.

PyThreadState_DeleteCurrent was not removed, but excluded from the limited C API.
(cherry picked from commit fda7f6d)

Co-authored-by: Victor Stinner <[email protected]>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 30, 2020
@CuriousLearner
Merge branch 'master' of github.com:python/cpython into bpo-26543
d3d7100 
* 'master' of github.com:python/cpython: (497 commits)
  bpo-40061: Fix a possible refleak in _asynciomodule.c (pythonGH-19748)
  bpo-40798: Generate a different message for already removed elements (pythonGH-20483)
  closes bpo-29017: Update the bindings for Qt information with PySide2 (pythonGH-20149)
  bpo-39885: Make IDLE context menu cut and copy work again (pythonGH-18951)
  bpo-29882: Add an efficient popcount method for integers (python#771)
  Further de-linting of zoneinfo module (python#20499)
  bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros (pythonGH-20435)
  Indicate that abs() method accept argument that implement __abs__(), just like call() method in the docs (pythonGH-20509)
  bpo-39040: Fix parsing of email mime headers with whitespace between encoded-words. (pythongh-17620)
  bpo-40784: Fix sqlite3 deterministic test (pythonGH-20448)
  bpo-30064: Properly skip unstable loop.sock_connect() racing test (pythonGH-20494)
  Note the output ordering of combinatoric functions (pythonGH-19732)
  bpo-40474: Updated coverage.yml to better report coverage stats (python#19851)
  bpo-40806: Clarify that itertools.product immediately consumes its inpt (pythonGH-20492)
  bpo-1294959: Try to clarify the meaning of platlibdir (pythonGH-20332)
  bpo-37878: PyThreadState_DeleteCurrent() was not removed (pythonGH-20489)
  bpo-40777: Initialize PyDateTime_IsoCalendarDateType.tp_base at run-time (pythonGH-20493)
  bpo-40755: Add missing multiset operations to Counter() (pythonGH-20339)
  bpo-25920: Remove socket.getaddrinfo() lock on macOS (pythonGH-20177)
  bpo-40275: Fix test.support.threading_helper (pythonGH-20488)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
+1 more reviewer
@henryiii henryiii henryiii approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@vstinner @henryiii @miss-islington @bedevere-bot @corona10 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.