GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. by hongweipeng · Pull Request #20911 · python/cpython

Conversation

hongweipeng commented Jun 16, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

https://bugs.python.org/issue30533

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

the-knights-who-say-ni added the CLA signed label

Jun 16, 2020

bedevere-bot added the awaiting review label

Jun 16, 2020

kernc commented Jun 16, 2020

Copy link

Copy Markdown

Contributor

Also refs: https://bugs.python.org/issue38337
Closes: #16521

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hongweipeng force-pushed the add_getmembers_static branch from aecbf4a to 6b78c0a Compare

November 18, 2020 06:12

hongweipeng added 2 commits

July 15, 2021 14:37


          Add function inspect.getmembers_static that does not call properties …

8ba3a08

…or dynamic

properties.


          udpate _getmembers args

a708ace

hongweipeng force-pushed the add_getmembers_static branch from 6b78c0a to a708ace Compare

July 15, 2021 06:45

itamaro reviewed

Nov 10, 2021

View reviewed changes

itamaro left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed bpo-30533 has this patch attached.

I was able to apply this patch cleanly on latest main branch, and built and ran the test_inspect test.

Left a few comments around docstrings, but the functionality lgtm - would be great if a core dev could take a look :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kernc reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

Lib/inspect.py Outdated

Comment on lines 445 to 446

		"""Return all members of an object as (name, value) pairs sorted by name.
		Optionally, only return members that satisfy a given predicate."""

itamaro Nov 10, 2021

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this function is converted to an internal implementation detail with non-optional predicate and getter args, need to either update the docstring to match the change, or drop the docstring altogether

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

DinoV reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

Lib/inspect.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Library/2020-06-16-18-00-56.bpo-30533.StL57t.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

hongweipeng and others added 3 commits

November 10, 2021 20:00


          Update Misc/NEWS.d/next/Library/2020-06-16-18-00-56.bpo-30533.StL57t.rst

77408b9

Co-authored-by: Itamar Ostricher <[email protected]>


          Update Lib/inspect.py

f13421a

Co-authored-by: Itamar Ostricher <[email protected]>


          Removes the copy pasted doc string

206ea77

DinoV approved these changes

Nov 30, 2021

View reviewed changes

DinoV left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting review labels

Nov 30, 2021

DinoV merged commit af8c8ca into python:main

Nov 30, 2021

bedevere-bot commented Nov 30, 2021

Copy link

Copy Markdown

@DinoV: Please replace # with GH- in the commit message next time. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Nov 30, 2021

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Dec 1, 2021


          Merge branch 'main' into bpo_44133

6edb6f5

* main: (21 commits)
  bpo-45876:  Have stdev() also use decimal specific square root. (pythonGH-29869)
  bpo-45876:  Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)
  bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)
  bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)
  bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)
  bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)
  bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)
  Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)
  no-issue: remove unused import from test_graphlib.py (pythonGH-29853)
  bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)
  bpo-45653: fix test_embed on windows (pythonGH-29814)
  bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)
  bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)
  bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)
  bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)
  bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)
  bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)
  bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)
  bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)
  bpo-45847: Make socket module conditional (pythonGH-29769)
  ...

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Dec 1, 2021


          Merge branch 'main' into bpo_44133

b71b124

* main: (21 commits)
  bpo-45876:  Have stdev() also use decimal specific square root. (pythonGH-29869)
  bpo-45876:  Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)
  bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)
  bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)
  bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)
  bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)
  bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)
  Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)
  no-issue: remove unused import from test_graphlib.py (pythonGH-29853)
  bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)
  bpo-45653: fix test_embed on windows (pythonGH-29814)
  bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)
  bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)
  bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)
  bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)
  bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)
  bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)
  bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)
  bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)
  bpo-45847: Make socket module conditional (pythonGH-29769)
  ...

rabernat mentioned this pull request

Apr 6, 2024

Fix serialization bug which triggers side effects on dynamic attributes lithops-cloud/lithops#1302

Closed

Reviewers

itamaro

itamaro left review comments

DinoV

DinoV approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

hongweipeng commented Jun 16, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kernc commented Jun 16, 2020

Uh oh!

itamaro left a comment

Choose a reason for hiding this comment

Uh oh!

itamaro Nov 10, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DinoV left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Nov 30, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hongweipeng commented Jun 16, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.