GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-45917: Add math.exp2() method - return 2 raised to the power of x by Turreted · Pull Request #29829 · python/cpython

Conversation

Turreted commented Nov 29, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

https://bugs.python.org/issue45917

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Turreted added 5 commits

November 28, 2021 20:20


          add math.exp2 to python's math library

31a27c1


          update documentation to include math.exp2

5ab6380


          add tests for math.exp2

66f67f7


          Merge branch 'main' CPython into issue45917

51a9f02


          add blurb documentation

3c7b741

the-knights-who-say-ni added the CLA not signed label

Nov 29, 2021

the-knights-who-say-ni commented Nov 29, 2021

Copy link

Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Turreted

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting review label

Nov 29, 2021

tim-one approved these changes

Nov 29, 2021

View reviewed changes

tim-one left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - nice work! 😃

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting review labels

Nov 29, 2021

mdickinson reviewed

Nov 29, 2021

View reviewed changes

Comment thread

Lib/test/test_math.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

mdickinson reviewed

Nov 29, 2021

View reviewed changes

Comment thread

Misc/NEWS.d/next/Library/2021-11-28-22-44-54.bpo-45917.lNn_gz.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

mdickinson approved these changes

Nov 29, 2021

View reviewed changes

mdickinson left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One suggestion for an extra unit test, and it looks as though one of the added Misc/NEWS.d files needs to be deleted.

I'll fire off a round of buildbot checks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mdickinson added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Nov 29, 2021

bedevere-bot commented Nov 29, 2021

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 3c7b741 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Nov 29, 2021

the-knights-who-say-ni added CLA signed and removed CLA not signed labels

Nov 29, 2021

Turreted and others added 2 commits

November 29, 2021 10:27


          Resolve Blurb error

54ad30a


          Add non-integral testcase to Lib/test/test_math.py

b41d5d7

Co-authored-by: Mark Dickinson <[email protected]>

mdickinson commented Nov 29, 2021

Copy link

Copy Markdown

Member

The buildbots all seem to be either happy, stalled, or failing for reasons that are clearly unrelated to this PR; no evidence of any issues.

Still LGTM! Will merge when CI completes.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mdickinson reviewed

Nov 29, 2021

View reviewed changes

Comment thread

Doc/library/math.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Inter-function spacing consistency in .rst file

23e5bb8

mdickinson merged commit 6266e4a into python:main

Nov 29, 2021

bedevere-bot removed the awaiting merge label

Nov 29, 2021

mdickinson added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Nov 29, 2021

bedevere-bot commented Nov 29, 2021

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 23e5bb8 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Nov 29, 2021

Turreted deleted the issue45917 branch

November 29, 2021 20:24

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Dec 1, 2021


          Merge branch 'main' into bpo_44133

6edb6f5

* main: (21 commits)
  bpo-45876:  Have stdev() also use decimal specific square root. (pythonGH-29869)
  bpo-45876:  Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)
  bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)
  bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)
  bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)
  bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)
  bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)
  Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)
  no-issue: remove unused import from test_graphlib.py (pythonGH-29853)
  bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)
  bpo-45653: fix test_embed on windows (pythonGH-29814)
  bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)
  bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)
  bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)
  bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)
  bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)
  bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)
  bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)
  bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)
  bpo-45847: Make socket module conditional (pythonGH-29769)
  ...

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Dec 1, 2021


          Merge branch 'main' into bpo_44133

b71b124

* main: (21 commits)
  bpo-45876:  Have stdev() also use decimal specific square root. (pythonGH-29869)
  bpo-45876:  Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)
  bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)
  bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)
  bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)
  bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)
  bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)
  Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)
  no-issue: remove unused import from test_graphlib.py (pythonGH-29853)
  bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)
  bpo-45653: fix test_embed on windows (pythonGH-29814)
  bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)
  bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)
  bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)
  bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)
  bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)
  bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)
  bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)
  bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)
  bpo-45847: Make socket module conditional (pythonGH-29769)
  ...

jopemachine mentioned this pull request

Sep 8, 2022

Add math.exp2 implemented in cpython 3.11 RustPython/RustPython#4150

Merged

Reviewers

2 more reviewers

mdickinson

mdickinson approved these changes

tim-one

tim-one approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Turreted commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Nov 29, 2021

Recognized GitHub username

Uh oh!

tim-one left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mdickinson left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Nov 29, 2021

Uh oh!

mdickinson commented Nov 29, 2021

Uh oh!

Uh oh!

bedevere-bot commented Nov 29, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Turreted commented Nov 29, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.