GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45881: configure --with-freeze-module --with-build-python (GH-29835) by tiran · Pull Request #29835 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 29, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Make cross compiling more convenient. configure now takes
--with-freeze-module and --with-build-python arguments. There is
no need pass FREEZE_MODULE and PYTHON_FOR_BUILD env vars any
more.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue45881

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tiran
tiran requested a review from erlend-aasland November 29, 2021 11:45
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 29, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 29, 2021
@tiran
tiran marked this pull request as draft November 29, 2021 11:46
@tiran

tiran commented Nov 29, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@ethanhs

This changeset makes our configure call easier: emconfigure ../../configure -C --with-freeze-module=$(pwd)/../build/Programs/_freeze_module --with-build-python=$(pwd)/../build/python

  • improve help strings
  • write documentation
  • adds blurb
emmatyping reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland
erlend-aasland approved these changes Nov 29, 2021
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

emmatyping
emmatyping reviewed Nov 29, 2021
View reviewed changes

@emmatyping emmatyping left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bunch of minor nits but overall this looks good! I also think we should be strict in checking that the Python version used for _freeze_module is the same as the host Python.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

@tiran
tiran force-pushed the bpo-45881-cross-freeze branch from 772abec to 7fbc2b4 Compare November 29, 2021 15:30
@tiran
tiran marked this pull request as ready for review November 29, 2021 15:31
tiran and others added 7 commits November 29, 2021 16:34
@tiran
bpo-45881: configure --with-freeze-module --with-build-python
2a31f90
Make cross compiling more convenient. configure now takes
``--with-freeze-module`` and ``--with-build-python`` arguments. There is
no need pass ``FREEZE_MODULE`` and ``PYTHON_FOR_BUILD`` env vars any
more.

Signed-off-by: Christian Heimes <[email protected]>
@tiran Erlend Egeberg Aasland
Rename arg to freeze-module
0a8c339
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@tiran @emmatyping
it's called _freeze_module
47f9e2e
Co-authored-by: Ethan Smith <[email protected]>
@tiran @emmatyping
Update configure.ac
ad8c9da
Co-authored-by: Ethan Smith <[email protected]>
@tiran @emmatyping
Update configure.ac
deab8e9
Co-authored-by: Ethan Smith <[email protected]>
@tiran
More docs
04d8eb0
@tiran
blurb
e4eff12
@tiran
tiran force-pushed the bpo-45881-cross-freeze branch from 158a573 to e4eff12 Compare November 29, 2021 15:34
emmatyping
emmatyping approved these changes Nov 29, 2021
View reviewed changes
@tiran tiran changed the title bpo-45881: configure --with-freeze-module --with-build-python bpo-45881: configure --with-freeze-module --with-build-python (GH-29835) Nov 29, 2021
@tiran
tiran merged commit 992565f into python:main Nov 29, 2021
@tiran
tiran deleted the bpo-45881-cross-freeze branch November 29, 2021 16:23
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 29, 2021
tiran added a commit to tiran/python-wasm that referenced this pull request Nov 29, 2021
@tiran
Use new --with-freeze-module and --with-build-python options
7f69833
See: python/cpython#29835
Signed-off-by: Christian Heimes <[email protected]>
@tiran tiran mentioned this pull request Nov 29, 2021
Use new --with-freeze-module and --with-build-python options emmatyping/python-wasm#15
Merged
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Dec 1, 2021
@shihai1991
Merge branch 'main' into bpo_44133
6edb6f5
* main: (21 commits)
  bpo-45876:  Have stdev() also use decimal specific square root. (pythonGH-29869)
  bpo-45876:  Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)
  bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)
  bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)
  bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)
  bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)
  bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)
  Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)
  no-issue: remove unused import from test_graphlib.py (pythonGH-29853)
  bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)
  bpo-45653: fix test_embed on windows (pythonGH-29814)
  bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)
  bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)
  bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)
  bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)
  bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)
  bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)
  bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)
  bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)
  bpo-45847: Make socket module conditional (pythonGH-29769)
  ...
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Dec 1, 2021
@shihai1991
Merge branch 'main' into bpo_44133
b71b124
* main: (21 commits)
  bpo-45876:  Have stdev() also use decimal specific square root. (pythonGH-29869)
  bpo-45876:  Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)
  bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)
  bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)
  bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)
  bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)
  bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)
  Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)
  no-issue: remove unused import from test_graphlib.py (pythonGH-29853)
  bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)
  bpo-45653: fix test_embed on windows (pythonGH-29814)
  bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)
  bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)
  bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)
  bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)
  bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)
  bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)
  bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)
  bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)
  bpo-45847: Make socket module conditional (pythonGH-29769)
  ...
@emmatyping emmatyping mentioned this pull request Dec 2, 2021
sysconfig info module is misnamed/not found emmatyping/python-wasm#2
Closed
This was referenced Apr 11, 2022
cross: wrong interpreter returned when no python available #88228
Open
bpo-44062: Fix PYTHON_FOR_BUILD interpreter lookup for cross-compile … #25951
Closed
@tiran tiran mentioned this pull request Apr 10, 2022
Cross compiling on Linux is untested, undocumented, and broken #90039
Closed
@methane methane mentioned this pull request Sep 30, 2026
document cross compilation #72728
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@emmatyping emmatyping emmatyping approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tiran @emmatyping @erlend-aasland @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.