GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [doc] Fix a typo in the graphlib docs by mariosasko · Pull Request #22030 · python/cpython

Conversation

mariosasko commented Aug 31, 2020

Copy link

Copy Markdown

Contributor

This PR fixes a typo in the docs of a TopologicalSorter.is_active.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          [doc] Fix a typo in the graphlib docs

81aa093

the-knights-who-say-ni added the CLA not signed label

Aug 31, 2020

the-knights-who-say-ni commented Aug 31, 2020

Copy link

Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@mariosasko

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added docs

Documentation in the Doc dir

awaiting review labels

Aug 31, 2020

the-knights-who-say-ni added CLA signed and removed CLA not signed labels

Aug 31, 2020

tirkarthi added skip issue skip news labels

Sep 1, 2020

tirkarthi approved these changes

Sep 1, 2020

View reviewed changes

tirkarthi left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mariosasko reacted with thumbs up emoji

All reactions

👍 1 reaction

bedevere-bot added awaiting merge and removed awaiting review labels

Sep 1, 2020

tirkarthi requested a review from pablogsal

September 1, 2020 13:42

tirkarthi commented Sep 1, 2020

Copy link

Copy Markdown

Member

Please update your branch with the latest master branch since it has changes that will help docs build error.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pablogsal self-assigned this

Sep 1, 2020


          Merge remote-tracking branch 'upstream/master' into develop/fix-graph…

2b20da4

…lib-docs

mariosasko commented Sep 2, 2020

Copy link

Copy Markdown

Contributor Author

Please update your branch with the latest master branch since it has changes that will help docs build error.

Did it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pablogsal added the needs backport to 3.9 label

Sep 3, 2020

pablogsal merged commit 8516060 into python:master

Sep 3, 2020

bedevere-bot commented Sep 3, 2020

Copy link

Copy Markdown

@pablogsal: Please replace # with GH- in the commit message next time. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Sep 3, 2020

Copy link

Copy Markdown

Contributor

Thanks @mariosasko for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Sep 3, 2020

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 3, 2020


          [doc] Fix a typo in the graphlib docs (pythonGH-22030)

a0b69c8

(cherry picked from commit 8516060)

Co-authored-by: Mario Šaško <[email protected]>

bedevere-bot commented Sep 3, 2020

Copy link

Copy Markdown

GH-22076 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.9 label

Sep 3, 2020

pablogsal commented Sep 3, 2020

Copy link

Copy Markdown

Member

Thanks @mariosasko for the PR! 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington added a commit that referenced this pull request

Sep 4, 2020


          [3.9] [doc] Fix a typo in the graphlib docs (GH-22030) (GH-22076)

672d8b9

(cherry picked from commit 8516060)


Co-authored-by: Mario Šaško <[email protected]>

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Sep 5, 2020


          Merge remote-tracking branch 'origin/master' into bpo_41073_add_types…

7537c86

…lots1

* origin/master: (63 commits)
  bpo-41627: Distinguish 32 and 64-bit user site packages on Windows (pythonGH-22098)
  bpo-38585: Remove references to defusedexpat (pythonGH-22095)
  bpo-41721: Add xlc options (pythonGH-22096)
  bpo-40486: Specify what happens if directory content change diring iteration (pythonGH-22025)
  bpo-41638: Improve ProgrammingError message for absent parameter. (pythonGH-21999)
  bpo-41713: _signal doesn't use multi-phase init (pythonGH-22087)
  bpo-41700: Skip test if the locale is not supported (pythonGH-22081)
  [doc] Update documentation on logging optimization. (pythonGH-22075)
  Fix 'gather' rules in the python parser generator (pythonGH-22021)
  bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in the parser (pythonGH-22077)
  [doc] Fix a typo in the graphlib docs (python#22030)
  bpo-1635741: Port _signal module to multi-phase init (PEP 489) (pythonGH-22049)
  bpo-39883: Use BSD0 license for code in docs (pythonGH-17635)
  bpo-39010: Improve test shutdown (python#22066)
  bpo-41696: Fix handling of debug mode in asyncio.run (python#22069)
  bpo-41690: Use a loop to collect args in the parser instead of recursion (pythonGH-22053)
  closes bpo-41689: Preserve text signature from tp_doc in C heap type creation. (pythonGH-22058)
  Fix invalid escape sequences in the peg_highlight Sphinx extension (pythonGH-22047)
  bpo-41675: Modernize siginterrupt calls (pythonGH-22028)
  bpo-41685: Don't pin setuptools version anymore in Doc/Makefile (pythonGH-22062)
  ...

xzy3 pushed a commit to xzy3/cpython that referenced this pull request

Oct 18, 2020


          [doc] Fix a typo in the graphlib docs (python#22030)

686da96

Reviewers

tirkarthi

tirkarthi approved these changes

pablogsal

Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

pablogsal

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.