GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-1635741 port signalmodule to multi-phase init (PEP 489) by koubaa · Pull Request #22049 · python/cpython

Conversation

koubaa commented Sep 1, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

koubaa added 2 commits

September 1, 2020 17:06


          port signalmodule to multi-phase

dc55479


          blurb

c85ad8f

the-knights-who-say-ni added the CLA signed label

Sep 1, 2020

bedevere-bot added the awaiting review label

Sep 1, 2020

koubaa commented Sep 1, 2020

Copy link

Copy Markdown

Contributor Author

@vstinner @shihai1991 I split this from the other PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner reviewed

Sep 2, 2020

View reviewed changes

Comment thread

Modules/signalmodule.c Outdated

		return -1;
		}
		Py_INCREF((PyObject*) &SiginfoType);
		PyModule_AddObject(m, "struct_siginfo", (PyObject*) &SiginfoType);

vstinner Sep 2, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check for error. On error, DECREF is needed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Misc/NEWS.d/next/Core and Builtins/2020-09-01-17-07-20.bpo-1635741.7wSuCc.rst Outdated

		@@ -0,0 +1,2 @@
		Port the :mod:`signalmodule` extension module to multi-phase initialization

vstinner Sep 2, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module is called "_signal":

Suggested change

	Port the :mod:`signalmodule` extension module to multi-phase initialization
	Port the :mod:`_signal` extension module to multi-phase initialization

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Modules/signalmodule.c Outdated

		/* add the functions */
		#if defined(HAVE_SIGWAITINFO) \|\| defined(HAVE_SIGTIMEDWAIT)
		if (!initialized) {
		if (PyStructSequence_InitType2(&SiginfoType, &struct_siginfo_desc) < 0)

vstinner Sep 2, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be nice to convert the static type SiginfoType to a heap type, but it can be done later.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

koubaa Sep 2, 2020

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner what is the procedure for types defined using PyStructSequence_InitType2?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Sep 3, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

shihai1991 reviewed

Sep 2, 2020

View reviewed changes

Comment thread

Modules/signalmodule.c Outdated

		return -1;
		}
		Py_INCREF((PyObject*) &SiginfoType);
		PyModule_AddObject(m, "struct_siginfo", (PyObject*) &SiginfoType);

shihai1991 Sep 2, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can use PyModule_AddType() in here?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

koubaa Sep 2, 2020

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shihai1991 good idea, this simplifies the error handling too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

koubaa added 2 commits

September 2, 2020 18:24


          improvements

78b7f2c


          fix syntax issue

748371d

vstinner merged commit 71d1bd9 into python:master

Sep 3, 2020

bedevere-bot removed the awaiting review label

Sep 3, 2020

vstinner commented Sep 4, 2020

Copy link

Copy Markdown

Member

This change introduced a regression: https://bugs.python.org/issue41713

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added a commit that referenced this pull request

Sep 4, 2020


          Revert "bpo-1635741: Port _signal module to multi-phase init (PEP 489) (

9278ddf

GH-22049)"

This reverts commit 71d1bd9.

vstinner commented Sep 4, 2020

Copy link

Copy Markdown

Member

I partially reverted this change with PR #22087 to quickly fix https://bugs.python.org/issue41713.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Sep 5, 2020


          Merge remote-tracking branch 'origin/master' into bpo_41073_add_types…

7537c86

…lots1

* origin/master: (63 commits)
  bpo-41627: Distinguish 32 and 64-bit user site packages on Windows (pythonGH-22098)
  bpo-38585: Remove references to defusedexpat (pythonGH-22095)
  bpo-41721: Add xlc options (pythonGH-22096)
  bpo-40486: Specify what happens if directory content change diring iteration (pythonGH-22025)
  bpo-41638: Improve ProgrammingError message for absent parameter. (pythonGH-21999)
  bpo-41713: _signal doesn't use multi-phase init (pythonGH-22087)
  bpo-41700: Skip test if the locale is not supported (pythonGH-22081)
  [doc] Update documentation on logging optimization. (pythonGH-22075)
  Fix 'gather' rules in the python parser generator (pythonGH-22021)
  bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in the parser (pythonGH-22077)
  [doc] Fix a typo in the graphlib docs (python#22030)
  bpo-1635741: Port _signal module to multi-phase init (PEP 489) (pythonGH-22049)
  bpo-39883: Use BSD0 license for code in docs (pythonGH-17635)
  bpo-39010: Improve test shutdown (python#22066)
  bpo-41696: Fix handling of debug mode in asyncio.run (python#22069)
  bpo-41690: Use a loop to collect args in the parser instead of recursion (pythonGH-22053)
  closes bpo-41689: Preserve text signature from tp_doc in C heap type creation. (pythonGH-22058)
  Fix invalid escape sequences in the peg_highlight Sphinx extension (pythonGH-22047)
  bpo-41675: Modernize siginterrupt calls (pythonGH-22028)
  bpo-41685: Don't pin setuptools version anymore in Doc/Makefile (pythonGH-22062)
  ...

xzy3 pushed a commit to xzy3/cpython that referenced this pull request

Oct 18, 2020


          bpo-1635741: Port _signal module to multi-phase init (PEP 489) (pytho…

66dcc0e

…nGH-22049)

kylotan mannequin mentioned this pull request

Sep 19, 2022

Py_Finalize() doesn't clear all Python objects at exit #44470

Closed

Reviewers

vstinner

vstinner left review comments

shihai1991

shihai1991 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

koubaa commented Sep 1, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koubaa commented Sep 1, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vstinner commented Sep 4, 2020

Uh oh!

vstinner commented Sep 4, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

koubaa commented Sep 1, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.